[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=381255

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=419960

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||dgetsaddons/00bce130d35e9dc
   ||398709e690a05f8dde70f52b3
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Nate Graham  ---
Git commit 00bce130d35e9dc398709e690a05f8dde70f52b3 by Nathaniel Graham.
Committed on 08/05/2018 at 13:14.
Pushed by ngraham into branch 'master'.

Make KMessageWidget match Kirigami inlineMessage's style

Summary:
This patch makes the venerable and wonderful `KMessageWidget` match the slick
style of Kirigami's new `inlineMessage` control. As a by-product, it fixes a
few usability bugs.

I didn't implement the drop shadow here because I couldn't get it to look
right.
Related: bug 385299

Test Plan:
Spectacle, Breeze light, information:
{F5828175}

Spectacle, Breeze dark, information:
{F5828176}

Spectacle, Breeze light, positive:
{F5828177}

Spectacle, Breeze dark, positive:
{F5828178}

Dolphin, Breeze light, negative:
{F5828180}

Dolphin, Breeze dark, negative:
{F5828179}

Dolphin, Breeze light, warning:
{F5838438}

Konsole, Breeze light with dark profile theme, warning:
{F5838446}

Konsole, Breeze dark with light profile theme, information:
{F5838445}

Konsole, Breeze light, information:
{F5838437}

Kate, Breeze light, positive:
{F5838428}

Kate, Breeze dark, information:
{F5838429}

Reviewers: hein, #plasma, #vdg, elvisangelaccio, cfeck

Reviewed By: hein, #plasma, cfeck

Subscribers: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio,
jnoack, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D12508

M  +34   -46   src/kmessagewidget.cpp
M  +2-0src/kmessagewidget.h

https://commits.kde.org/kwidgetsaddons/00bce130d35e9dc398709e690a05f8dde70f52b3

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=381255

--- Comment #7 from Christoph Feck  ---
*** Bug 389981 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=381255

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

--- Comment #6 from Nate Graham  ---
FYI Christoph, we are going to be using the "usability" keyword to track the
bugs we're targeting for https://phabricator.kde.org/T6831. I've triaged all
existing bugs with that keyword and added some more, including this one. Would
you mind if we kept that here?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=381255

Christoph Feck  changed:

   What|Removed |Added

   Keywords|usability   |accessibility

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=381255

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

--- Comment #5 from Nate Graham  ---
- Give links a white shadow or outline to make the text stand out from the
colored background (I tried this using a CSS stylesheet but it didn't work
because text-shadow is a CSS3 property, and Qt's stylesheet support only goes
to CSS2, so rendering the shadow would have done be done in C++)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from Nate Graham  ---
Preserving the traditional blue color of an unvisited link is a good idea from
a UX standpoint, though, since it's instantly recognizable.

Ideas:
- Stop using KMessageWidget to communicate status in Spectacle
- Move the link outside of the KMessageWidget in Spectacle
- Change KMessageWidget's visual style to allow clearer text presentation.
Perhaps the blue/green/red color could only extend to the border, with the
center following the theme's standard color scheme?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=381255

--- Comment #3 from Christoph Feck  ---
Right now it is impossible to customize the colors of links in a QLabel. A
possible workaround is to use a QTextBrowser.

https://stackoverflow.com/questions/5497799/how-do-i-customise-the-appearance-of-links-in-qlabels-using-style-sheets

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

--- Comment #2 from Nate Graham  ---
Created attachment 108524
  --> https://bugs.kde.org/attachment.cgi?id=108524=edit
Blue link is hard to see against a green background

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 381255] KMessageWidget::Positive's green background makes links difficult to see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381255

Nate Graham  changed:

   What|Removed |Added

Summary|KMessageWidget::Positive's  |KMessageWidget::Positive's
   |green background makes web  |green background makes
   |links are almost invisible  |links difficult to see

-- 
You are receiving this mail because:
You are watching all bug changes.