[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-09-27 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=396813

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||6year...@gmail.com

--- Comment #13 from Kai Uwe Broulik  ---
*** Bug 399143 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-08-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396813

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.14.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-08-28 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=396813

David Edmundson  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/2faa71a55a750
   ||d54c941aa6dd73ec02cfc9be34b
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from David Edmundson  ---
Git commit 2faa71a55a750d54c941aa6dd73ec02cfc9be34b by David Edmundson.
Committed on 28/08/2018 at 09:26.
Pushed by davidedmundson into branch 'master'.

Workaround bug with native rendering and opacity in TextField text

Summary:
Problem is identified in https://bugreports.qt.io/browse/QTBUG-70138
with a potential patch for upstream.

With native rendering the alpha is pointlessly also set in the
glBlendFunc despite also being used in the uniform of the shader.
Resulting in a visual bug when used on a window with alpha (such as
Dialog)

It sucks, but we were starting to see people work round it by copying
more invasive workarounds everywhere else which I want to avoid.

Test Plan: Looked at a text field

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15021

M  +5-1src/declarativeimports/plasmastyle/TextFieldStyle.qml

https://commits.kde.org/plasma-framework/2faa71a55a750d54c941aa6dd73ec02cfc9be34b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-08-23 Thread Øystein Steffensen-Alværvik
https://bugs.kde.org/show_bug.cgi?id=396813

--- Comment #11 from Øystein Steffensen-Alværvik  ---
Thanks for the hard work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-08-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396813

--- Comment #10 from Nate Graham  ---
Wow, nice sleuthing!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-08-23 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=396813

--- Comment #9 from David Edmundson  ---
https://bugreports.qt.io/browse/QTBUG-70138

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-08-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=396813

--- Comment #8 from David Edmundson  ---
Chased the bug.

After many hours of going completely mad...it's not our code.

It's a bug in QtQuick ... and only when native rendering is being used.
Somehow when opacity is set on the glyph as well as blending the background it
sets the opacity on the final texel, even if there's an opaque item behind it.

PC3 *is* also broken...but detection of which render type to use is also
apparently broken(!) which means it's going into the non-native version for the
label and we don't see it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-07-25 Thread Dr . Chapatin
https://bugs.kde.org/show_bug.cgi?id=396813

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 396813] PlasmaComponents2 text fields have unreadable placeholder text with light themes (affects Kicker, KRunner, Widget Explorer...)

2018-07-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=396813

Nate Graham  changed:

   What|Removed |Added

Version|5.13.3  |5.48.0
  Component|general |components
   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=396828
   Keywords||usability
Product|Breeze  |frameworks-plasma
 Depends on|396828  |
Summary|KRunner's 'Search…' text is |PlasmaComponents2 text
   |barely visible with Breeze  |fields have unreadable
   |white   |placeholder text with light
   ||themes (affects Kicker,
   ||KRunner, Widget
   ||Explorer...)
   Assignee|plasma-b...@kde.org |notm...@gmail.com

--- Comment #7 from Nate Graham  ---
I'm not sure why it works, but yeah, the PC3 version doesn't exhibit the bug
originally described in this ticket. See my latest attachment to this ticket,
and Maybe due to the different theming logic compared to the PC2 version?

So I guess we have a few options here:
1. Find and fix the bug in the PlasmaComponents2 theming logic that causes
placeholder text to have the wrong color with light themes
2. Port missing features to the PlasmaComponents3 text field and move PC2 text
field users to the new-and-improved PC3 version. I submitted a patch for the
first half of this: https://phabricator.kde.org/D14345
3. Create a QQC2-based Kirigami text field that deprecates both of them and has
all of their features, and move PC2 and PC3 text field users to it (I'm willing
to do this if my patch for #2 is rejected)
4. Something else...?


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=396828
[Bug 396828] PlasmaComponents3 text field doesn't have the ability to display a
clear button
-- 
You are receiving this mail because:
You are watching all bug changes.