[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-19 Thread JanKusanagi
https://bugs.kde.org/show_bug.cgi?id=422616

JanKusanagi  changed:

   What|Removed |Added

 CC||jan-b...@gmx.co.uk

--- Comment #9 from JanKusanagi  ---
I also have a bunch of programs (mostly Qt-but-not-KF5-based) which use some
HTML tags in the tooltip and are now horrible to read xD

I say either filter out img="http..." tags, or at least allow the most common
styling ones, like  and  (and , very much needed!).

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-17 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=422616

--- Comment #8 from Konrad Materka  ---
(In reply to David Edmundson from comment #4)
> > "textFormat: Text.AutoText",
> 
> has been repeatedly problematic with regards to security. 
> 
> It'll process http://...;   and for us loading any network request
> without user expectation is frowned upon.
Hmm, I don't think it is such a big problem. App can send unexpected network
requests anyway, one more in tooltip should not make a difference. From the
other side loading anything from the Internet can be risky, both for security
and privacy reasons.

I wouldn't worry about performance, even if Text.AutoText is slow the impact is
low. Having Text.StyledText explicitly is probably the best option. The best
would be to have something like Text.RestrictedStyledText which would not allow
external resources, but there is nothing like that :)

We need to allow HTML in tooltip anyway - it is already used by several apps. I
assume it is also supported by other DMs (is it? Gnome?).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-17 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=422616

--- Comment #7 from Konrad Materka  ---
*** Bug 423125 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-17 Thread Piotr Mierzwinski
https://bugs.kde.org/show_bug.cgi?id=422616

Piotr Mierzwinski  changed:

   What|Removed |Added

 CC||piotr.mierzwin...@gmail.com

--- Comment #6 from Piotr Mierzwinski  ---
Just before couple minutes I reported Bug 423125 what happens for Clementine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=422616

--- Comment #5 from Nate Graham  ---
Perhaps we could use Text.StyledText instead? That would allow applets to use
some basic styling without the performance and security issues associated with
Text.AutoText. Or does StyledText still allow external  and  HTML, or
just for local resources? The documentation isn't totally clear on the matter.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-16 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=422616

--- Comment #4 from David Edmundson  ---
> "textFormat: Text.AutoText",

has been repeatedly problematic with regards to security. 

It'll process http://...;   and for us loading any network request
without user expectation is frowned upon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-16 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=422616

--- Comment #3 from Konrad Materka  ---
Both affected apps are 3rd-party, using SNI (not an applet/plasmoid). Several
apps are using HTML in tooltips.

System tray uses PlasmaCore.ToolTipArea and relays on "textFormat:
Text.AutoText", for SNI icons - Text.PlainText is not enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 422616] Garbled HTML information in system tray icon tooltip for firewall applet

2020-06-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=422616

Nate Graham  changed:

   What|Removed |Added

Version|master  |5.71.0
   Target Milestone|1.0 |---
 CC||k...@davidedmundson.co.uk,
   ||k...@privat.broulik.de,
   ||n...@kde.org,
   ||plasma-b...@kde.org
Summary|System tray icon garbled|Garbled HTML information in
   |information.|system tray icon tooltip
   ||for firewall applet
Product|plasmashell |frameworks-plasma
   Assignee|plasma-b...@kde.org |notm...@gmail.com
  Component|System Tray |tooltips

--- Comment #2 from Nate Graham  ---
So we have a few options here:
- Revert https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/6
and allow applets to use HTML
- Adjust the API so that apps can *optionally* use rich text and HTML in the
tooltip, but keep the default as plain text
- Fix the firewall applet to respect the documented behavior and stop using
HTML. Is this a first-party applet, or a 3rd-party one?

There isn't anything for the System Tray to do here; moving accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.