[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=410923 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 Filip Fila changed: What|Removed |Added CC||filipfila@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296
--- Comment #10 from Marco Martin ---
(In reply to Marco Martin from comment #8)
> (In reply to David Edmundson from comment #6)
> > >So the issue here is that the tab QQC2 tab bar should draw a frame (with
> > >internal padding) around its content area,
> >
> > I don't think that's do-able out of the box in the theme.
> > (QQC2's component is more like QTabBar than QTabWidget in QWidget terms)
> >
> > However, it's still do-able on the client side. I've just pushed a
> > tabbar.qml in the tests folder of QQC2.
> > I think it's spot-on. Let me know if there's any issues.
> >
> > Maybe we could/should wrap it all as one item somewhere, but not here.
>
> we may end up needing a hmm "TabbarView" in Kirigami, ialready tought about
> an api for such a thing in the past, tough never really started it as i am
> still not sure that's something that should be up to us...
> on my side is one of those frustrating things that will probably be done
> upstream in qqc2 a short time after i publish ours :p
on the API:
TabView {
property Item delegate //optional: the TabButton, which can be overridden
if one wants stuff like a close button on a tab, icons and what not
//Items are just declared into it (perhaps could provide also imperative
// functions like append, insertAt, remove)
// items must have a "title" property, at least with the default delegate
(so, recommended being pages, either qqc2 or kirigami pages)
Page {
title: "Tab1"
}
Rectangle {
property string title: "Tab2"
}
Page {
title: "Blue"
}
}
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296
--- Comment #9 from Marco Martin ---
(In reply to Marco Martin from comment #8)
> (In reply to David Edmundson from comment #6)
> > >So the issue here is that the tab QQC2 tab bar should draw a frame (with
> > >internal padding) around its content area,
> >
> > I don't think that's do-able out of the box in the theme.
> > (QQC2's component is more like QTabBar than QTabWidget in QWidget terms)
> >
> > However, it's still do-able on the client side. I've just pushed a
> > tabbar.qml in the tests folder of QQC2.
> > I think it's spot-on. Let me know if there's any issues.
> >
> > Maybe we could/should wrap it all as one item somewhere, but not here.
>
> we may end up needing a hmm "TabbarView" in Kirigami, ialready tought about
> an api for such a thing in the past, tough never really started it as i am
> still not sure that's something that should be up to us...
> on my side is one of those frustrating things that will probably be done
> upstream in qqc2 a short time after i publish ours :p
on the API:
TabView {
currentIndex: 0
Rectangle {
color: "Red"
}
Rectangle {
color: "Green"
}
Rectangle {
color: "Blue"
}
}
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 --- Comment #8 from Marco Martin --- (In reply to David Edmundson from comment #6) > >So the issue here is that the tab QQC2 tab bar should draw a frame (with > >internal padding) around its content area, > > I don't think that's do-able out of the box in the theme. > (QQC2's component is more like QTabBar than QTabWidget in QWidget terms) > > However, it's still do-able on the client side. I've just pushed a > tabbar.qml in the tests folder of QQC2. > I think it's spot-on. Let me know if there's any issues. > > Maybe we could/should wrap it all as one item somewhere, but not here. we may end up needing a hmm "TabbarView" in Kirigami, ialready tought about an api for such a thing in the past, tough never really started it as i am still not sure that's something that should be up to us... on my side is one of those frustrating things that will probably be done upstream in qqc2 a short time after i publish ours :p -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 --- Comment #7 from Nate Graham --- Thanks David, that's just about perfect. Only two minor visual issues: - With this, the one-pixel line below the tab bar is now unnecessary; the active tab should appear to be a vertical extension of the view below it, just like a QWidgets tab - The frame doesn't have rounded corners like the QWidgets one -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 --- Comment #6 from David Edmundson --- >So the issue here is that the tab QQC2 tab bar should draw a frame (with >internal padding) around its content area, I don't think that's do-able out of the box in the theme. (QQC2's component is more like QTabBar than QTabWidget in QWidget terms) However, it's still do-able on the client side. I've just pushed a tabbar.qml in the tests folder of QQC2. I think it's spot-on. Let me know if there's any issues. Maybe we could/should wrap it all as one item somewhere, but not here. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 --- Comment #5 from Nate Graham --- ...Which is now fixed. So the issue here is that the tab QQC2 tab bar should draw a frame (with internal padding) around its content area, just like the QQC1 and QWidgets versions do/did. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 --- Comment #4 from Nate Graham --- BTW the "tabs don't touch the line below them" issue is Bug 394295. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 matheus4...@hotmail.com changed: What|Removed |Added CC||matheus4...@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296
--- Comment #3 from Nate Graham ---
Created attachment 117553
--> https://bugs.kde.org/attachment.cgi?id=117553=edit
No frame and not touching
Consider the following code:
ColumnLayout {
anchors.fill: parent
TabBar {
id: tabView
TabButton {
text: "Red"
}
TabButton {
text: "Green"
}
TabButton {
text: "Blue"
}
}
SwipeView {
Layout.fillWidth: true
Layout.fillHeight: true
clip: true
currentIndex: tabView.currentIndex
Rectangle {
color: "Red"
}
Rectangle {
color: "Green"
}
Rectangle {
color: "Blue"
}
}
}
See the attachment for the visual result. The tab bar doesn't draw a frame like
QWidgets, but it doesn't touch the content area beneath it either. The result
is awkward and weird.
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-qqc2-desktop-style] [Bug 394296] TabBar styling does not either draw a frame around the content area or touch the content area beneath it, which looks bad
https://bugs.kde.org/show_bug.cgi?id=394296 Nate Graham changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 Severity|wishlist|normal Summary|Tab widget should decide|TabBar styling does not |whether it wants to look|either draw a frame around |like a conventional Tab |the content area or touch |View or a Segmented Control |the content area beneath ||it, which looks bad -- You are receiving this mail because: You are watching all bug changes.
