[frameworks-qqc2-desktop-style] [Bug 433433] Components that use StylePrivate.StyleItem to render content can't handle icon.source

2021-04-23 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433433

--- Comment #3 from Nate Graham  ---
Git commit 35e6076565d565922939eeca11e93abe67f7b664 by Nate Graham.
Committed on 19/04/2021 at 21:11.
Pushed by ngraham into branch 'master'.

Draw icon in QQStyleItem

Checkbox already knew how to do this, but it was doing so internally to
itself. Let's move that logic to CheckDelegate.qml so that everything
that uses it gains the same feature. This functionality can be optionally
disabled in case a control using it already handles icon-drawing by itself.

M  +4-4org.kde.desktop/CheckBox.qml
M  +5-2org.kde.desktop/CheckDelegate.qml
M  +12   -1org.kde.desktop/CheckIndicator.qml
M  +2-0org.kde.desktop/MenuItem.qml
M  +4-4org.kde.desktop/RadioButton.qml
M  +5-2org.kde.desktop/RadioDelegate.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/35e6076565d565922939eeca11e93abe67f7b664

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 433433] Components that use StylePrivate.StyleItem to render content can't handle icon.source

2021-04-19 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=433433

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/67

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 433433] Components that use StylePrivate.StyleItem to render content can't handle icon.source

2021-03-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433433

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 433433] Components that use StylePrivate.StyleItem to render content can't handle icon.source

2021-02-23 Thread David Redondo
https://bugs.kde.org/show_bug.cgi?id=433433

David Redondo  changed:

   What|Removed |Added

 CC||k...@david-redondo.de

--- Comment #1 from David Redondo  ---
Probably  need to do it like Kirigami
https://invent.kde.org/frameworks/kirigami/-/blob/master/src/icon.cpp#L402

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 433433] Components that use StylePrivate.StyleItem to render content can't handle icon.source

2021-02-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=433433

Nate Graham  changed:

   What|Removed |Added

 CC||noaha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.