[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-07-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.95|5.97

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-07-14 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=448784

Marco Martin  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
   |eworks/kirigami/commit/d03c |eworks/kirigami/commit/c28d
   |06bf7e047a822db66e8227a9a6b |ff79721d3805edcd413ef233216
   |c060b2c67   |b3b3b0104

--- Comment #22 from Marco Martin  ---
Git commit c28dff79721d3805edcd413ef233216b3b3b0104 by Marco Martin.
Committed on 14/07/2022 at 12:11.
Pushed by mart into branch 'master'.

second attempt of Delete and port away from internal ScrollView

This reintroduces the refactor of ScrollablePage which was reverted due to last
minute regressions.

Refactor ScrollablePage to port it out of our internal implementation of
ScrollView to upstream QQC2.ScrollView

port the other users as well, most notably OverlaySheet and Dialog.

Testing on various applications don't seem to produce any noticeable
differences

M  +0-2src/CMakeLists.txt
M  +2-1src/controls/ContextDrawer.qml
M  +26   -28   src/controls/Dialog.qml
M  +207  -47   src/controls/ScrollablePage.qml
D  +0-207  src/controls/private/RefreshableScrollView.qml
M  +0-17   src/controls/templates/OverlayDrawer.qml
M  +26   -14   src/controls/templates/OverlaySheet.qml
D  +0-161  src/controls/templates/private/ScrollView.qml

https://invent.kde.org/frameworks/kirigami/commit/c28dff79721d3805edcd413ef233216b3b3b0104

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-06-03 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.95

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-06-03 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=448784

Marco Martin  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kirigami/commit/d03c
   ||06bf7e047a822db66e8227a9a6b
   ||c060b2c67
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #21 from Marco Martin  ---
Git commit d03c06bf7e047a822db66e8227a9a6bc060b2c67 by Marco Martin.
Committed on 03/06/2022 at 08:52.
Pushed by mart into branch 'master'.

Delete and port away from internal ScrollView

Refactor ScrollablePage to port it out of our internal implementation of
ScrollView to upstream QQC2.ScrollView

port the other users as well, most notably OverlaySheet and Dialog.

Testing on various applications don't seem to produce any noticeable
differences

M  +0-2src/CMakeLists.txt
M  +2-1src/controls/ContextDrawer.qml
M  +26   -28   src/controls/Dialog.qml
M  +161  -48   src/controls/ScrollablePage.qml
D  +0-207  src/controls/private/RefreshableScrollView.qml
M  +0-17   src/controls/templates/OverlayDrawer.qml
M  +17   -13   src/controls/templates/OverlaySheet.qml
D  +0-161  src/controls/templates/private/ScrollView.qml

https://invent.kde.org/frameworks/kirigami/commit/d03c06bf7e047a822db66e8227a9a6bc060b2c67

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-20 Thread Matej Starc
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #20 from Matej Starc  ---
(In reply to Bug Janitor Service from comment #18)
> A possibly relevant merge request was started @
> https://invent.kde.org/frameworks/kirigami/-/merge_requests/548

For some reason, I can't activate the binding loop anymore when using current
arch stable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-20 Thread Matej Starc
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #19 from Matej Starc  ---
(In reply to Bug Janitor Service from comment #18)
> A possibly relevant merge request was started @
> https://invent.kde.org/frameworks/kirigami/-/merge_requests/548

Thanks, I will check it out.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-20 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=448784

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #18 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kirigami/-/merge_requests/548

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-16 Thread Matej Starc
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #17 from Matej Starc  ---
(In reply to Matej Starc from comment #16)
> (In reply to Aleix Pol from comment #15)
> > This page is no longer available. It has either expired, been removed by its
> > creator, or removed by one of the Pastebin staff.
> > 
> > :(
> This shouldn't expire or be removed until I delete it.
> https://cloud.aljaxus.eu/index.php/s/aD7scnSQ58HcTNs

This video makes the current cardsGridView even more concerning.

>From what i've noticed ScrollBar doesn't disappear (around 25 sec), most of the
app or whole goes black (around 43 sec and 48 sec) and finally activates the
binding loop at 54 seconds.

https://cloud.aljaxus.eu/index.php/s/tP9rYwXXitzazNY

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-16 Thread Matej Starc
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #16 from Matej Starc  ---
(In reply to Aleix Pol from comment #15)
> This page is no longer available. It has either expired, been removed by its
> creator, or removed by one of the Pastebin staff.
> 
> :(
This shouldn't expire or be removed until I delete it.
https://cloud.aljaxus.eu/index.php/s/aD7scnSQ58HcTNs

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-16 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #15 from Aleix Pol  ---
This page is no longer available. It has either expired, been removed by its
creator, or removed by one of the Pastebin staff.

:(

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-14 Thread Matej Starc
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #14 from Matej Starc  ---
(In reply to Aleix Pol from comment #13)
> I've been looking into this issue and I was unable to reproduce it with the
> test case you suggested. Can you please confirm that it's still present?
The fastest way I did it was to have 3 cards in a single row and the resize the
window by moving the top up and down slowly scrollbar has to change visibility.

https://pastebin.com/pjU3KuYz

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-05-13 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #13 from Aleix Pol  ---
I've been looking into this issue and I was unable to reproduce it with the
test case you suggested. Can you please confirm that it's still present?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-04-06 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=448784

Nicolas Fella  changed:

   What|Removed |Added

 CC||ettore.spong...@gmail.com

--- Comment #12 from Nicolas Fella  ---
*** Bug 452326 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-03-31 Thread Rajeesh K V
https://bugs.kde.org/show_bug.cgi?id=448784

Rajeesh K V  changed:

   What|Removed |Added

 CC||rajeeshknamb...@gmail.com

--- Comment #11 from Rajeesh K V  ---
A little bump here; to inform that this is currently (only) release blocker bug
for Fedora 36. See https://bugzilla.redhat.com/show_bug.cgi?id=2057563

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-03-31 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=448784

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-03-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

 CC||ggrab...@gmail.com

--- Comment #10 from Nate Graham  ---
*** Bug 447958 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-03-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #9 from Nate Graham  ---
*** Bug 446934 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-03-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

 CC||nik.kaise...@googlemail.com

--- Comment #8 from Nate Graham  ---
*** Bug 447080 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-03-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #7 from Nate Graham  ---
*** Bug 451007 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-27 Thread postix
https://bugs.kde.org/show_bug.cgi?id=448784

postix  changed:

   What|Removed |Added

 CC||pos...@posteo.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-15 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=448784

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #6 from Nate Graham  ---
*** Bug 401533 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-14 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #5 from Aleix Pol  ---
Yes, that's my understanding of the problem, at least.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-07 Thread Matej Starc
https://bugs.kde.org/show_bug.cgi?id=448784

--- Comment #4 from Matej Starc  ---
(In reply to Aleix Pol from comment #3)
> As observed by the reported, this is related to the resizing triggered by
> adding the scrollbar.
> 
> It happens where we put the window in that size that with the scrollbar
> there's  N columns and without N-1 or so it's seemed to me debugging 449583.
> 
> A solution would be to never take width to calculate columns when it can
> affect the resulting width (and same goes with height and rows).

So it resizes infinitely(In reply to Aleix Pol from comment #3)
> As observed by the reported, this is related to the resizing triggered by
> adding the scrollbar.
> 
> It happens where we put the window in that size that with the scrollbar
> there's  N columns and without N-1 or so it's seemed to me debugging 449583.
> 
> A solution would be to never take width to calculate columns when it can
> affect the resulting width (and same goes with height and rows).

Sorry I had a hard time understanding the issue here..
So it tries to add a scrollbar (changes width and calculates how many rows it
needs), but after that the scrollbar is not needed anymore, removes it
(calculates how many rows it needs) and goes back to the first step ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-04 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=448784

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #3 from Aleix Pol  ---
As observed by the reported, this is related to the resizing triggered by
adding the scrollbar.

It happens where we put the window in that size that with the scrollbar there's
 N columns and without N-1 or so it's seemed to me debugging 449583.

A solution would be to never take width to calculate columns when it can affect
the resulting width (and same goes with height and rows).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

 CC||c...@rollins.edu

--- Comment #2 from Nate Graham  ---
*** Bug 449581 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

 CC||m...@ratijas.tk
   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

Summary|ScrollBar binding loop when |ScrollBar binding loop can
   |resizing window |cause apps to freeze

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 448784] ScrollBar binding loop can cause apps to freeze

2022-02-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=448784

Nate Graham  changed:

   What|Removed |Added

 CC||guimarcalsi...@gmail.com

--- Comment #1 from Nate Graham  ---
*** Bug 449583 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.