[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-12 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459004

ratijas  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
   |eworks/qqc2-desktop-style/c |eworks/qqc2-desktop-style/c
   |ommit/fdd5457cd4474b51ea6aa |ommit/7d94e6cb59808a85b12b7
   |d45a10081530b2750f5 |13c41a3015f9a6cf0a0

--- Comment #7 from ratijas  ---
Git commit 7d94e6cb59808a85b12b713c41a3015f9a6cf0a0 by ivan tkachenko.
Committed on 12/09/2022 at 00:03.
Pushed by ratijas into branch 'master'.

SpinBox: Let hover events propagate through TextField to the control

Otherwise, up/down indicators won't update their hovered states, and
will be displayed incorrectly.

M  +1-0org.kde.desktop/SpinBox.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/7d94e6cb59808a85b12b713c41a3015f9a6cf0a0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-12 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459004

ratijas  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/fram
   ||eworks/qqc2-desktop-style/c
   ||ommit/fdd5457cd4474b51ea6aa
   ||d45a10081530b2750f5

--- Comment #6 from ratijas  ---
Git commit fdd5457cd4474b51ea6aad45a10081530b2750f5 by ivan tkachenko.
Committed on 12/09/2022 at 00:08.
Pushed by ratijas into branch 'master'.

SpinBox: Reset activeSubControls when neither of indicators are active

Otherwise, an indicator remains in an active state even after being
released and unhovered.

M  +2-0plugin/kquickstyleitem.cpp

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/fdd5457cd4474b51ea6aad45a10081530b2750f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=459004

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/187

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=459004

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/187

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459004

--- Comment #3 from ratijas  ---
Now, this is something "interesting":

down.onHoveredChanged: print("DOWN H", down.hovered)
down.onPressedChanged: print("DOWN P", down.pressed)
up.onHoveredChanged: print("UP H", up.hovered)
up.onPressedChanged: print("UP P", up.pressed)


> ❯ qml spins.qml
> QQmlApplicationEngine failed to load component
> file:///home/ratijas/tmp/spins.qml:17:9: Type SpinBox unavailable
> file:///usr/local/kde/lib/qml/QtQuick/Controls.2/org.kde.desktop/SpinBox.qml:96:8:
>  ".onHoveredChanged" is not available due to component versioning.
> qml: Did not load any objects, exiting.

Excuse me, wat? Not available due to component versioning? With all latest *.15
imports? Whatever, that still works with two Connections objects.


Back on topic, the second part of the issue seems to be due to the TextField as
a contentItem blocking hover events from propagating up to the SpinBox control
itself. Note that the field itself is padded within this control, so there's a
thin edge that resets the cursor when mouse enters the control, but because
TextField and up/down buttons are immediately adjacent to each other — SpinBox
don't get a chance to test for contains() and reset hovered properties.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459004

ratijas  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from ratijas  ---
Those are actually two different bugs. I managed to fix the one that's in out
implementation of QStyle bridge, namely in KQuickStyleItem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459004

ratijas  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|kdelibs-b...@kde.org|m...@ratijas.tk
 Status|REPORTED|CONFIRMED

--- Comment #1 from ratijas  ---
Created attachment 151993
  --> https://bugs.kde.org/attachment.cgi?id=151993&action=edit
QQC2 kde desktop style SpinBox hover glitch

Can confirm. Moreover, this looks like an upstream bug in QQC2. Attaching a
video showing the problem. Hover flag does not reset as soon as mouse leaves
the up/down.indicator's bounding box, and somehow they assume the hovered state
when mouse re-enters their SpinBox even though up/down.hovered is off.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=459004

ratijas  changed:

   What|Removed |Added

 CC||m...@ratijas.tk

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 459004] QQC2 spinbox buttons show as hovered when spinbox is hovered

2022-09-11 Thread Oliver Beard
https://bugs.kde.org/show_bug.cgi?id=459004

Oliver Beard  changed:

   What|Removed |Added

   Assignee|plasma-b...@kde.org |kdelibs-b...@kde.org
Product|Breeze  |frameworks-qqc2-desktop-sty
   ||le
  Component|general |general
 CC||ahiems...@heimr.nl,
   ||k...@davidedmundson.co.uk,
   ||noaha...@gmail.com,
   ||notm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.