[frameworks-syntax-highlighting] [Bug 383390] Please move TextBlockUserData from syntaxhighlighter.cpp to the syntaxhighlighter.h

2017-09-04 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=383390

--- Comment #4 from Dominik Haumann  ---
See also detailed documentation here:
https://api.kde.org/frameworks/syntax-highlighting/html/classKSyntaxHighlighting_1_1AbstractHighlighter.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 383390] Please move TextBlockUserData from syntaxhighlighter.cpp to the syntaxhighlighter.h

2017-09-04 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=383390

Dominik Haumann  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Dominik Haumann  ---
Again, looking at how this can be solved (see proposed solution in
https://bugs.kde.org/show_bug.cgi?id=383350), this is a wont-fix, since this is
simply not necessary.

The other solution, i.e. inheriting from AbstractHighlighter, is the way to go.
This way you have 100% flexibility where you store the State variable.

I'll close as wont-fix. If you have further questions, please join the
kwrite-de...@kde.org mailing list and I'm sure we'll fine a solution for you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 383390] Please move TextBlockUserData from syntaxhighlighter.cpp to the syntaxhighlighter.h

2017-08-11 Thread Szyk Cech
https://bugs.kde.org/show_bug.cgi?id=383390

--- Comment #2 from Szyk Cech  ---
Created attachment 107220
  --> https://bugs.kde.org/attachment.cgi?id=107220=edit
Patch moving TextBlockUserData from syntaxhighlighter.cpp to the
syntaxhighlighter.h

Patch moving TextBlockUserData from syntaxhighlighter.cpp to the
syntaxhighlighter.h

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-syntax-highlighting] [Bug 383390] Please move TextBlockUserData from syntaxhighlighter.cpp to the syntaxhighlighter.h

2017-08-11 Thread Dominik Haumann
https://bugs.kde.org/show_bug.cgi?id=383390

--- Comment #1 from Dominik Haumann  ---
Please attach a patch of your changes so that we have a chance to investigate
your solution. Based on this, we may find a good solution that works for
everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.