[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=378584

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #15 from Thomas Mitterfellner  ---
> Your username is mitterfellner with that, you should be able to reset your
> password in https://identity.kde.org/index.php?r=site/passwordReset

Thanks! Never would I have guessed that username (really!). I was now able to
log in to phabricator. Thanks also for pushing the commit to Applications!

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=378584

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit||https://commits.kde.org/gwe
   ||nview/c4a84dad6292b9c7918be
   ||c8d7ed33114d3758730

--- Comment #14 from Albert Astals Cid  ---
Git commit c4a84dad6292b9c7918bec8d7ed33114d3758730 by Albert Astals Cid, on
behalf of Thomas Mitterfellner.
Committed on 09/09/2017 at 09:39.
Pushed by aacid into branch 'Applications/17.08'.

Reduce hyper-sensitive touchpad scroll-zoom speed

Summary:

Reduce hyper-sensitive touchpad scroll-zoom speed in Gwenview

Test Plan: Submitting this on behalf of  Thomas Mitterfellner since he's having
trouble with his Phabricator access. Patch is  modeled after Albert's similar
patch for Okular in
https://cgit.kde.org/okular.git/commit/?id=7a50ce0edfc9be8bd23441e52a4f3a0c60f7e60f.
Thomas has tested locally with a touchpad and scroll wheel, and I have tested
in a KDE Neon VM. Seems to work as expected.

Reviewers: #kde_applications, broulik, aacid

Reviewed By: #kde_applications, aacid

Differential Revision: https://phabricator.kde.org/D7744

M  +7-2lib/documentview/documentview.cpp

https://commits.kde.org/gwenview/c4a84dad6292b9c7918bec8d7ed33114d3758730

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=378584

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #13 from Albert Astals Cid  ---
(In reply to Thomas Mitterfellner from comment #11)
> No chance. I cannot log in to phabricator. Could you (or someone who has
> access) please submit it? (KDE identity doesn't let me in, I cannot register
> as my address is already taken, I cannot reset my password)

Your username is mitterfellner with that, you should be able to reset your
password in https://identity.kde.org/index.php?r=site/passwordReset

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #12 from Nate Graham  ---
Sure, I can do it. Patch URL is https://phabricator.kde.org/D7744

Long-term, it would be a good idea to sort out your Phabricator access, since
this is now the central portal for contributing patches to KDE software.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #11 from Thomas Mitterfellner  ---
No chance. I cannot log in to phabricator. Could you (or someone who has
access) please submit it? (KDE identity doesn't let me in, I cannot register as
my address is already taken, I cannot reset my password)

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #10 from Thomas Mitterfellner  ---
Tested with mouse wheel. Works as expected as far as I can tell. I'll try to
submit it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #9 from Nate Graham  ---
Fantastic!!!

Did you make sure that the patch didn't break scroll wheel behavior? If so, can
you upload the patch to Phabricator (http://phabricator.kde.org/) with the
details of your testing? Use the Gwenview repo and as reviewers, add "KDE
Applications", Albert Astral Cid, Kai Uwe Broulik, and Christoph Feck.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #8 from Thomas Mitterfellner  ---
I've adapted the okular solution and it seems to work as expected. Please
review/test the attached patch. I'd be happy to see the fix in the next
gwenview version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #7 from Thomas Mitterfellner  ---
Created attachment 107764
  --> https://bugs.kde.org/attachment.cgi?id=107764=edit
Patch to fix ctrl-scroll behavior via touchpad

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #6 from Nate Graham  ---
I'm afraid my own C++ skills aren't yet sufficient to adapt either of those
fixes to Gwenview, but maybe in the future... or maybe a charitable soul will
stop by before then and do it first!

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378584

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #5 from Nate Graham  ---
Ooooh lookie at that. Thanks for the additional info, Thomas. Not a duplicate.

Though fixing https://bugs.kde.org/show_bug.cgi?id=307637 will make this a
little better until we can fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #4 from Thomas Mitterfellner  ---
Well, only kind of. Did you have a look at the bug report I linked? The problem
is not really the increment. It is that it is almost impossible to select a
particular increment. Zooming in 100% steps is not optimum, but I'd be ok, if I
could reliably CRTL-Zoom there using the touchpad. That is not possible. The
increment would probably have to be 0.1%-1% to be somewhat usable.

So I beg you: please have a look at the linked okular bug report and check the
solution presented there. Or, alternatively, compare the krita bug report at
https://bugs.kde.org/show_bug.cgi?id=378586 - they also fixed it already.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378584

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Nate Graham  ---
Actually, since the touchpad emulated a scroll wheel, this is a duplicate of
https://bugs.kde.org/show_bug.cgi?id=307637#add_comment

*** This bug has been marked as a duplicate of bug 307637 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378584

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Nate Graham  ---
Confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 378584] Zooming with CTRL+Two-finger-scrolling is too sensitive

[Thomas Mitterfellner]

https://bugs.kde.org/show_bug.cgi?id=378584

--- Comment #1 from Thomas Mitterfellner  ---
I forgot: this is for version 16.08.2, KDE Frameworks 5.32.0, Qt 5.8.0 (built
against 5.8.0), the xcb windowing system

-- 
You are receiving this mail because:
You are watching all bug changes.