[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Nate Graham changed: What|Removed |Added Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #5 from Henrik Fehlauer ---
Git commit f0444f600b973ebb7ad226f2ee7007af184fb7e2 by Henrik Fehlauer.
Committed on 10/12/2017 at 22:03.
Pushed by rkflx into branch 'master'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d777. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9281
M +4-1kstyle/breezestyle.cpp
https://commits.kde.org/breeze/f0444f600b973ebb7ad226f2ee7007af184fb7e2
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #6 from Henrik Fehlauer ---
Git commit f5fd8fa82c6bcaf7066a7031002622458cedd2dd by Henrik Fehlauer.
Committed on 10/12/2017 at 22:04.
Pushed by rkflx into branch 'Plasma/5.11'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d777. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9281
M +4-1kstyle/breezestyle.cpp
https://commits.kde.org/breeze/f5fd8fa82c6bcaf7066a7031002622458cedd2dd
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #7 from Henrik Fehlauer ---
Git commit 2dfb48a5ce161df548f0a674669c4e3f9385fd06 by Henrik Fehlauer.
Committed on 10/12/2017 at 22:07.
Pushed by rkflx into branch 'master'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Oxygen was added with
b33942690c65. However, compared to the KDE4 version there is not enough space
between the left button border and the icon (Screenshots from the
matching Diff for Breeze, see D9281):
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9282
M +4-1kstyle/oxygenstyle.cpp
https://commits.kde.org/oxygen/2dfb48a5ce161df548f0a674669c4e3f9385fd06
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #8 from Henrik Fehlauer ---
Git commit 8e51240839744679939a5390dc280f312b20d340 by Henrik Fehlauer.
Committed on 10/12/2017 at 22:08.
Pushed by rkflx into branch 'Plasma/5.11'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Oxygen was added with
b33942690c65. However, compared to the KDE4 version there is not enough space
between the left button border and the icon (Screenshots from the
matching Diff for Breeze, see D9281):
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9282
M +4-1kstyle/oxygenstyle.cpp
https://commits.kde.org/oxygen/8e51240839744679939a5390dc280f312b20d340
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
Henrik Fehlauer changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/92e63330ecdcb15691000
||36a9a7f5245522fe720
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #9 from Henrik Fehlauer ---
Git commit 92e63330ecdcb1569100036a9a7f5245522fe720 by Henrik Fehlauer, on
behalf of Kapil Lamba.
Committed on 16/12/2017 at 07:15.
Pushed by rkflx into branch 'Applications/17.12'.
Correct margin for left sidebar
Summary:
Sidebar content too close to the left boundary of the window.
This patch adds left margin to some of the sidebar contents.
Test Plan:
Before:
{F5524922}
After:
{F5524923}
Reviewers: #kde_applications, ngraham, rkflx
Reviewed By: ngraham, rkflx
Subscribers: #kde_applications
Tags: #kde_applications
Differential Revision: https://phabricator.kde.org/D9145
M +3-1app/semanticinfocontextmanageritem.cpp
M +7-1app/sidebar.cpp
M +3-1app/sidebar.h
https://commits.kde.org/gwenview/92e63330ecdcb1569100036a9a7f5245522fe720
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Christoph Feck changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 --- Comment #2 from Christoph Feck --- Nate, there is no margin. What you might see is the window border? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED --- Comment #3 from Nate Graham --- Oh, you're right. I was comparing two different systems, one with borders and one without. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 --- Comment #4 from Nate Graham --- Looking into writing a patch for this. The big problem seems to be that the everything inside these widgets has zero left padding, which is clearly wrong. We'll want to add some, except for the buttons, where we additionally want to add some left padding to the icon placement, since the icons are right now right up against the button edge, which again is just wrong. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC||pointedst...@zoho.com --- Comment #1 from Nate Graham --- Thanks for the bug report! This is fixed in GwenView 17.11.70. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Nate Graham changed: What|Removed |Added Keywords||usability -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #5 from Henrik Fehlauer ---
Git commit f0444f600b973ebb7ad226f2ee7007af184fb7e2 by Henrik Fehlauer.
Committed on 10/12/2017 at 22:03.
Pushed by rkflx into branch 'master'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d777. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9281
M +4-1kstyle/breezestyle.cpp
https://commits.kde.org/breeze/f0444f600b973ebb7ad226f2ee7007af184fb7e2
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #6 from Henrik Fehlauer ---
Git commit f5fd8fa82c6bcaf7066a7031002622458cedd2dd by Henrik Fehlauer.
Committed on 10/12/2017 at 22:04.
Pushed by rkflx into branch 'Plasma/5.11'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Breeze was added with
2fb62271d777. However, compared to the KDE4 version there is not enough space
between the left button border and the icon:
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9281
M +4-1kstyle/breezestyle.cpp
https://commits.kde.org/breeze/f5fd8fa82c6bcaf7066a7031002622458cedd2dd
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #7 from Henrik Fehlauer ---
Git commit 2dfb48a5ce161df548f0a674669c4e3f9385fd06 by Henrik Fehlauer.
Committed on 10/12/2017 at 22:07.
Pushed by rkflx into branch 'master'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Oxygen was added with
b33942690c65. However, compared to the KDE4 version there is not enough space
between the left button border and the icon (Screenshots from the
matching Diff for Breeze, see D9281):
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9282
M +4-1kstyle/oxygenstyle.cpp
https://commits.kde.org/oxygen/2dfb48a5ce161df548f0a674669c4e3f9385fd06
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
--- Comment #8 from Henrik Fehlauer ---
Git commit 8e51240839744679939a5390dc280f312b20d340 by Henrik Fehlauer.
Committed on 10/12/2017 at 22:08.
Pushed by rkflx into branch 'Plasma/5.11'.
Fix indentation of icon for left aligned toolbuttons
Summary:
Gwenview's {nav Operations} sidebar uses custom `QToolButtons` which are
wide and left aligned. Special support for this in Oxygen was added with
b33942690c65. However, compared to the KDE4 version there is not enough space
between the left button border and the icon (Screenshots from the
matching Diff for Breeze, see D9281):
{F5539728}
This is fixed by adding the appropriate margin:
{F5539730}
Note how this replicates exactly the spacing of the toolbuttons in the
regular toolbar on the top (which had its icon size set to "small" in
this screenshot).
Test Plan:
Icons on toolbuttons in Gwenview's {nav Operations} sidebar no longer
squished all the way to the left, text spacing still looking good.
Reviewers: hpereiradacosta
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9282
M +4-1kstyle/oxygenstyle.cpp
https://commits.kde.org/oxygen/8e51240839744679939a5390dc280f312b20d340
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535
Henrik Fehlauer changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/gwe
||nview/92e63330ecdcb15691000
||36a9a7f5245522fe720
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #9 from Henrik Fehlauer ---
Git commit 92e63330ecdcb1569100036a9a7f5245522fe720 by Henrik Fehlauer, on
behalf of Kapil Lamba.
Committed on 16/12/2017 at 07:15.
Pushed by rkflx into branch 'Applications/17.12'.
Correct margin for left sidebar
Summary:
Sidebar content too close to the left boundary of the window.
This patch adds left margin to some of the sidebar contents.
Test Plan:
Before:
{F5524922}
After:
{F5524923}
Reviewers: #kde_applications, ngraham, rkflx
Reviewed By: ngraham, rkflx
Subscribers: #kde_applications
Tags: #kde_applications
Differential Revision: https://phabricator.kde.org/D9145
M +3-1app/semanticinfocontextmanageritem.cpp
M +7-1app/sidebar.cpp
M +3-1app/sidebar.h
https://commits.kde.org/gwenview/92e63330ecdcb1569100036a9a7f5245522fe720
--
You are receiving this mail because:
You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Christoph Feck changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 --- Comment #2 from Christoph Feck --- Nate, there is no margin. What you might see is the window border? -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED --- Comment #3 from Nate Graham --- Oh, you're right. I was comparing two different systems, one with borders and one without. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 --- Comment #4 from Nate Graham --- Looking into writing a patch for this. The big problem seems to be that the everything inside these widgets has zero left padding, which is clearly wrong. We'll want to add some, except for the buttons, where we additionally want to add some left padding to the icon placement, since the icons are right now right up against the button edge, which again is just wrong. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC||pointedst...@zoho.com --- Comment #1 from Nate Graham --- Thanks for the bug report! This is fixed in GwenView 17.11.70. -- You are receiving this mail because: You are watching all bug changes.
[gwenview] [Bug 381535] Left panel is not indented properly
https://bugs.kde.org/show_bug.cgi?id=381535 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
