[k3b] [Bug 399753] k3b-18.08.2 assertion on startup: "first <= rowCount(parent)" in file itemmodels/qabstractitemmodel.cpp, line 2712

2018-10-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=399753

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/k3b
   ||/8709a3dcaef941db7467a94cfc
   ||77ca68542e2c45
 Resolution|--- |FIXED

--- Comment #4 from Albert Astals Cid  ---
Git commit 8709a3dcaef941db7467a94cfc77ca68542e2c45 by Albert Astals Cid.
Committed on 14/10/2018 at 22:37.
Pushed by aacid into branch 'Applications/18.08'.

MetaItemModel: Fix Qt assertion in adding rows

Summary:
We need the row count to be correct, and since flat models sometimes have no
rows, places.count is not a valid row

Differential Revision: https://phabricator.kde.org/D16213

M  +2-5src/k3bmetaitemmodel.cpp

https://commits.kde.org/k3b/8709a3dcaef941db7467a94cfc77ca68542e2c45

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 399753] k3b-18.08.2 assertion on startup: "first <= rowCount(parent)" in file itemmodels/qabstractitemmodel.cpp, line 2712

2018-10-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=399753

--- Comment #3 from Albert Astals Cid  ---
https://phabricator.kde.org/D16213

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 399753] k3b-18.08.2 assertion on startup: "first <= rowCount(parent)" in file itemmodels/qabstractitemmodel.cpp, line 2712

2018-10-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=399753

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #2 from Albert Astals Cid  ---
As a side note, unless you're a developer, it's a bad idea to run Qt in debug
mode (like you are) since it means things are going to be slower for no "real
good reason".

But yes that code looks indeed fishy.

-- 
You are receiving this mail because:
You are watching all bug changes.

[k3b] [Bug 399753] k3b-18.08.2 assertion on startup: "first <= rowCount(parent)" in file itemmodels/qabstractitemmodel.cpp, line 2712

2018-10-13 Thread Jaak Ristioja
https://bugs.kde.org/show_bug.cgi?id=399753

--- Comment #1 from Jaak Ristioja  ---
The following Qt commit apparently added this assertion to
QAbstractItemModel::beginInsertRows:

https://code.qt.io/cgit/qt/qtbase.git/commit/src/corelib/itemmodels/qabstractitemmodel.cpp?id=00c09e752ff7e482e1308e0e34721dc979204595

-- 
You are receiving this mail because:
You are watching all bug changes.