[kaffeine] [Bug 378078] Shortcuts don't work (as in space to play at least)

[Mauro Carvalho Chehab]

https://bugs.kde.org/show_bug.cgi?id=378078

--- Comment #3 from Mauro Carvalho Chehab  ---
There is indeed a problem with shortcuts: you can always reassign the keys by
setting the shortcuts.

However, the defaults aren't OK: right now, it would be expecting a sequence of
keys, where the second key would be a media key. That will never work.

Just fixed it at -git.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 378078] Shortcuts don't work (as in space to play at least)

[Mauro Carvalho Chehab]

https://bugs.kde.org/show_bug.cgi?id=378078

Mauro Carvalho Chehab  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Mauro Carvalho Chehab  ---
Git commit 4f7ec78d2f68078702903e50fd505a76dd62e4a3 by Mauro Carvalho Chehab.
Committed on 10/08/2017 at 11:15.
Pushed by mauroc into branch 'master'.

mediawidget: don't use key sequences as shortcut

QKeySequence is used to define a sequence of keys that should
be pressed in order for an action to occur, and not to set
alternate keys for an action.

Due to that, the default key maps for several actions don't
work.

Also, on modern desktops, the Keyboard's media keys are already
mapped by the window manager, with may prevent Qt to use them.

So, instead, just use keystrokes that exist on all keyboards,
as, if someone wants something different, it can change the
shortcuts via Kaffeine's menu.

Signed-off-by: Mauro Carvalho Chehab 

M  +7-7src/mediawidget.cpp

https://commits.kde.org/kaffeine/4f7ec78d2f68078702903e50fd505a76dd62e4a3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 378078] Shortcuts don't work (as in space to play at least)

[Mauro Carvalho Chehab]

https://bugs.kde.org/show_bug.cgi?id=378078

--- Comment #1 from Mauro Carvalho Chehab  ---
(In reply to jey.and.key from comment #0)
> on version 2.0.8 on opensuse I dont think shortcuts work at all.

I did some tests here on Fedora 25, with git version, running on Mate. I was
unable to reproduce this issue. I even changed some shortcuts at Settings ->
Configure Settings, and everything worked fine.

-- 
You are receiving this mail because:
You are watching all bug changes.