[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-08 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #9 from Patrick Silva  ---
Created attachment 118657
  --> https://bugs.kde.org/attachment.cgi?id=118657=edit
apparently the dropdown is empty

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-08 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #8 from Patrick Silva  ---
Created attachment 118656
  --> https://bugs.kde.org/attachment.cgi?id=118656=edit
tracks names are not entirely readable

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-08 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #7 from Patrick Silva  ---
I have just installed kaffeine-git on Arch Linux.
Now i can select the audio track \o/

I noticed two issues:
  sometimes the tracks names are not entirely readable even when the dropdown
is open;
  sometimes the dropdown seems empty when I open a file, despite the tracks are
listed when I 
  open the dropdwn and kaffeine plays the first track correctly

I will post screenshots.
Thanks Mauro.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-08 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #6 from Mauro Carvalho Chehab  ---
(In reply to Patrick Silva from comment #4)
> Weird. The box painted in green is greyed out here on Arch Linux.
> Tested avi, mp4 and mkv multi-audio videos.

While addressing another bug, I found one issue at the logic that updates the
metadata. Basically, up to 2.0.16, the audio channels are updated only for the
first video.

There are still some small things to work with, but I pushed some patches that
should fix the issue. Please test.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-06 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #5 from Mauro Carvalho Chehab  ---
(In reply to Patrick Silva from comment #4)
> Weird. The box painted in green is greyed out here on Arch Linux.
> Tested avi, mp4 and mkv multi-audio videos.

Kaffeine strongly relies on libVlc to be able to detect multi-track videos. It
could be due to some differences between the version you're using for vlc or
because the track encoding is using something that libvlc won't properly
detect.

In my case, I'm using the open source Elefants Dream video from:

   https://www.youtube.com/watch?v=TLkA0RELQ1g

As this video has only English, I downloaded also the Spanish version from:

   https://www.youtube.com/watch?v=B1L20Svw6sQ

Extracted its audio channel and merged it to the main video with:

   $ ffmpeg -i Elephants_Dream_\(2006\).webm -i spanish.mp3 -map 0 -map 1
-metadata:s:a:1 language=spa elephants_dream.mp4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-06 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #4 from Patrick Silva  ---
Weird. The box painted in green is greyed out here on Arch Linux.
Tested avi, mp4 and mkv multi-audio videos.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-06 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=382546

Mauro Carvalho Chehab  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kaf
   ||feine/9c3746e69ede5579ffd11
   ||3ce80df14361ee26a73
 Status|REPORTED|RESOLVED

--- Comment #3 from Mauro Carvalho Chehab  ---
Git commit 9c3746e69ede5579ffd113ce80df14361ee26a73 by Mauro Carvalho Chehab.
Committed on 07/03/2019 at 00:34.
Pushed by mauroc into branch 'master'.

backend-vlc: store current audio stream

Store the new current audio stream after a change. Without
that, it is not possible to change back to the first audio
channel.

Signed-off-by: Mauro Carvalho Chehab 

M  +4-2src/backend-vlc/vlcmediawidget.cpp

https://commits.kde.org/kaffeine/9c3746e69ede5579ffd113ce80df14361ee26a73

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-06 Thread Mauro Carvalho Chehab
https://bugs.kde.org/show_bug.cgi?id=382546

--- Comment #2 from Mauro Carvalho Chehab  ---
Created attachment 118611
  --> https://bugs.kde.org/attachment.cgi?id=118611=edit
Kaffeine with the language selection for a multi-track mp4

Kaffeine does support multi-audio track mp4.

You should notice that language selection for multi-audio videos is at the
bottom of the window. See the image. It is the box I painted with green.

There was however a bug with Vlc (maybe due to some changes at the library?):
it was not allowing to change the language back. I'm pushing a fixup.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kaffeine] [Bug 382546] Support multi-audio videos

2019-03-02 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=382546

Patrick Silva  changed:

   What|Removed |Added

Summary|multi-audio videos support  |Support multi-audio videos
Version|2.0.13  |2.0.16-2

--- Comment #1 from Patrick Silva  ---
It's still impossible to change the audio track of multi-audio videos. :(

-- 
You are receiving this mail because:
You are watching all bug changes.