[kajongg] [Bug 486171] Doesn't actually work with Qt 6

2024-04-30 Thread Wolfgang Rohdewald
https://bugs.kde.org/show_bug.cgi?id=486171

Wolfgang Rohdewald  changed:

   What|Removed |Added

   Version Fixed In|24.02.3 |24.05

--- Comment #5 from Wolfgang Rohdewald  ---
(In reply to Albert Astals Cid from comment #4)
> (subscribe to kde-devel mailing list if you aren't to get emails about when 
> the branches are created)

Done, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kajongg] [Bug 486171] Doesn't actually work with Qt 6

2024-04-30 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=486171

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid  ---
Wolfgang we won't be having a 24.02.3 release, please make sure these commits
are in master and release/24.05 (subscribe to kde-devel mailing list if you
aren't to get emails about when the branches are created)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kajongg] [Bug 486171] Doesn't actually work with Qt 6

2024-04-30 Thread Wolfgang Rohdewald
https://bugs.kde.org/show_bug.cgi?id=486171

Wolfgang Rohdewald  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||24.02.3
  Latest Commit||https://invent.kde.org/game
   ||s/kajongg/-/commit/077da955
   ||47d4af35bc4fa6737654d15442c
   ||2768f
 Status|REOPENED|RESOLVED

--- Comment #3 from Wolfgang Rohdewald  ---
Git commit 077da95547d4af35bc4fa6737654d15442c2768f by Wolfgang Rohdewald.
Committed on 30/04/2024 at 07:59.
Pushed by wrohdewald into branch 'release/24.02'.

Qt6 only worked when Qt5 was installed too
FIXED-IN: 24.02.3

M  +2-15   src/common.py
M  +0-1src/kdestub.py
M  +2-6src/modeltest.py
M  +31   -1src/qt.py

https://invent.kde.org/games/kajongg/-/commit/077da95547d4af35bc4fa6737654d15442c2768f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kajongg] [Bug 486171] Doesn't actually work with Qt 6

2024-04-27 Thread Antonio Rojas
https://bugs.kde.org/show_bug.cgi?id=486171

Antonio Rojas  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REOPENED
 Ever confirmed|0   |1
 Resolution|WORKSFORME  |---

--- Comment #2 from Antonio Rojas  ---
Yes, I was using unmodified 24.02.2. Which like line of the backtrace doesn't
match according to you?

Anyway, I just upgraded to 24.04.80 and there's a new error

Traceback (most recent call last):
  File "/usr/bin/kajongg", line 20, in 
from kde import KApplication
  File "/usr/share/kajongg/kde.py", line 12, in 
from kdestub import *  # pylint:
disable=wildcard-import,unused-wildcard-import
^
  File "/usr/share/kajongg/kdestub.py", line 241, in 
class KDialog(CaptionMixin, QDialog):
  File "/usr/share/kajongg/kdestub.py", line 262, in KDialog
def setButtons(self, buttonMask:QDialogButtonBox.StandardButtons) ->None:

AttributeError: type object 'QDialogButtonBox' has no attribute
'StandardButtons'. Did you mean: 'standardButtons'?

After fixing this following the suggestion, I get a slightly different variant
of the previous error

Traceback (most recent call last):
  File "/usr/bin/kajongg", line 189, in 
from mainwindow import MainWindow
  File "/usr/share/kajongg/mainwindow.py", line 88, in 
logError("\n".join(f" * {s}" for s in NOTFOUND), showStack=False)
  File "/usr/share/kajongg/log.py", line 146, in logError
return logMessage(msg, logging.ERROR, True, showStack=showStack,
withGamePrefix=withGamePrefix)
  

  File "/usr/share/kajongg/log.py", line 135, in logMessage
return Information(msg) if prio == logging.INFO else Sorry(msg,
always=True)

^^^
  File "/usr/share/kajongg/dialogs.py", line 199, in __init__
dialog = Prompt(msg, icon=QMessageBox.Information,
 ^
  File "/usr/share/kajongg/dialogs.py", line 81, in __init__
KMessageBox.createKMessageBox(
  File "/usr/share/kajongg/kdestub.py", line 216, in createKMessageBox
desktop = KApplication.desktopSize()
  ^^
  File "/usr/share/kajongg/kdestub.py", line 116, in desktopSize
assert Internal.mainWindow
   ^^^
AssertionError

-- 
You are receiving this mail because:
You are watching all bug changes.

[kajongg] [Bug 486171] Doesn't actually work with Qt 6

2024-04-26 Thread Wolfgang Rohdewald
https://bugs.kde.org/show_bug.cgi?id=486171

Wolfgang Rohdewald  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||wolfg...@rohdewald.de
 Resolution|--- |WORKSFORME

--- Comment #1 from Wolfgang Rohdewald  ---
Others wanting to test this might have to set the shell variable QT_API=pyqt6
before starting  kajongg because PyQt5 will be used if installed, see
https://github.com/spyder-ide/qtpy

Please double check if you are using the unmodified 24.02.2. The line numbers
in the Traceback do not match that version.

One possible problem is the kajonggserver.py process. Even if you finish
kajongg, the server process will wait for some time for new clients before
exiting. So maybe your kajonggserver.py process was not running the version you
thought it does. 

So - please always kill all kajongg processes after changing source code.

One strange thing is that nobody ever reported a bug like 'int' object has no
attribute 'split' in clientVersion.split('.'), this only seems to happen to me.
So I cherrypicked a fix about this from master to 24.02 so I am actually able
to run 24.02.2 - which works fine for me with Qt6.

Your bug should have been fixed with this commit which is part of 24.02.2:

commit 3af0e1c6944695d5bdaf1bd7490cb4ad6ad98665
Author: Wolfgang Rohdewald 
Date:   Sat Sep 16 19:10:26 2023 +0200

Qt6: QApplication.desktop() is deprecated, introduce
KApplication.desktopSize()

-- 
You are receiving this mail because:
You are watching all bug changes.