[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 Christoph Cullmann changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||cullm...@kde.org Resolution|--- |FIXED --- Comment #17 from Christoph Cullmann --- Remove QSaveFile in favor of plain old file saving Summary: Rationale: for many use cases that e.g. have acls, complex other extended attributes, static links e.g. the rename() doesnt do the trick it should other ways would be start to add workarounds to all cases, which is hard, e.g. if that is something shared via SMB... Test Plan: make && make test Reviewers: dhaumann, dfaure Reviewed By: dhaumann, dfaure Subscribers: dfaure, kwrite-devel, kde-frameworks-devel Tags: #kate, #frameworks Differential Revision: https://phabricator.kde.org/D14890 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 Dominik Haumann changed: What|Removed |Added CC||j...@gsmlandia.com --- Comment #16 from Dominik Haumann --- *** Bug 362733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 Dominik Haumann changed: What|Removed |Added CC||ku...@gmx.com --- Comment #15 from Dominik Haumann --- *** Bug 362201 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 Dominik Haumann changed: What|Removed |Added CC||thomas.mesch...@ilr.tu-berl ||in.de --- Comment #14 from Dominik Haumann --- *** Bug 376376 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 --- Comment #13 from Friedrich W. H. Kossebau --- For a start I opened a bug now upstream for QSaveFile: https://bugreports.qt.io/browse/QTBUG-56366, "QSaveFile results in loss of extended file attributes and change of file ownership" For some intermediate work-around in Kate::TextBuffer I still have to learn more about stuff and system APIs that would be used, hope to look into it the next days more. Controlling file ownership though might be a unsolvable one. As there are some users who might value to no lose ownership data or hard links over support for transactional saving, perhaps there could be some flag somewhere in the KTextEditor API which allows to control this and which could also be forwarded into the Kate module config GUI? At least I have never experienced any problems with incomplete writes, but this bug needs me to do lots of fixups whenever I use KWrite, Kate & KDevelop with system settings or in special development setups. So I would instantly toggle such a setting :) -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 --- Comment #12 from Dominik Haumann --- Hi Friedrich, yes, a possible way is to fix it in Kate::TextBuffer. Having talked to dfaure about it, we already came to the conclusion that it should be fixed in Qt: Since QSaveFile already has a function called directWriteFallback(), it is the correct way to extend the checks to fallback t a direct write in case of the mentioned corner cases. While a workaround in Kate::TextBuffer would of course improve the situation, the proper fix is definitely in QSaveFile. See also: - https://bugs.kde.org/show_bug.cgi?id=354405 - https://bugs.kde.org/show_bug.cgi?id=358457 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 Friedrich W. H. Kossebau changed: What|Removed |Added CC||kosse...@kde.org --- Comment #11 from Friedrich W. H. Kossebau --- Still confirmed with KF5 5.26. Not only ownership is reset, but extended attributes are also lost. This behaviour is very annoying in many situations for me, so I am finally ready to try to scratch my itch here. @Dominik: Did I correctly identify the code that needs changing to be Kate::TextBuffer::save() in KTextEditor? IMHO the fix should be in QSaveFile, as writing to a file should not suddenly have a side-effect of changed ownership or other properties, unless requested (modulo modification time of course :) ). But I do not have a Qt development setup and also would like a workaround in KTextEditor until some released version of Qt with the fix has made it to my work machines. Has there been some further discussion on the topic? Any recommendations what I should try to do? I could not find any Qt API to change file properties besides permissions. -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 pk changed: What|Removed |Added CC||k...@lool.fr --- Comment #10 from pk --- I just upgraded from ubuntu 12.04 to 16.04 suid bit of files ( chmod a+sx ) before editing are reset after a write with kwrite... it was ok on previous version... kwrite old (ok) version : kwrite -v > Qt : 4.8.1 Plate-forme de développement de KDE : 4.8.5 (4.8.5) KWrite : 4.8.5 (4.8.5) new version with bug: kwrite -v > kwrite 15.12.3 -- You are receiving this mail because: You are watching all bug changes.
[kate] [Bug 333577] QSaveFile: kate changes file owner
https://bugs.kde.org/show_bug.cgi?id=333577 Dominik Haumann changed: What|Removed |Added Summary|KSaveFile: kate changes |QSaveFile: kate changes |file owner |file owner -- You are receiving this mail because: You are watching all bug changes.
