[kate] [Bug 363482] Toolview vsizing can lead to widget clipping in the Search & Replace view

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363482

--- Comment #6 from RJVB  ---
Created attachment 99165
  --> https://bugs.kde.org/attachment.cgi?id=99165=edit
result of the fix, native Mac theme

No, the fix seems to work as intended. The view isn't too high, at least not
any more so than is usual for the Mac native theme (which wastes a lot of space
IMHO).

The only thing you might consider is a state variable that keeps track of
whether a toolview was shown at its minimal height. That would make it possible
to resize it if ever it becomes too high because the minimal height decreased,
for instance after changing to a more compact theme or after reducing font
sizes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 363482] Toolview vsizing can lead to widget clipping in the Search & Replace view

[Kåre Särs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363482

--- Comment #5 from Kåre Särs  ---
I just set the minimum size of the sizeHint of the widget with advanced open.
So no resizing, but I wonder if it now forces it to be too high... Let's try
this and if it turns out it is too high we can do something else ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 363482] Toolview vsizing can lead to widget clipping in the Search & Replace view

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363482

--- Comment #4 from RJVB  ---
Thanks for a quick (and apparently easy) fix.

I haven't yet had time to rebuild; does the calculated container minimum height
take into account the minimum height of the "advanced" view regardless of
whether it's visible? Not that it's a problem if the toolview area is resized
when you toggle its mode...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 363482] Toolview vsizing can lead to widget clipping in the Search & Replace view

[Kåre Särs via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363482

Kåre Särs  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
 CC||kare.s...@iki.fi

--- Comment #3 from Kåre Särs  ---
Fixed in master:
Git commit 33c2769ec49c019e088c9c4f3a1e819b574ed823 by

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 363482] Toolview vsizing can lead to widget clipping in the Search & Replace view

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363482

--- Comment #2 from RJVB  ---
Created attachment 99163
  --> https://bugs.kde.org/attachment.cgi?id=99163=edit
Widget clipping under X11 with the Breeze style

I first thought this glitch was related to the sizing/misalignment issues that
occur with the Mac native theme, but clearly that's not the case.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 363482] Toolview vsizing can lead to widget clipping in the Search & Replace view

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363482

--- Comment #1 from RJVB  ---
Created attachment 99162
  --> https://bugs.kde.org/attachment.cgi?id=99162=edit
Clipped widgets on OS X with the native Macintosh QPA and widget style

-- 
You are receiving this mail because:
You are watching all bug changes.