[kate] [Bug 376504] Switching to Vi input mode causes a CPU usage spike

[V C]

https://bugs.kde.org/show_bug.cgi?id=376504

--- Comment #5 from V C  ---
Thanks Martin!

Any idea when the next release might be with this fix?

Best regards!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 376504] Switching to Vi input mode causes a CPU usage spike

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=376504

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 376504] Switching to Vi input mode causes a CPU usage spike

[Martin Sandsmark]

https://bugs.kde.org/show_bug.cgi?id=376504

Martin Sandsmark  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://commits.kde.org/kte
   ||xteditor/86f75f4f384ad9e030
   ||8c817dc4e3cbda176c2f9b

--- Comment #4 from Martin Sandsmark  ---
Git commit 86f75f4f384ad9e0308c817dc4e3cbda176c2f9b by Martin T. H. Sandsmark.
Committed on 01/07/2017 at 16:37.
Pushed by sandsmark into branch 'master'.

Fix cpu usage spiking after showing vi command bar

With Qt 5.9 (at least), QCoreApplication::hasPendingEvents() (which is
already marked as obsolete) seems to unconditionally return true, at
least here. The looping didn't make sense at all anyways.

REVIEW: 130168

M  +1-3src/vimode/emulatedcommandbar/emulatedcommandbar.cpp

https://commits.kde.org/ktexteditor/86f75f4f384ad9e0308c817dc4e3cbda176c2f9b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 376504] Switching to Vi input mode causes a CPU usage spike

[Martin Sandsmark]

https://bugs.kde.org/show_bug.cgi?id=376504

Martin Sandsmark  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

--- Comment #3 from Martin Sandsmark  ---
https://git.reviewboard.kde.org/r/130168/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 376504] Switching to Vi input mode causes a CPU usage spike

[Martin Sandsmark]

https://bugs.kde.org/show_bug.cgi?id=376504

Martin Sandsmark  changed:

   What|Removed |Added

 CC||martin.sandsm...@kde.org

--- Comment #2 from Martin Sandsmark  ---
seems like a busyloop in emulatedcommandbar, according to `perf top` and gdb.

what is this code supposed to do, why is it looping?:

https://github.com/KDE/ktexteditor/blob/master/src/vimode/emulatedcommandbar/emulatedcommandbar.cpp#L135-L137

::hasPendingEvents() is obsolete, so it has probably changed to just return
true all the time or something.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 376504] Switching to Vi input mode causes a CPU usage spike

[Dominik Haumann]

https://bugs.kde.org/show_bug.cgi?id=376504

Dominik Haumann  changed:

   What|Removed |Added

 CC||kdedevel@etotheipiplusone.c
   ||om, mikisab...@gmail.com

--- Comment #1 from Dominik Haumann  ---
@vi mode developers: maybe you can have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.