[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2023-03-06 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=458624

Christoph Cullmann  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2023-03-06 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #22 from Christoph Cullmann  ---
https://invent.kde.org/utilities/kate/-/merge_requests/1142

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2023-02-26 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #21 from Christoph Cullmann  ---
Should we now add the *.csproj stuff?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-11-12 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #20 from Christoph Cullmann  ---
We merged a change to support wildcards

https://invent.kde.org/utilities/kate/-/merge_requests/907

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #19 from Eric Armbruster  ---
Also, rootIndicationFileNames will be ignored as the rootpath is already set
previously to the project base directory. I've verified this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #18 from Christoph Cullmann  ---
> I am not yet sure whether *.csproj will work, but we already have stuff like 
> this so maybe it works.

Unfortunately I think that doesn't work, we lookup only precise filenames, no
idea why that was added to some other places.
If we want that, we need to extend that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #17 from Waqar Ahmed  ---
Can you use the following config. Put it in "User Server Settings" in the
settings dialog:
```
{
"servers": {
"c-sharp": {
"command": ["omnisharp", "-lsp"],
"commandDebug": ["omnisharp", "--debug", "--verbose"],
"url": "https://github.com/OmniSharp/omnisharp-roslyn;,
"rootIndicationFileNames": ["*.csproj"],
"highlightingModeRegex": "^C#$"
}
}
}
```
make sure the json is valid.

Then 
- open your project
- open a csharp file => should start the server

In the above config I added an explicit `"rootIndicationFileNames":
["*.csproj"],`

I am not yet sure whether *.csproj will work, but we already have stuff like
this so maybe it works.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #16 from nekone...@protonmail.ch ---
> Can you try with a project that exists in your home directory somewhere? 
> Maybe the lsp server just isn't able to access that `/mnt/...` path and falls 
> back to your home dir.

Doing this in the home folder made no difference, apparently; it still falls
back to the home directory.

```
git clone (project url)
cd (project url)
kate .
(click on files in the project folde view on the right until something triggers
kate to run the language server)
(same result as before)
```

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #15 from Waqar Ahmed  ---
> I had the editor open in /mnt/extraSgorage/ (nowhere near 
> my home directory or any "Z:" drive

Can you try with a project that exists in your home directory somewhere? Maybe
the lsp server just isn't able to access that `/mnt/...` path and falls back to
your home dir.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #14 from nekone...@protonmail.ch ---
I still have this problem (though it was a cloned Visual Studio project from
someone else's machine) but whatever...
I'm resigned to not having a solution at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-26 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #13 from Waqar Ahmed  ---
After we fixed the mismatch in project path. This should now work all the time,
right? If so, can we mark it as resolved?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #12 from Eric Armbruster  ---
This might also be relevant for you:
https://bugs.kde.org/show_bug.cgi?id=459579

Essentially, ensure before opening any document (that's when the LSP server is
started) that you have activated (selected) the project which belongs to this
document. If you want to be 100% sure that you are doing this correctly, open
only one project in Kate.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #11 from Eric Armbruster  ---
Tested now with and without my patch, and the server just works for me... even
without finding dotnet libraries. Some LSP actions seem to be not supported by
the server (Go To Declaration, Go To type definition, Highlight, Expand and
Shrink Selection) but the rest should work fine.

I would really recommend trying to fix that permissions issue. I tested with
this project
- https://github.com/ttu/csharp-tutorial as project opened at toplevel
- https://aur.archlinux.org/packages/omnisharp-roslyn

> What you're seeing is omnisharp looking in a Steam Proton prefix for no clear 
> reason; which has nothing to do with what the language server should even be 
> looking at

Yeah, don't know why it is doing that, maybe it is searching for dotnet
libraries. In any case, that cannot be influenced by Kate, so you would need to
report that at the omnisharp repo.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #10 from nekone...@protonmail.ch ---
For me, the peoject was arranged with .csproj in the top level and the .sln in
a sub-level (the opposite of what you described)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #9 from nekone...@protonmail.ch ---
The funny thing about this is: that's not where I had the editor open at all
I had the editor open in /mnt/extraSgorage/ (nowhere near my
home directory or any "Z:" drive
What you're seeing is omnisharp looking in a Steam Proton prefix for no clear
reason; which has nothing to do with what the language server should even be
looking at

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #8 from Eric Armbruster  ---
>From the logs it looks like the server started up, but maybe something went
wrong because of the permission denied:

/home/neko-san/.local/share/Steam/steamapps/compatdata/0/pfx/dosdevices/z:/var/cache/ldconfig'
is denied.
---> System.IO.IOException: Permission denied

Can you fix your permissions and retry?

Also, from the one C-Sharp project I just opened *.sln is located one level
above *.csproj. Not sure if I understood you correctly, but I would try opening
on the topmost level of the project.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #7 from nekone...@protonmail.ch ---
For more context, I did use the "open folder" action but I opened a folder that
had a .csproj file and the .sln file was in a subdirectory

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #6 from Eric Armbruster  ---
I missed that output log :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-23 Thread Eric Armbruster
https://bugs.kde.org/show_bug.cgi?id=458624

Eric Armbruster  changed:

   What|Removed |Added

 CC||eric1.armbrus...@gmail.com

--- Comment #5 from Eric Armbruster  ---
I've looked a bit into this and the rootpath of the language server is set
correctly for me. It uses the rootpath from the project base directory.

I've also started work on a patch that implements Christoph's suggestion.
Though it should not be of any help here really, as the rootpath is already set
and we generally don't want to override it.

Can you provide us additional info?
- Did you open the project using the Open Folder... action?
- In the Kate Output View are there any warnings, erros by the OmniSharp
server?

For me the server seems to have trouble finding dotnet libraries. Probably,
because some env var is not set correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-03 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=458624

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #4 from Christoph Cullmann  ---
I would assume one needs some logic to find the first directory with an .csproj
file like e.g. the vim plugin does do it.

https://github.com/nickspoons/vim-sharpenup/blob/master/autoload/sharpenup/legacycsproj.vim

Would that help? Does your project have such a file?

Unfortunately ATM we only allow a fixed list of names for such a root directory
search via

"rootIndicationFileNames": ["pubspec.yaml"],

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-02 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #3 from Waqar Ahmed  ---
You can check what other editors do. Point is, its highly unlikely any of the
kate devs will pick this as I think no one is a c# programmer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-02 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

--- Comment #2 from nekone...@protonmail.ch ---
I mean, I can try a different config (Kate already includes one by default) but
I'm not too sure how I'm going to figure it out; my experience with Omnisharp
is mostly limited to VSCode, where it typically does this on its own, so...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-02 Thread Waqar Ahmed
https://bugs.kde.org/show_bug.cgi?id=458624

Waqar Ahmed  changed:

   What|Removed |Added

 CC||waqar@gmail.com

--- Comment #1 from Waqar Ahmed  ---
Hi, if you program in C# can you try a different config or perhaps some
variable is missing from the current config?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kate] [Bug 458624] [LSP] Omnisharp-roslyn Launches Out of Scope

2022-09-01 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=458624

nekone...@protonmail.ch changed:

   What|Removed |Added

  Alias||omnisharp

-- 
You are receiving this mail because:
You are watching all bug changes.