[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Josef Weidendorfer]

https://bugs.kde.org/show_bug.cgi?id=372643

--- Comment #7 from Josef Weidendorfer  ---
Ah, I should have closed this bug after Luigi's fix,
which uses the ECM feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Luigi Toscano]

https://bugs.kde.org/show_bug.cgi?id=372643

Luigi Toscano  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kca
   ||chegrind/3c0f3423e58f65f93b
   ||f062b319a346dcea11daff
 Resolution|--- |FIXED
 CC||luigi.tosc...@tiscali.it
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Luigi Toscano  ---
I think that I have fixed this bug with:

https://commits.kde.org/kcachegrind/3c0f3423e58f65f93bf062b319a346dcea11daff

which comes from https://phabricator.kde.org/D4795

Sorry, I didn't see this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=372643

--- Comment #5 from Albert Astals Cid  ---
That's the "wrong" patch, ECM has support for that, it's just that marble
people refuse to use ECM because reasons

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Burkhard Lueck]

https://bugs.kde.org/show_bug.cgi?id=372643

--- Comment #4 from Burkhard Lueck  ---
Created attachment 102373
  --> https://bugs.kde.org/attachment.cgi?id=102373=edit
patch to load kdcachegrind_qt

copy of
https://cgit.kde.org/marble.git/commit/src/apps/marble-kde/kdemain.cpp?id=d365180db0382239e5a2dbc1c49d58ecf1f34a7f
make the gui translated except the QT_TR_NOOP strings

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Josef Weidendorfer]

https://bugs.kde.org/show_bug.cgi?id=372643

--- Comment #3 from Josef Weidendorfer  ---
(In reply to Albert Astals Cid from comment #2)
> > qcachegrind (the pure-Qt version of kcachegrind) should just depend on Qt, 
> > and no need for it to support translations.
> What makes qcachegrind differnet than kcachegrind?

It does not get installed, as it has the same feature set as kcachegrind.
I keep the qcachegrind sources here (more or less just a main window
embedding widgets from libviews) to keep the variants consistent.
If supporting translating qcachegrind is easy, of course it would be nice.

> > As said above, I want qcachegrind to just depend on Qt.
> That is just fine,

Perfect!

> did you read the email i sent?

Only now; thanks for the link!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=372643

--- Comment #2 from Albert Astals Cid  ---
> qcachegrind (the pure-Qt version of kcachegrind) should just depend on Qt, 
> and no need for it to support translations.
What makes qcachegrind differnet than kcachegrind?

> As said above, I want qcachegrind to just depend on Qt.
That is just fine, did you read the email i sent?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Josef Weidendorfer]

https://bugs.kde.org/show_bug.cgi?id=372643

--- Comment #1 from Josef Weidendorfer  ---
> but this catalog is not loaded into kcachgrind nor into qcachegrind.

Oops. I think that translations in a developer tool such as kcachegrind
often is more confusing than useful, but it has to work.

My point of view:
(*) of course, libviews + libcore must be translateable, with translations
usable in kcachegrind,
(*) qcachegrind (the pure-Qt version of kcachegrind) should just depend
on Qt, and no need for it to support translations.
I would like to keep qcachegrind around for people which compile themselves
but without the need for a full KDE development environment.

For your solution (2), do we need source code changes in libviews + libcore
at all? Ie. can calls into the Qt translation system be redirected into
xgettext functions? As said above, I want qcachegrind to just depend on Qt.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcachegrind] [Bug 372643] kcachegrind in kf5 has untranslated gui messages from catalog kcachegrind_qt.po

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=372643

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.