[kdeconnect] [Bug 488585] Shift-Return in KDE Connect SMS inserts newline at the end of field, not at cursor location
https://bugs.kde.org/show_bug.cgi?id=488585 Albert Vaca Cintora changed: What|Removed |Added Latest Commit||https://invent.kde.org/netw ||ork/kdeconnect-kde/-/commit ||/d03e964ed77a980b027e53f5d6 ||534625a9a8218b Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #3 from Albert Vaca Cintora --- Git commit d03e964ed77a980b027e53f5d6534625a9a8218b by Albert Vaca Cintora, on behalf of Ryan Frew. Committed on 28/06/2024 at 11:19. Pushed by albertvaka into branch 'master'. Corrected newline inserting when using shift+return while writing SMS messages Shift+return was always inserting newline at the end of the current line of text, ignoring where the cursor was, and not overriding currently selected text M +3-1smsapp/qml/SendingArea.qml https://invent.kde.org/network/kdeconnect-kde/-/commit/d03e964ed77a980b027e53f5d6534625a9a8218b -- You are receiving this mail because: You are watching all bug changes.
[kdeconnect] [Bug 488585] Shift-Return in KDE Connect SMS inserts newline at the end of field, not at cursor location
https://bugs.kde.org/show_bug.cgi?id=488585 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #2 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/695 -- You are receiving this mail because: You are watching all bug changes.
[kdeconnect] [Bug 488585] Shift-Return in KDE Connect SMS inserts newline at the end of field, not at cursor location
https://bugs.kde.org/show_bug.cgi?id=488585 Simon Redman changed: What|Removed |Added Keywords||junior-jobs -- You are receiving this mail because: You are watching all bug changes.
[kdeconnect] [Bug 488585] Shift-Return in KDE Connect SMS inserts newline at the end of field, not at cursor location
https://bugs.kde.org/show_bug.cgi?id=488585
Simon Redman changed:
What|Removed |Added
Ever confirmed|0 |1
Status|REPORTED|CONFIRMED
--- Comment #1 from Simon Redman ---
Confirmed this behavior. Thanks for the report.
This is pretty clear looking at the code in smsapp/qml/SendingArea.qml, line 84
on, that it appends the newline to the text entry field:
Keys.onReturnPressed: event => {
if (event.key === Qt.Key_Return) {
if (event.modifiers & Qt.ShiftModifier) {
messageField.append("")
} else {
sendButton.clicked()
event.accepted = true
}
}
}
I can't think of a way to improve this code off-hand. Tagging this as a junior
job since it's probably a simple change, just needs someone to spend a little
time researching the right solution and test it.
--
You are receiving this mail because:
You are watching all bug changes.
[kdeconnect] [Bug 488585] Shift-Return in KDE Connect SMS inserts newline at the end of field, not at cursor location
https://bugs.kde.org/show_bug.cgi?id=488585 Jiří Wolker changed: What|Removed |Added CC||kde-de...@jwo.cz -- You are receiving this mail because: You are watching all bug changes.
