[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2024-06-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=165044

Christoph Cullmann  changed:

   What|Removed |Added

 CC||eduardosanchezmunoz@gmail.c
   ||om

--- Comment #178 from Christoph Cullmann  ---
*** Bug 392317 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2024-03-08 Thread Gabriel Ravier
https://bugs.kde.org/show_bug.cgi?id=165044

Gabriel Ravier  changed:

   What|Removed |Added

 CC||gabrav...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2024-02-26 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=165044

Nate Graham  changed:

   What|Removed |Added

 CC||r...@comunica2.net

--- Comment #177 from Nate Graham  ---
*** Bug 481720 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2024-02-26 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=165044

Bug Janitor Service  changed:

   What|Removed |Added

   Priority|NOR |VHI

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-06-08 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #174 from Patrick Silva  ---
test plan from comment 173 fails on Arch Linux after upgrade to frameworks
5.59.
Dolphin says "The file or folder /tmp/test-􏹿.txt does not exist."

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-06-08 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #175 from Christoph Feck  ---
That's because this file name is using the same private code points that are
used to encode not correctly encoded UTF-8 file names. You cannot support both.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-06-08 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #176 from Patrick Silva  ---
Well, now at least I can rename and then delete the file. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-05-21 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #173 from Christoph Feck  ---
Git commit 6738a8b2f71c527f30a624b0b560f79d992715d3 by Christoph Feck.
Committed on 21/05/2019 at 11:05.
Pushed by cfeck into branch 'master'.

[kioslave/file] Add a codec for legacy filenames

UNIX filenames can contain any bytes (except \0 and /).
Qt's QFile::decodeName() calls QString::fromLocal8Bit(), assuming that all
filesystems use the system's locale encoding. For filenames that have been
created with a different encoding, and have not yet been converted (e.g. using
convmv), this creates non-reversible U+FFFD (REPLACEMENT CHARACTER)
code points in the filenames.

For example, some old-style archives might not contain any information about
the encoding of the filenames, and even today archivers extract them without
trying to convert to the locale's encoding.

While full support for those filenames is not needed, Dolphin should at least
be able to delete, rename, and move those files. Since all actual (local) file
handling is done inside the file kioslave, patching Dolphin will not help.

This code is a near verbatim copy of the code we had in kdelibs, written by
Szókovács Róbert. Only minor adaptions to Qt5 were done. It decodes invalid
bytes as U+10FExx from Plane 16 (Supplementary Private Use Area-B) to be able
to encode them later.

Dolphin could detect filenames with those characters, and either mark them
(by color or overlay icon), or even automatically offer to rename them.
Related: bug 204768

TEST PLAN

touch "/tmp/test-"$'\377'".txt"
dolphin /tmp

Copying and deleting a test file worked with this code, failed without.

Reviewers: dfaure, Frameworks, Dolphin

Reviewed by: dfaure

Differential Revision: https://phabricator.kde.org/D18161

M  +1-1src/ioslaves/file/CMakeLists.txt
M  +8-0src/ioslaves/file/file.cpp
A  +174  -0src/ioslaves/file/legacycodec.cpp [License: LGPL (v2+)]
A  +66   -0src/ioslaves/file/legacycodec.h [License: LGPL (v2+)]

https://commits.kde.org/kio/6738a8b2f71c527f30a624b0b560f79d992715d3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-01-22 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=165044

Patrick Silva  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-17 Thread Nathan Shearer
https://bugs.kde.org/show_bug.cgi?id=165044

Nathan Shearer  changed:

   What|Removed |Added

 CC||kde-20091112@nathanshearer.
   ||ca

--- Comment #166 from Nathan Shearer  ---
I just extracted an archive which contained a file that I could not
copy/edit/move/rename/delete with dolphin. The file was simple readme file
inside a nested subdirectory called L'$'\351''ame.html'

The error messages in dolphin were extremely vague and did not indicate in an
way that KDE and QT are incapable by design of handling files with these
encoding. They did not inform the user why the file was causing these problems
or even hint that they needed to be renamed in a terminal because of a WONTFIX
on this bug.

The only reason I knew what to do is because I encountered this bug years ago
when operations on these files actually worked. Any normal user will have
absolutely no idea what to do, and higher level systems will not handle these
failures gracefully when these directory structures can't be modified because
of a simple filename.

The file or folder L'$'\351''ame.html' does not exist.
 - This is _false_ it does exist!
Could not delete file L'$'\351''ame.html'.
 - No reason provided whatsoever. The user will not know how to solve this
problem.
Could not remove folder "".
 - All other files deleted, but the nested file was ignored leaving the user
confused.

This is ridiculous.

It might be a lot of work, but a solution to this problem would be to store
these strings as a tuple, where there is a degraded and user-friendly version
of the string and the original unmodified string. If no changes are made to the
string, use the original unmodified string. If the user decides to change the
string, then they are interacting with the degraded version and deciding to
keep that new string.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-18 Thread Raymond A. Meijer
https://bugs.kde.org/show_bug.cgi?id=165044

Raymond A. Meijer  changed:

   What|Removed |Added

 CC|ramei...@gmail.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-19 Thread Christian Pulvermacher
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #167 from Christian Pulvermacher  ---
unsubscribe

> Gesendet: Donnerstag, 18. April 2019 um 00:05 Uhr
> Von: "Nathan Shearer" 
> An: pulvermac...@gmx.de
> Betreff: [kdelibs] [Bug 165044] Dolphin can't handle well files/folders with 
> wrong encoding
>
> https://bugs.kde.org/show_bug.cgi?id=165044
>
> Nathan Shearer  changed:
>
>What|Removed |Added
> 
>  CC||kde-20091112@nathanshearer.
>||ca
>
> --- Comment #166 from Nathan Shearer  ---
> I just extracted an archive which contained a file that I could not
> copy/edit/move/rename/delete with dolphin. The file was simple readme file
> inside a nested subdirectory called L'$'\351''ame.html'
>
> The error messages in dolphin were extremely vague and did not indicate in an
> way that KDE and QT are incapable by design of handling files with these
> encoding. They did not inform the user why the file was causing these problems
> or even hint that they needed to be renamed in a terminal because of a WONTFIX
> on this bug.
>
> The only reason I knew what to do is because I encountered this bug years ago
> when operations on these files actually worked. Any normal user will have
> absolutely no idea what to do, and higher level systems will not handle these
> failures gracefully when these directory structures can't be modified because
> of a simple filename.
>
> The file or folder L'$'\351''ame.html' does not exist.
>  - This is _false_ it does exist!
> Could not delete file L'$'\351''ame.html'.
>  - No reason provided whatsoever. The user will not know how to solve this
> problem.
> Could not remove folder "".
>  - All other files deleted, but the nested file was ignored leaving the user
> confused.
>
> This is ridiculous.
>
> It might be a lot of work, but a solution to this problem would be to store
> these strings as a tuple, where there is a degraded and user-friendly version
> of the string and the original unmodified string. If no changes are made to 
> the
> string, use the original unmodified string. If the user decides to change the
> string, then they are interacting with the degraded version and deciding to
> keep that new string.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-19 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=165044

Christoph Feck  changed:

   What|Removed |Added

 CC|pulvermac...@gmx.de |

--- Comment #168 from Christoph Feck  ---
Removing complaining user.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-20 Thread Ivo Anjo
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #169 from Ivo Anjo  ---
(In reply to Nathan Shearer from comment #166)
> I just extracted an archive which contained a file that I could not
> copy/edit/move/rename/delete with dolphin. The file was simple readme file
> inside a nested subdirectory called L'$'\351''ame.html'
> 
> The error messages in dolphin were extremely vague and did not indicate in
> an way that KDE and QT are incapable by design of handling files with these
> encoding. They did not inform the user why the file was causing these
> problems or even hint that they needed to be renamed in a terminal because
> of a WONTFIX on this bug.
> 
> The only reason I knew what to do is because I encountered this bug years
> ago when operations on these files actually worked. Any normal user will
> have absolutely no idea what to do, and higher level systems will not handle
> these failures gracefully when these directory structures can't be modified
> because of a simple filename.
> 
> The file or folder L'$'\351''ame.html' does not exist.
>  - This is _false_ it does exist!
> Could not delete file L'$'\351''ame.html'.
>  - No reason provided whatsoever. The user will not know how to solve this
> problem.
> Could not remove folder "".
>  - All other files deleted, but the nested file was ignored leaving the user
> confused.
> 
> This is ridiculous.
> 
> It might be a lot of work, but a solution to this problem would be to store
> these strings as a tuple, where there is a degraded and user-friendly
> version of the string and the original unmodified string. If no changes are
> made to the string, use the original unmodified string. If the user decides
> to change the string, then they are interacting with the degraded version
> and deciding to keep that new string.

Hello there -- I'm the original reporter of this bug.

Since this one is marked as fixed, my suggestion would be to open a new bug
report, as the issue you saw may be a regression, rather than the same as this
bug, and it helps keep the discussion focused.

Also, if possible, my suggestion is to also include an archive that triggers
this issue as an attachment, so developers can quickly jump on this one.

Happy KDE'ing and happy easter everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-20 Thread Szokovacs Robert
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #170 from Szokovacs Robert  ---
(In reply to Ivo Anjo from comment #169)
> (In reply to Nathan Shearer from comment #166)
> > I just extracted an archive which contained a file that I could not
> > copy/edit/move/rename/delete with dolphin. The file was simple readme file
> > inside a nested subdirectory called L'$'\351''ame.html'
> > 
> > The error messages in dolphin were extremely vague and did not indicate in
> > an way that KDE and QT are incapable by design of handling files with these
> > encoding. They did not inform the user why the file was causing these
> > problems or even hint that they needed to be renamed in a terminal because
> > of a WONTFIX on this bug.
> > 
> > The only reason I knew what to do is because I encountered this bug years
> > ago when operations on these files actually worked. Any normal user will
> > have absolutely no idea what to do, and higher level systems will not handle
> > these failures gracefully when these directory structures can't be modified
> > because of a simple filename.
> > 
> > The file or folder L'$'\351''ame.html' does not exist.
> >  - This is _false_ it does exist!
> > Could not delete file L'$'\351''ame.html'.
> >  - No reason provided whatsoever. The user will not know how to solve this
> > problem.
> > Could not remove folder "".
> >  - All other files deleted, but the nested file was ignored leaving the user
> > confused.
> > 
> > This is ridiculous.
> > 
> > It might be a lot of work, but a solution to this problem would be to store
> > these strings as a tuple, where there is a degraded and user-friendly
> > version of the string and the original unmodified string. If no changes are
> > made to the string, use the original unmodified string. If the user decides
> > to change the string, then they are interacting with the degraded version
> > and deciding to keep that new string.
> 
> Hello there -- I'm the original reporter of this bug.
> 
> Since this one is marked as fixed, my suggestion would be to open a new bug
> report, as the issue you saw may be a regression, rather than the same as
> this bug, and it helps keep the discussion focused.
> 
> Also, if possible, my suggestion is to also include an archive that triggers
> this issue as an attachment, so developers can quickly jump on this one.
> 
> Happy KDE'ing and happy easter everyone!

It is in deed a regression, the fix depended on a QT feature that was removed
in 5.x, iirc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-20 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #171 from Patrick Silva  ---
(In reply to Szokovacs Robert from comment #170)
> It is in deed a regression, the fix depended on a QT feature that was
> removed in 5.x, iirc.

Is there a report in Qt tracker asking for bring back this feature removed in
5.x?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 165044] Dolphin can't handle well files/folders with wrong encoding

2019-04-20 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=165044

--- Comment #172 from Christoph Feck  ---
https://bugreports.qt.io/browse/QTBUG-59402

-- 
You are receiving this mail because:
You are watching all bug changes.