[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

[Liu Sizhuang via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=64754

--- Comment #52 from Liu Sizhuang  ---
Wow, that's incredible!
Add a line: There was no Facebook, Gmail, or Twitter at the time this bug
was filed.
2016年6月18日 上午4:43，"Bobby via KDE Bugzilla" 写道：

> https://bugs.kde.org/show_bug.cgi?id=64754
>
> --- Comment #50 from Bobby  ---
> David Faure, you deserve a medal.  A 13 year old KDE bug finally fixed.
> Just
> think, when this bug was first reported:
>
> -- The current Linux Kernel was 2.6.31
> -- Top Movie?  The ORIGINAL Underworld.
> -- Windows XP was the most current desktop verison.  Vista was still 3
> years
> away.
> -- Top 2 Linux verions?  Mandrake and Redhat (Fedora wouldn't be released
> for
> another 2 months, Ubuntu's first was more than a year away.)
> -- Top billboard song?  Crazy In Love by Jay-Z & Beyoncé (who was barely
> old
> enough to drink)
> -- 3 of the 5 KDE ev board members hadn't ever used KDE
> -- Palestinian Prime Minister Mahmoud Abbas resigns ending "Road Map for
> Peace"
> -- Current KDE version?  3.1.4  (KDE 3 had only been out for a year)
>
> Very very cool!
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You voted for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

[Christoph Cullmann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=64754

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #51 from Christoph Cullmann  ---
https://en.wikipedia.org/wiki/Linux_kernel tells 2.6.0 was not even released if
I read the charts right but otherwise: brilliant :P

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

[Bobby via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=64754

--- Comment #50 from Bobby  ---
David Faure, you deserve a medal.  A 13 year old KDE bug finally fixed.  Just
think, when this bug was first reported:

-- The current Linux Kernel was 2.6.31
-- Top Movie?  The ORIGINAL Underworld.
-- Windows XP was the most current desktop verison.  Vista was still 3 years
away.
-- Top 2 Linux verions?  Mandrake and Redhat (Fedora wouldn't be released for
another 2 months, Ubuntu's first was more than a year away.)
-- Top billboard song?  Crazy In Love by Jay-Z & Beyoncé (who was barely old
enough to drink)
-- 3 of the 5 KDE ev board members hadn't ever used KDE
-- Palestinian Prime Minister Mahmoud Abbas resigns ending "Road Map for Peace"
-- Current KDE version?  3.1.4  (KDE 3 had only been out for a year)

Very very cool!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

[David Faure via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=64754

David Faure  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.24
 Status|CONFIRMED   |RESOLVED
  Latest Commit||http://commits.kde.org/kxml
   ||gui/cfb9d1923b1376153760519
   ||edf4760248176c7c8

--- Comment #49 from David Faure  ---
Git commit cfb9d1923b1376153760519edf4760248176c7c8 by David Faure.
Committed on 17/06/2016 at 08:49.
Pushed by dfaure into branch 'master'.

KXMLGui: Fix merge indices when removing xmlgui clients with actions in groups.

Summary:
The code was assuming that all actions from the client being removed
were together in one merge point, but the group feature (added slightly later)
changed that. Indices therefore have to be adjusted after each action removal.

While extending the unittest to check this for dynamic actionlists, I found
another bug in the updating of merging indices: when a client inserts an
actionlist element (or possibly a group element for child-child-clients)
and then N more actions, the actionlist would go down N times. Fixed by
comparing clientNames, i.e. only merge points from other clients should
go down while inserting actions, nor our own [except in plugActionList].
FIXED-IN: 5.24

Test Plan:
Editing toolbars in kate to add actions (without group) to
the katepart toolbar, would lead to incoherent moving of toolbar buttons
at every document switch. This commit fixes that.

Reviewers: svuorela, dhaumann

Reviewed By: dhaumann

Subscribers: kde-frameworks-devel

Differential Revision: https://phabricator.kde.org/D1924

M  +73   -45   autotests/kxmlgui_unittest.cpp
M  +3-1src/kxmlguibuilder.h
M  +2-12   src/kxmlguifactory.cpp
M  +46   -69   src/kxmlguifactory_p.cpp
M  +3-3src/kxmlguifactory_p.h

http://commits.kde.org/kxmlgui/cfb9d1923b1376153760519edf4760248176c7c8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

[David Faure via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=64754

David Faure  changed:

   What|Removed |Added

   Assignee|co...@kde.org   |fa...@kde.org
 CC||fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdelibs] [Bug 64754] XMLGUI items (toolbar icons, menu items) from merge sections move or disappear

[Dominik Haumann via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=64754

Dominik Haumann  changed:

   What|Removed |Added

 CC||m...@archlinux.us

--- Comment #48 from Dominik Haumann  ---
*** Bug 322165 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.