[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234 Peter changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Peter --- Fixed by: http://commits.kde.org/kdenlive/f3002dd8d31de218d3f8797cfd8b93647760a9cb -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234 --- Comment #4 from Peter --- Even just && m_player != "-" alone would mean "generate script" scripts wouldn't try to play anything and segfault because of not enough arguments as generate script uses "-" as the player for kdenlive_render - this is how I render all my files. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234 Peter changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=371478, ||https://bugs.kde.org/show_b ||ug.cgi?id=371263 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234 --- Comment #3 from Peter --- Sorry, I meant: https://bugs.kde.org/show_bug.cgi?id=371478 and https://bugs.kde.org/show_bug.cgi?id=371263 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234
Peter changed:
What|Removed |Added
CC||pe...@corrosivetruths.org
--- Comment #2 from Peter ---
Created attachment 102139
--> https://bugs.kde.org/attachment.cgi?id=102139&action=edit
Patch to fix segfault and respect kdenlive_render help text
Hi, this was segfaulting pretty much everytime due to args.takeLast() not
finding anything, but also didn't really do what the kdenlive_render help text
describes "player" field as doing ("player: path to video player to play when
rendering is over, use '-' to disable playing").
Admittedly, the patch accepts path or just the program name.
Anyway, now it will ignore "-" as described and will control what player is
used when provided. If this issue is why player was removed from kdenlive, I
suppose it could be added back in?
Also probably fixes at least #371487 & #371263.
--
You are receiving this mail because:
You are watching all bug changes.
[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234 Michael Palimaka changed: What|Removed |Added CC||kensing...@gentoo.org -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 371234] kdenlive_render crashes every render
https://bugs.kde.org/show_bug.cgi?id=371234 --- Comment #1 from Peter --- Removing the following from kdenlive-16.08.2/renderer/renderjob.cpp makes it not crash. > // Decode url > QString url = QUrl::fromEncoded(args.takeLast().toUtf8()).path(); > args << url; Problem also present in git head. -- You are receiving this mail because: You are watching all bug changes.
