[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 Vincent PINON changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/kde/ ||kdenlive/commit/63f232560ec ||2fd98b266f2177b37c51c4ceb14 ||28 --- Comment #10 from Vincent PINON --- Git commit 63f232560ec2fd98b266f2177b37c51c4ceb1428 by Vincent Pinon, on behalf of Yuri Chornoivan. Committed on 05/11/2019 at 06:59. Pushed by vpinon into branch 'Applications/19.08'. Try to make it compile with gcc 9 Signed-off-by: Vincent Pinon M +2-1src/lib/external/media_ctrl/mediactrl.c https://invent.kde.org/kde/kdenlive/commit/63f232560ec2fd98b266f2177b37c51c4ceb1428 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 emohr changed: What|Removed |Added Flags||Brainstorm+ CC||fritzib...@gmx.net -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 --- Comment #9 from Christoph Feck --- According to https://invent.kde.org/kde/kdenlive/-/jobs/20790/ it also fails to build the 19.08 branch. Could someone backport if this is the correct fix? -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 --- Comment #8 from Christoph Feck --- https://invent.kde.org/kde/kdenlive/commit/1a26aa5032afbb47442b23bf5230661b92a00a23 was pushed, but without a review. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416
--- Comment #7 from Christophe Giboudeaux ---
It can be fixed with:
diff --git a/src/lib/external/media_ctrl/CMakeLists.txt
b/src/lib/external/media_ctrl/CMakeLists.txt
index 24870ad3b..ec8e2fb71 100644
--- a/src/lib/external/media_ctrl/CMakeLists.txt
+++ b/src/lib/external/media_ctrl/CMakeLists.txt
@@ -1,10 +1,10 @@
if(HAVE_LINUX_INPUT_H)
# Create a static library media_ctrl
- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --std=c99")
include_directories(
${CMAKE_BINARY_DIR}
)
add_library(media_ctrl STATIC
mediactrl.c
)
+ set_target_properties(media_ctrl PROPERTIES C_STANDARD 99)
endif()
but that means the ECM backward compatibility is broken
--
You are receiving this mail because:
You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416
--- Comment #6 from Christophe Giboudeaux ---
and that overwrites `set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --std=c99")` in
kdenlive/src/lib/external/media_ctrl/CMakeLists.txt
--
You are receiving this mail because:
You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 --- Comment #5 from Christophe Giboudeaux --- (In reply to Hannah von Reth from comment #3) > (In reply to Christophe Giboudeaux from comment #1) > > David, Hannah, I guess this is another issue caused by the recent ECM > > changes > > Shouldn't that be fixed now by > https://github.com/KDE/extra-cmake-modules/commit/ > fd6e98ba6de89a7f08364bb2ec096a5310c1cde8 ? Not in this case. previously, ECM was setting '-std=iso9899:1990', now it sets C90 which defines '-std=c90' -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 --- Comment #4 from Rik Mills --- (In reply to Hannah von Reth from comment #3) > Shouldn't that be fixed now by > https://github.com/KDE/extra-cmake-modules/commit/ > fd6e98ba6de89a7f08364bb2ec096a5310c1cde8 ? The builds I linked/referred to in #2 are all using ECM built including that commit. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 --- Comment #3 from Hannah von Reth --- (In reply to Christophe Giboudeaux from comment #1) > David, Hannah, I guess this is another issue caused by the recent ECM changes Shouldn't that be fixed now by https://github.com/KDE/extra-cmake-modules/commit/fd6e98ba6de89a7f08364bb2ec096a5310c1cde8 ? -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 Rik Mills changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 Rik Mills changed: What|Removed |Added CC||rikmi...@kubuntu.org --- Comment #2 from Rik Mills --- Same build failures on. KDE CI: https://build.kde.org/job/Applications/job/kdenlive/job/kf5-qt5%20SUSEQt5.12/164/console Neon CI: https://build.neon.kde.org/job/bionic_unstable_forks_kdenlive_bin_amd64/231/console Also fails on Kubuntu CI. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 413416] Build failure with gcc 9
https://bugs.kde.org/show_bug.cgi?id=413416 Christophe Giboudeaux changed: What|Removed |Added CC||christo...@krop.fr, ||fa...@kde.org, ||vonr...@kde.org --- Comment #1 from Christophe Giboudeaux --- David, Hannah, I guess this is another issue caused by the recent ECM changes -- You are receiving this mail because: You are watching all bug changes.
