[kdenlive] [Bug 458718] Only first word of Metadata is written to file
https://bugs.kde.org/show_bug.cgi?id=458718 --- Comment #5 from Julius Künzel --- Git commit 3a5c22910267c490960c36179f2933b3c119c2eb by Julius Künzel. Committed on 18/12/2022 at 22:06. Pushed by jlskuz into branch 'master'. [Render Settings] Reduce conversion between String and Map Using a single string for render parameters caused several issues in the past. This should reduce the risk for bugs. Related to a1304676a61959783884f90473fd2306a6ffd835 and 05fa0568d1511ab65dae958a20c342204937baca Related: bug 462650 M +2-2src/dialogs/renderpresetdialog.cpp M +64 -72 src/dialogs/renderwidget.cpp M +3-1src/dialogs/renderwidget.h M +32 -15 src/renderpresets/renderpresetmodel.cpp M +9-3src/renderpresets/renderpresetmodel.hpp M +3-3src/renderpresets/renderpresetrepository.cpp M +27 -8tests/rendermodeltest.cpp https://invent.kde.org/multimedia/kdenlive/commit/3a5c22910267c490960c36179f2933b3c119c2eb -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 458718] Only first word of Metadata is written to file
https://bugs.kde.org/show_bug.cgi?id=458718 sedrubal changed: What|Removed |Added CC||k...@sedrubal.de --- Comment #4 from sedrubal --- Thank you very much! -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 458718] Only first word of Metadata is written to file
https://bugs.kde.org/show_bug.cgi?id=458718 erjiang changed: What|Removed |Added Latest Commit||https://invent.kde.org/mult ||imedia/kdenlive/commit/a130 ||4676a61959783884f90473fd230 ||6a6ffd835 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #3 from erjiang --- Git commit a1304676a61959783884f90473fd2306a6ffd835 by Eric Jiang. Committed on 28/09/2022 at 03:50. Pushed by erjiang into branch 'master'. Put metadata directly in XML from doc Putting the project metadata in the parameters text hit an issue with whitespace in the metadata. Skipping the parameters text and putting it directly in the XML preserves the whitespace. M +11 -10 src/dialogs/renderwidget.cpp https://invent.kde.org/multimedia/kdenlive/commit/a1304676a61959783884f90473fd2306a6ffd835 -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 458718] Only first word of Metadata is written to file
https://bugs.kde.org/show_bug.cgi?id=458718 erjiang changed: What|Removed |Added Assignee|j...@kdenlive.org |erji...@alumni.iu.edu Status|CONFIRMED |ASSIGNED --- Comment #2 from erjiang --- I think inserting the metadata into the generated XML for MLT directly instead of first storing it in the parameters is the right way to go, because the parameter names (e.g. "meta.attr.title.markup") are MLT-specific and not related or directly useful for ffmpeg. Thus, I don't see this making the UI worse or less useful for advanced users. Changing the parameters to be a QStringList or similar should be a future improvement to whitespace-proof the parameters. -- You are receiving this mail because: You are watching all bug changes.
[kdenlive] [Bug 458718] Only first word of Metadata is written to file
https://bugs.kde.org/show_bug.cgi?id=458718 Eric Jiang changed: What|Removed |Added CC||erji...@alumni.iu.edu Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #1 from Eric Jiang --- Confirmed on latest master, although the fix seems to be a little more involved than wrapping the strings. The .mlt file passed to the renderer loses the words after the space in the tag. -- You are receiving this mail because: You are watching all bug changes.
