[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 Nate Graham changed: What|Removed |Added CC||i...@guoyunhe.me, ||qydwhotm...@gmail.com Component|kimpanel-dataengine |Picture of the Day -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 Nate Graham changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Version Fixed In||5.12.7 Latest Commit||https://commits.kde.org/kde ||plasma-addons/81e89f1ea830f ||278fdb6f086baa4741c9606892f --- Comment #7 from Nate Graham --- Git commit 81e89f1ea830f278fdb6f086baa4741c9606892f by Nathaniel Graham, on behalf of Kristopher Ives. Committed on 28/08/2018 at 21:23. Pushed by ngraham into branch 'Plasma/5.12'. [POTD] Actually update the image every day Summary: This patch adjusts the dirty condition so that the image is actually updated once a day, not once every two days. FIXED-IN: 5.12.7 Test Plan: Applied patch, set a POTD wallpaper, waited one day, noticed that the image had changed. Reviewers: #plasma, kossebau, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D15124 M +1-1dataengines/potd/cachedprovider.cpp M +1-1dataengines/potd/potd.cpp https://commits.kde.org/kdeplasma-addons/81e89f1ea830f278fdb6f086baa4741c9606892f -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 --- Comment #6 from Nate Graham --- Thanks for giving it your all, Kristopher. We're aware that this process isn't exactly user-friendly and we're working on improving it. I've gone ahead and submitted the patch in your name: https://phabricator.kde.org/D15124 If it lands, you'll get the credit, since after all, you found the fix. :) -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 --- Comment #5 from Kristopher Ives --- Welp! I think I will leave this in the hands of a more capable KDE developer. I tried to do: ./kdesrc-build kdeplasma-addons As well as: ./kdesrc-build --include-dependencies kdeplasma-addons A large amount of pieces built successfully, but ultimately a few pieces failed to compile with errors like: CMake Error at src/CMakeLists.txt:73 (add_library): Target "KF5XmlGui" links to target "Qt5::CorePrivate" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? Likewise kwallet failed to compile because it couldn't find libgpgme, and in general this seems like a lot to change a single line of code! I'm sure a more capable KDE developer can figure it all out or use their existing development environment to figure it out, but for me I'm bowing out of this battle early. KDE build system looks pretty cool but also seems very complex! It seems if I'm not able to this basic change there is likely not much hope in me contributing much value to KDE development wise as a whole. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 --- Comment #4 from Kristopher Ives --- I was able to get kdesrc-build setup and running and currently am waiting for this command to finish: ./kdesrc-build --include-dependencies plasma-desktop That might take a while, obviously. I am interested if anyone knows if there is an easier way to test these changes. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 --- Comment #3 from Kristopher Ives --- Hi guys! I tried setting up a development environment to test this, but cmake complains about a chain of things and I gave up after grabbing plasma. Here is what I tried so far: sudo apt build-dep kdeplasma-addons apt source kdeplasma-addons cd kdeplasma-addons* cmake . I then get this problem: Make Error at CMakeLists.txt:9 (message): plasma requires an out of source build. Please create a separate build directory and run 'cmake path_to_plasma [options]' there. So I repeat the process for plasma-desktop, which then gives another layer of turtles: -- The following RUNTIME packages have not been found: * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency. Sorry for not being familiar with KDE development practices! Any advice would be awesome. Thank you! -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 Nate Graham changed: What|Removed |Added CC||n...@kde.org --- Comment #2 from Nate Graham --- Yes, very nice! Note that there are two instances of this logic: one in dataengines/potd/potd.cpp and another one in dataengines/potd/cachedprovider.cpp. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 Andrew Crouthamel changed: What|Removed |Added CC||andrew.crouthamel@kdemail.n ||et -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 397914] Picture of the Day doesn't change every day
https://bugs.kde.org/show_bug.cgi?id=397914 David Edmundson changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||k...@davidedmundson.co.uk --- Comment #1 from David Edmundson --- Sounds like the cause, good stuff. Want to make the change? https://community.kde.org/Get_Involved/development#Submitting_your_first_patch -- You are receiving this mail because: You are watching all bug changes.
