[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Kevin Funk changed: What|Removed |Added CC||aleix...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 --- Comment #1 from Kevin Funk --- @Aleix: Ideas? -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Kevin Funk changed: What|Removed |Added CC||aleix...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Igor Kushnir changed: What|Removed |Added Ever confirmed|0 |1 Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED CC||igor...@gmail.com --- Comment #5 from Igor Kushnir --- Still happens in KDevelop 5.6.0. I have fixes for this and related crash in Bug 423651. Will create a merge request soon, after some testing. -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Igor Kushnir changed: What|Removed |Added Assignee|kdevelop-bugs-n...@kde.org |igor...@gmail.com Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Igor Kushnir changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/kdev ||elop/kdevelop/commit/103ab0 ||be11f659cf52d86a5c01d749b70 ||989091b Resolution|--- |FIXED Version Fixed In||5.6.1 --- Comment #6 from Igor Kushnir --- Git commit 103ab0be11f659cf52d86a5c01d749b70989091b by Igor Kushnir. Committed on 07/10/2020 at 10:26. Pushed by igorkushnir into branch '5.6'. Kill CTestFindJob when its project is destroyed When a user closes a project while its associated CTestFindJob is still working, the job is not notified and keeps running. After that, when BackgroundParser eventually parses all documents requested by the job, the job calls TestController::addTestSuite(). Inside this call the CTestSuite::project() pointer is dereferenced in TestView::addTestSuite() => TestView::itemForProject(), which causes a segmentation fault. Ideally all associated CTestFindJob-s should be killed just before or just after a project is closed to revert their no longer useful requests to BackgroundParser as soon as possible. However, reliably detecting that the project is no longer open is not straightforward, especially if the project opening is aborted or the project is closed even before a CTestFindJob is created. My implementation of such a proper fix is intertwined with several other CTest-, TestController- and TestView-related fixes. The combined fix will be so large that it won't fit into the 5.6 branch. So this commit implements a simple temporary workaround for the fairly easy to trigger crash: check if the project is destroyed in CTestFindJob::updateReady() and kill the job if this is the case. FIXED-IN: 5.6.1 M +7-0plugins/cmake/testing/ctestfindjob.cpp M +2-1plugins/cmake/testing/ctestsuite.h https://invent.kde.org/kdevelop/kdevelop/commit/103ab0be11f659cf52d86a5c01d749b70989091b -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO |RESOLVED --- Comment #4 from Bug Janitor Service --- This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 Andrew Crouthamel changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #2 from Andrew Crouthamel --- Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 --- Comment #3 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 329246] Crash when project is closed before CTest evaluation finished
https://bugs.kde.org/show_bug.cgi?id=329246 --- Comment #1 from Kevin Funk --- @Aleix: Ideas? -- You are receiving this mail because: You are watching all bug changes.
