[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In||5.0.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Alexander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #17 from Alexander  ---
No, no crashes after Milian's  commit.
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

Kevin Funk  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WAITINGFORINFO

--- Comment #16 from Kevin Funk  ---
@op: Do you still get this crash?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #14 from Milian Wolff  ---
OK, ouch... I'll commit this as a hotfix and will think of a way to solve it
for real.

Thanks for the tests!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #15 from Milian Wolff  ---
Git commit 7b0b2ae069377585e3416c7d8431a1a11520e0a9 by Milian Wolff.
Committed on 07/12/2015 at 23:24.
Pushed by mwolff into branch '5.0'.

Workaround crash when expanding project folder.

Nested eventloops are evil, and the querying of the branch name
apparently can trigger a nested eventloop in SVN projects that
can trigger all kinds of havoc.

Moving the line down seems to reduce the crashiness of this code.
A proper solution is still required.

M  +4-1plugins/projectmanagerview/projectmodelitemdelegate.cpp

http://commits.kde.org/kdevplatform/7b0b2ae069377585e3416c7d8431a1a11520e0a9

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #11 from Milian Wolff  ---
I have strange painting issues with the gsmartcontrol project, i.e. expanding a
folder does not update the tree immediately. But no crash and valgrind is also
not reporting anything about a broken QTransform :(

So I'm out of luck in fixing it myself.

@Alexander: Any chance you could compile Qt from sources in debug mode and
retrigger this issue? Then the backtrace would show us more details (i.e. file
+ line into Qt sources).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #12 from Milian Wolff  ---
One more idea: what happens when you move the following line down to where it
is being used:

 QString branchNameData =
index.data(VcsOverlayProxyModel::VcsStatusRole).toString();

and/or what happens if you replace it by


 QString branchNameData; // =
index.data(VcsOverlayProxyModel::VcsStatusRole).toString();

I ask b/c this potentially spins up a nested eventloop leading to all kinds of
funny issues... If this "fixes" the issue, then we at least know where to look
for a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Alexander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #13 from Alexander  ---
Moving the line helped, no crash and so far it looks like everything is OK!
Must be the event loop then...

Commenting it out also helps (obviously).

Finally, I can use KDevelop 5 properly, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Alexander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #7 from Alexander  ---
Hi,
The project I was testing it with is not FOSS, but I re-ran kdevelop with an
open source one and still got a crash. Here's the checkout URL for easy
testing:
svn checkout svn://svn.code.sf.net/p/gsmartcontrol/code/trunk gsmartcontrol


This is the valgrind output (there are no warnings except that IOCTL one until
I expand the project tree).

> valgrind --track-origins=yes --smc-check=all-non-file kdevelop
==30551== Memcheck, a memory error detector
==30551== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
==30551== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
==30551== Command: kdevelop
==30551== 
Ninja plugin installed but ninja is not installed.
Could not load plugin "KDevNinjaBuilder" , it reported the error: "" Disabling
the plugin now.
Ninja plugin installed but ninja is not installed.
Could not load plugin "KDevNinjaBuilder" , it reported the error: "" Disabling
the plugin now.
The font for use in the terminal has not been matched exactly. Perhaps it has
not been found properly.
The font for use in the terminal has not been matched exactly. Perhaps it has
not been found properly.
==30551== Warning: noted but unhandled ioctl 0x6458 with no size/direction
hints.
==30551==This could cause spurious value errors to appear.
==30551==See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a
proper wrapper.
settingsFile:  "/home/alex"
settingsFile:  "/home/alex"
settingsFile:  "/home/alex"
settingsFile:  "/home/alex"
==30551== Thread 11 Queue(0x292381e0)[06]:
==30551== Invalid read of size 8
==30551==at 0x355C3420: svn_utf__cstring_is_valid (in
/usr/lib64/libsvn_subr-1.so.0.0.0)
==30551==by 0x355C2580: ??? (in /usr/lib64/libsvn_subr-1.so.0.0.0)
==30551==by 0x355C2B0B: svn_utf_cstring_from_utf8 (in
/usr/lib64/libsvn_subr-1.so.0.0.0)
==30551==by 0x355AF795: svn_path_cstring_from_utf8 (in
/usr/lib64/libsvn_subr-1.so.0.0.0)
==30551==by 0x3559C42F: svn_dirent_get_absolute (in
/usr/lib64/libsvn_subr-1.so.0.0.0)
==30551==by 0x34EF13F4: svn_client_info2 (in
/usr/lib64/libsvn_client-1.so.0.0.0)
==30551==by 0x34EF1442: svn_client_info (in
/usr/lib64/libsvn_client-1.so.0.0.0)
==30551==by 0x34C8A6C3: svn::Client::info(svn::Path const&, bool,
svn::Revision const&, svn::Revision const&) (in
/opt/local/kdevelop/lib64/plugins/kdevplatform/24/kdevsubversion.so)
==30551==by 0x34C6DF5E:
SvnInternalInfoJob::run(QSharedPointer,
ThreadWeaver::Thread*) (in
/opt/local/kdevelop/lib64/plugins/kdevplatform/24/kdevsubversion.so)
==30551==by 0x10621B9F:
ThreadWeaver::Executor::run(QSharedPointer const&,
ThreadWeaver::Thread*) (in /usr/lib64/libKF5ThreadWeaver.so.5.15.0)
==30551==by 0x1062092F:
ThreadWeaver::Job::execute(QSharedPointer const&,
ThreadWeaver::Thread*) (in /usr/lib64/libKF5ThreadWeaver.so.5.15.0)
==30551==by 0x1061FF39: ThreadWeaver::Thread::run() (in
/usr/lib64/libKF5ThreadWeaver.so.5.15.0)
==30551==  Address 0x29765e50 is 80 bytes inside a block of size 86 alloc'd
==30551==at 0x4C29670: operator new(unsigned long) (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==30551==by 0xC199918: std::string::_Rep::_S_create(unsigned long, unsigned
long, std::allocator const&) (in /usr/lib64/libstdc++.so.6.0.21)
==30551==by 0xC199BEA: std::string::_M_mutate(unsigned long, unsigned long,
unsigned long) (in /usr/lib64/libstdc++.so.6.0.21)
==30551==by 0xC19A20D: std::string::_M_replace_safe(unsigned long, unsigned
long, char const*, unsigned long) (in /usr/lib64/libstdc++.so.6.0.21)
==30551==by 0x34C9048A: svn::Path::init(char const*) (in
/opt/local/kdevelop/lib64/plugins/kdevplatform/24/kdevsubversion.so)
==30551==by 0x34C9032F: svn::Path::Path(char const*) (in
/opt/local/kdevelop/lib64/plugins/kdevplatform/24/kdevsubversion.so)
==30551==by 0x34C6DF28:
SvnInternalInfoJob::run(QSharedPointer,
ThreadWeaver::Thread*) (in
/opt/local/kdevelop/lib64/plugins/kdevplatform/24/kdevsubversion.so)
==30551==by 0x10621B9F:
ThreadWeaver::Executor::run(QSharedPointer const&,
ThreadWeaver::Thread*) (in /usr/lib64/libKF5ThreadWeaver.so.5.15.0)
==30551==by 0x1062092F:
ThreadWeaver::Job::execute(QSharedPointer const&,
ThreadWeaver::Thread*) (in /usr/lib64/libKF5ThreadWeaver.so.5.15.0)
==30551==by 0x1061FF39: ThreadWeaver::Thread::run() (in
/usr/lib64/libKF5ThreadWeaver.so.5.15.0)
==30551==by 0xBA9755E: QThreadPrivate::start(void*) (qthread_unix.cpp:331)
==30551==by 0x12FF10A3: start_thread (in /lib64/libpthread-2.19.so)
==30551== 
job started 0x41decc40
job done SvnInternalInfoJob(0x41decc40)
==30551== Thread 1:
==30551== Invalid read of size 2
==30551==at 0xB2EBB30: QTransform::type() const (in
/usr/lib64/libQt5Gui.so.5.5.0)
==30551==by 0xB27C3A9: ??? (in /usr/lib64/libQt5Gui.so.5.5.0)
==30551==by 0xB284137: QRasterPaintEngine::drawPixmap(QRectF const&,
QPixmap const&, QRectF const&) 

[kdevelop] [Bug 355099] Crash when expanding project folder in Projects tab

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355099

--- Comment #6 from Milian Wolff  ---
Can you run it through valgrind and see what you get reported? The stuff above
doesn't look suspicious to me...

valgrind --track-origins=yes --smc-check=all-non-file kdevelop -s ...

And is the project you are working on FOSS, i.e. can I check it out via svn and
try to reproduce it locally?

-- 
You are receiving this mail because:
You are watching all bug changes.