[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #15 from RJVB  ---
For future reference:

"How Do I Declare A Block in Objective-C?" [http://goshdarnblocksyntax.com/]

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #14 from RJVB  ---
Done. 

I should have used the occasion to suggest (commit?) a bit more detailed output
in the warnings about unsupported types, printing the line for instance.

Re: Phab: any ETA on integration in KDevelop?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

RJVB  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kdev
   ||elop/90ea6edaf29f3ca62bba9f
   ||1d0f1be61eaf1912c5

--- Comment #13 from RJVB  ---
Git commit 90ea6edaf29f3ca62bba9f1d0f1be61eaf1912c5 by René J.V. Bertin.
Committed on 28/06/2016 at 20:45.
Pushed by rjvbb into branch '5.0'.

minimal parser support for block pointers, recognising them as
function pointers (good enough for a first approach). Reduces the
amount of parser warnings when scanning the system SDK headers on
Mac OS X.
Committed from host : Portia.local

M  +1-0languages/clang/duchain/builder.cpp

http://commits.kde.org/kdevelop/90ea6edaf29f3ca62bba9f1d0f1be61eaf1912c5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

Kevin Funk  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

Kevin Funk  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #12 from Kevin Funk  ---
https://bugsfiles.kde.org/attachment.cgi?id=99747 looks good (enough) for me.

Feel free to push the patch adding minimal support to 5.0 branch. If you have
tests, please post to Phab.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #11 from RJVB  ---
I'll have to get feedback from someone more knowledgeable about this kind of
syntax question.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #10 from RJVB  ---
Created attachment 99749
  --> https://bugs.kde.org/attachment.cgi?id=99749=edit
code completion in Xcode

Xcode doesn't have an equivalent to KDevelop's context browser that pops up an
informational window when hovering over a variable, argument or function. It
does have "intellisense"-style code completion; this is what it shows as the
suggested completion for a method taking a single block pointer argument.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #9 from RJVB  ---
Created attachment 99747
  --> https://bugs.kde.org/attachment.cgi?id=99747=edit
context browser output for a block pointer with minimal support for
CXType_BlockPointer

Minimal support means adding only `UseKind(CXType_BlockPointer)` in
Visitor::makeType() .

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #8 from RJVB  ---
Created attachment 99746
  --> https://bugs.kde.org/attachment.cgi?id=99746=edit
Current context browser output for a block pointer argument

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #7 from Milian Wolff  ---
yes

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #6 from RJVB  ---
btw, from https://en.wikipedia.org/wiki/Blocks_(C_language_extension):

> The block may be assigned to variables, passed to functions, and otherwise 
> treated like a normal function pointer

That seems to suggest that it should be acceptable for the context browser to
show the type as a regular function pointer, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #5 from RJVB  ---
http://clang.llvm.org/docs/LanguageExtensions.html#blocks

I'll try to determine if a more exhaustive fix is required than simply adding a
`UseKind` line and what that should be.

If a more complex implementation is indeed required, a temporary null fix would
be to avoid the warning message at least on OS X, or print it only once.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[Milian Wolff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #4 from Milian Wolff  ---
What is a Block? Anyhow, please push a patch somewhere for review.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #3 from RJVB  ---
NB: blocks are not exclusive to OS X !

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #2 from Kevin Funk  ---
@RJVB, please add a test to confirm & make sure it works. No time to test on OS
X at this point.

See kdevelop.git:languages/clang/tests. The files/ folder contains
easy-to-extend unit tests where you can add code and express the expected
output directly inside code documentation blocks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[RJVB via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

--- Comment #1 from RJVB  ---
Isn't this a question of just adding a `UseKind(CXType_BlockPointer)` statement
in the right place? It makes the warnings go away and gives what looks like a
perfectly acceptable context browsing popup.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 364749] parser support for Blocks please

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364749

Kevin Funk  changed:

   What|Removed |Added

   Priority|NOR |LO

-- 
You are receiving this mail because:
You are watching all bug changes.