[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=387994

Kevin Funk  changed:

   What|Removed |Added

   Version Fixed In||5.2.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=387994

Kevin Funk  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde
   |velop/335786a16731b093bf6b0 |velop/dd038eb1a8fb4d663fe03
   |27c8c51ef653425b73a |eb6bd6ebf16d8ace3d0

--- Comment #8 from Kevin Funk  ---
Git commit dd038eb1a8fb4d663fe03eb6bd6ebf16d8ace3d0 by Kevin Funk, on behalf of
Guillaume Racicot.
Committed on 15/03/2018 at 18:39.
Pushed by kfunk into branch '5.2'.

Make lambda introduce a context in DU chain

Summary:
Lambda in clang completion were not introducing a context. This
had the effect of making all local variable in a global lambda
highlighted as a global

Reviewers: #kdevelop, mwolff

Reviewed By: #kdevelop, mwolff

Subscribers: kfunk, mwolff, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D11303

(cherry picked from commit 335786a16731b093bf6b027c8c51ef653425b73a)

M  +8-3plugins/clang/duchain/builder.cpp
M  +21   -0plugins/clang/tests/test_duchain.cpp
M  +1-0plugins/clang/tests/test_duchain.h

https://commits.kde.org/kdevelop/dd038eb1a8fb4d663fe03eb6bd6ebf16d8ace3d0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Milian Wolff]

https://bugs.kde.org/show_bug.cgi?id=387994

Milian Wolff  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kde
   ||velop/335786a16731b093bf6b0
   ||27c8c51ef653425b73a
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Milian Wolff  ---
Git commit 335786a16731b093bf6b027c8c51ef653425b73a by Milian Wolff, on behalf
of Guillaume Racicot.
Committed on 14/03/2018 at 22:51.
Pushed by mwolff into branch 'master'.

Make lambda introduce a context in DU chain

Summary:
Lambda in clang completion were not introducing a context. This
had the effect of making all local variable in a global lambda
highlighted as a global

Reviewers: #kdevelop, mwolff

Reviewed By: #kdevelop, mwolff

Subscribers: kfunk, mwolff, kdevelop-devel

Differential Revision: https://phabricator.kde.org/D11303

M  +8-3plugins/clang/duchain/builder.cpp
M  +21   -0plugins/clang/tests/test_duchain.cpp
M  +1-0plugins/clang/tests/test_duchain.h

https://commits.kde.org/kdevelop/335786a16731b093bf6b027c8c51ef653425b73a

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Guillaume Racicot]

https://bugs.kde.org/show_bug.cgi?id=387994

--- Comment #6 from Guillaume Racicot  ---
Ah! I simply enclosed all lambda in a function, took a screenshot and edited
out the function in gimp. I didn't found a magic workaround for that
unfortunately :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Milian Wolff]

https://bugs.kde.org/show_bug.cgi?id=387994

--- Comment #5 from Milian Wolff  ---
I mean: how did you get the correct highlighting? Do you have a patch
available?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Guillaume Racicot]

https://bugs.kde.org/show_bug.cgi?id=387994

--- Comment #4 from Guillaume Racicot  ---
The fixed version of my screenshot simply removed the colored highlighting for
the lambda names, since they are global themselves.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Milian Wolff]

https://bugs.kde.org/show_bug.cgi?id=387994

Milian Wolff  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #3 from Milian Wolff  ---
how did you "fix" it?

Anyway, easy to reproduce. Here's an MWE:


int sum(int foo, int bar) {
return foo + bar;
}

auto sum_lambda = [](int foo, int bar) {
return foo + bar;
};

int sum_lambda_wrapped(int bla, int blub)
{
return [](int foo, int bar) {
return foo + bar;
}(bla, blub);
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Guillaume Racicot]

https://bugs.kde.org/show_bug.cgi?id=387994

--- Comment #2 from Guillaume Racicot  ---
Created attachment 109433
  --> https://bugs.kde.org/attachment.cgi?id=109433=edit
Expected result of hightlighting (fixed)

Please refer to this one, the previous edited screenshot contained errors

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 387994] All variable in body and parameter in a global lambda hightlighted as global variables

[Guillaume Racicot]

https://bugs.kde.org/show_bug.cgi?id=387994

--- Comment #1 from Guillaume Racicot  ---
Created attachment 109432
  --> https://bugs.kde.org/attachment.cgi?id=109432=edit
Expected result of hightlighting

-- 
You are receiving this mail because:
You are watching all bug changes.