https://bugs.kde.org/show_bug.cgi?id=409222
Igor Kushnir changed:
What|Removed |Added
Version Fixed In||5.5.1
Latest Commit||https://invent.kde.org/kde/
||kdevelop/commit/f56cdda54b7
||f88b119f2c7cfb2f534b4fe7447
||8f
Resolution|--- |FIXED
Status|ASSIGNED|RESOLVED
--- Comment #4 from Igor Kushnir ---
Git commit f56cdda54b7f88b119f2c7cfb2f534b4fe74478f by Igor Kushnir.
Committed on 02/05/2020 at 16:28.
Pushed by igorkushnir into branch '5.5'.
Work around QDir::match() behavior change in Qt 5.12.0
QDir::match() migrated to QRegularExpression in Qt 5.12.0. In the new
implementation asterisk in a wildcard no longer matches path separators.
This caused two bugs in KDevelop:
1. kdev_format_source rejects input files if the 'format_sources' file
is not located in the same directory as the target file.
2. Exclude filter in Find/Replace in Files has no effect (unless the
user specifies almost complete paths in the format supported by Bash
Filename Expansion with the globstar shell option disabled).
Note that Files (aka `include`) filter in Find/Replace in Files is
unaffected by the behavior change because in its code a filename rather
than a path is passed as the second argument to QDir::match().
WildcardHelpers can migrate to
QRegularExpression::wildcardToRegularExpression() once we require
Qt 5.12.1 or later. This function was added in Qt 5.12.0 and started
anchoring wildcard pattern in Qt 5.12.1.
Ideally support for globstar (**) in glob patterns should be added to
QRegularExpression::wildcardToRegularExpression() and to QDir::match().
In that case WildcardHelpers could be eliminated and QDir::match() could
be used again.
If globstar support is not added to
QRegularExpression::wildcardToRegularExpression(), WildcardHelpers can
port away from QRegExp, for example, by replacing `starEscape` (see the
definition of wildcardToRegularExpression()) with ".*" in the value
returned by wildcardToRegularExpression() and passing
DotMatchesEverythingOption to QRegularExpression constructor.
When we port away from QRegExp, we can change the syntax of
format_sources and possibly Exclude filter to match Bash globstar
syntax or perhaps some other new Qt wildcard syntax. Alternatively, we
can process user-provided wildcard patterns before and/or after passing
them to wildcardToRegularExpression() so as to preserve our syntax.
Related: bug 417628
FIXED-IN: 5.5.1
M +1-0kdevplatform/util/CMakeLists.txt
M +3-1kdevplatform/util/kdevformatfile.cpp
A +59 -0kdevplatform/util/wildcardhelpers.h [License: LGPL (v2+)]
M +2-1plugins/grepview/grepdialog.cpp
M +4-2plugins/grepview/grepfindthread.cpp
https://invent.kde.org/kde/kdevelop/commit/f56cdda54b7f88b119f2c7cfb2f534b4fe74478f
--
You are receiving this mail because:
You are watching all bug changes.
