[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Alexander Zhigalin]

https://bugs.kde.org/show_bug.cgi?id=49719

Alexander Zhigalin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Sven Brauch via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

--- Comment #9 from Sven Brauch  ---
Ok, sorry, I misunderstood that you wanted to copy those icons instead of just
using them.

I'm still in favor of using the red dot instead of some concentric circles or
triangles; all IDEs in the world have been using a red dot for breakpoints in
the last twenty years, so we should not break that for no reason.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Alexander Zhigalin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

--- Comment #8 from Alexander Zhigalin  ---
(In reply to Sven Brauch from comment #6)
> No, that is making the exact same mistake again: you use an icon with an
> unrelated semantic name just because it looks ok in the theme you assume.
> "sharpen image" might be something completely unsuitable in a different
> theme (e.g. oxygen).
> 
> Either we get a dedicated icon called "breakpoint.svg" in breeze, or we ship
> our own, which is what I suggest in https://phabricator.kde.org/D3061.

Sven, you aren't getting it.
I was proposing to use that images for "breakpoint.svg" and
"breakpoint-current.svg" instead of that ugly red dot you have committed which
breaks all the visuals being all the other icons just colourless shapes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Sven Brauch via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

--- Comment #7 from Sven Brauch  ---
Git commit 3e4c15c9c88a4bd6c5458718cb917882da9b097f by Sven Brauch.
Committed on 16/10/2016 at 10:36.
Pushed by brauch into branch '5.0'.

Do not use "script-error" icon for breakpoints

It just doesn't look right for some themes, e.g. Breeze. Instead, we
ship our own icon, which looks like what people expect (red dot).

At this occasion, use 16x16 size for the icon border icon,
because the width of the icon border is fixed to that in kate.
Differential Revision: https://phabricator.kde.org/D3061

M  +4-4debugger/breakpoint/breakpointmodel.cpp
M  +1-1debugger/interfaces/ibreakpointcontroller.cpp
A  +---pics/16x16/actions/breakpoint.png
A  +---pics/22x22/actions/breakpoint.png
M  +2-5pics/CMakeLists.txt
A  +95   -0pics/scalable/breakpoint.svg
M  +1-1shell/debugcontroller.cpp

http://commits.kde.org/kdevplatform/3e4c15c9c88a4bd6c5458718cb917882da9b097f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Sven Brauch via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

--- Comment #6 from Sven Brauch  ---
No, that is making the exact same mistake again: you use an icon with an
unrelated semantic name just because it looks ok in the theme you assume.
"sharpen image" might be something completely unsuitable in a different theme
(e.g. oxygen).

Either we get a dedicated icon called "breakpoint.svg" in breeze, or we ship
our own, which is what I suggest in https://phabricator.kde.org/D3061.

Regarding enabling the border by default, I sent a mail to kwrite-devel, I
don't think we can change default options right now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Alexander Zhigalin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

Alexander Zhigalin  changed:

   What|Removed |Added

 CC||alexan...@zhigalin.tk

--- Comment #5 from Alexander Zhigalin  ---
+1
For icons I propose:
 - breakpoint: "draw-donut" or "crosshairs"
 - current breakpoint: "sharpenimage" rotated or "draw-triangle2"

"draw-donut" -
https://quickgit.kde.org/?p=breeze-icons.git=blob=icons%2Factions%2F24%2Fdraw-donut.svg=plain
"crosshairs"  -
https://quickgit.kde.org/?p=breeze-icons.git=blob=icons%2Factions%2F22%2Fcrosshairs.svg=plain
"sharpenimage" -
https://quickgit.kde.org/?p=breeze-icons.git=blob=icons%2Factions%2F22%2Fsharpenimage.svg=plain
"draw-triangle2" -
https://quickgit.kde.org/?p=breeze-icons.git=blob=icons%2Factions%2F22%2Fdraw-triangle2.svg=plain

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Simon Andric via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Kevin Funk via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

--- Comment #4 from Kevin Funk  ---
+1. When I did some Q with a KDevelop noob the missing icon border was pretty
confusing to that person. When pausing the debugger you don't even get a mark
for the line you're in!

And yes, the Breeze icons for breakpoint + 'current line in debugger' are
really unfortunate...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Sven Brauch via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

Sven Brauch  changed:

   What|Removed |Added

 CC||kf...@kde.org,
   ||m...@svenbrauch.de
 Status|REOPENED|CONFIRMED

--- Comment #3 from Sven Brauch  ---
I agree with basically all you said.

Icon border and line numbers should be enabled by default. It's ok to not have
this for kate, since it is used by a lot of people to edit simple text, but for
KDevelop it should just be on.

The breeze icon we use for breakpoint is really bad and unsuitable, from the
aesthetic (imo) point of view but especially from the recognizability -- it
just doesn't fit. I'll look that we can get a dedicated "breakpoint" icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 49719] breakpoints are hard to see with dark themes, icon border should be enabled by default

[Janek Bevendorff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=49719

Janek Bevendorff  changed:

   What|Removed |Added

Summary|breakpoints are not visible |breakpoints are hard to see
   |in editor window|with dark themes, icon
   ||border should be enabled by
   ||default

-- 
You are receiving this mail because:
You are watching all bug changes.