https://bugs.kde.org/show_bug.cgi?id=417922
Méven Car changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/kio
||/eb20176d1a42eebd4c6c3cbdb5
||dca6a854760736
Resolution|--- |FIXED
Version Fixed In||5.68
Status|CONFIRMED |RESOLVED
--- Comment #2 from Méven Car ---
Git commit eb20176d1a42eebd4c6c3cbdb5dca6a854760736 by Méven Car.
Committed on 22/02/2020 at 11:35.
Pushed by meven into branch 'master'.
KIO::iconNameForUrl: fix searching for kde protocol icons
Summary:
iconName was set to mt.iconName() at the beginning, but this returns always
"application-octet-stream" making all subsequent iconName.isEmpty() check not
work as expected.
This patch sets iconName to mt.iconName() only when needed.
Related: bug 417921, bug 417069
FIXED-IN: 5.68
Test Plan:
In dolphin:
- open "Recent Files"
- Ctrl+T
- open any folder
- Ctrl+T
- Ctrl+F (Search
- Search for anything, type something then return
Same for smb:/ location
In all cases the protocol icon is now visible.
Reviewers: ngraham, #frameworks, dfaure, broulik, sitter
Reviewed By: ngraham, dfaure, sitter
Subscribers: sitter, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27539
M +13 -1autotests/kfileitemtest.cpp
M +14 -18 src/core/global.cpp
https://commits.kde.org/kio/eb20176d1a42eebd4c6c3cbdb5dca6a854760736
--
You are receiving this mail because:
You are watching all bug changes.
