[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 Nate Graham changed: What|Removed |Added Version Fixed In||5.18.0 -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366
Nate Graham changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/pla
||sma-workspace/423308f854c4b
||76c72da4e3263614c7b20642ebf
Status|ASSIGNED|RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Nate Graham ---
Git commit 423308f854c4b76c72da4e3263614c7b20642ebf by Nate Graham, on behalf
of Piotr Henryk Dabrowski.
Committed on 16/12/2019 at 22:58.
Pushed by ngraham into branch 'master'.
[Klipper] Fix clipboard history management
Summary:
Fixed clearing the clipboard when clearing history
(bug #409366 caused by 3bd6ac34ed74e3b86bfb6b29818b726baf505f20)
Properly synchronize clipboard content and history
(deleting last item in history didn't clear the clipboard).
Keep last image in history even if we are ignoring images, but without preview
(so that we can still clear history, and the tooltip says truth about clipboard
content).
Fixed tray icon tooltip text.
Do not scale small images up in clipboard Plasmoid.
{F7168503}
Test Plan:
Spectacle -> [Copy to Clipboard]
Paste into Dolphin (clipboard content)
Deleting single items from clipboard
Clearing the entire history
Reviewers: #plasma, #plasma_workspaces, ngraham, davidedmundson
Reviewed By: #plasma, #plasma_workspaces, ngraham, davidedmundson
Subscribers: GB_2, davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22684
M +1-1applets/clipboard/contents/ui/ClipboardPage.qml
M +2-1applets/clipboard/contents/ui/ImageItemDelegate.qml
M +2-0klipper/autotests/CMakeLists.txt
M +23 -7klipper/historyimageitem.cpp
M +1-1klipper/historyimageitem.h
M +2-2klipper/historyitem.cpp
M +4-1klipper/historyitem.h
M +1-0klipper/historymodel.cpp
M +12 -0klipper/historymodel.h
M +23 -14 klipper/klipper.cpp
M +2-2klipper/klipper.h
https://commits.kde.org/plasma-workspace/423308f854c4b76c72da4e3263614c7b20642ebf
--
You are receiving this mail because:
You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 popov895 changed: What|Removed |Added CC||popov...@ukr.net -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 Postix changed: What|Removed |Added CC||pos...@posteo.eu -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 phd changed: What|Removed |Added Summary|Clearing clipboard history |Clearing clipboard history |does not clear the |does not clear the |clipboard / Content of |clipboard |clipboard is lost after | |closing application | CC||p...@phd.re Status|REOPENED|ASSIGNED Assignee|plasma-b...@kde.org |p...@phd.re -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard / Content of clipboard is lost after closing application
https://bugs.kde.org/show_bug.cgi?id=409366 --- Comment #7 from ultr --- Fix: https://phabricator.kde.org/D22684 -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard / Content of clipboard is lost after closing application
https://bugs.kde.org/show_bug.cgi?id=409366 ultr changed: What|Removed |Added Version|5.16.2 |5.16.3 --- Comment #6 from ultr --- The original issue still occurs in Plasma 5.16.3. -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard / Content of clipboard is lost after closing application
https://bugs.kde.org/show_bug.cgi?id=409366 --- Comment #5 from ultr --- The original issue was most likely caused by this change: https://github.com/KDE/plasma-workspace/commit/3bd6ac34ed74e3b86bfb6b29818b726baf505f20#diff-4aebb4a49ac5fcac58f31c1db689096e >[Klipper] Always restore the last clipbboard item >Summary: >D19852 intrdouced x-kde-force-image-copy hint for programs to specify that >images should be set to the clipboard even if should not be included in the >history. But when the program was closed the clipboard was restored to the >first >item in history in which the image was not included. To fix this introduce a >new >class member which holds the last clipboard item and restore it. >Credit goes to David Edumndson >Test Plan: >Try it with spectacle It is fine, but simply lacks support for clearing the history for the new m_last variable breaking the previous behavior in this matter. -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard / Content of clipboard is lost after closing application
https://bugs.kde.org/show_bug.cgi?id=409366 ultr changed: What|Removed |Added Summary|Clearing clipboard history |Clearing clipboard history |does not clear the |does not clear the |clipboard |clipboard / Content of ||clipboard is lost after ||closing application -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 ultr changed: What|Removed |Added Ever confirmed|0 |1 Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED --- Comment #4 from ultr --- With "Prevent empty clipboard" option unchecked Klipper fails to work properly. So the original issue still stands (or this is an entirely new problem with Klipper). Issue when "Prevent empty clipboard" option is unchecked: SUMMARY Content of clipboard is lost after closing application. STEPS TO REPRODUCE 0. Uncheck "Prevent empty clipboard" option in Klipper. 1. Open 2 instances of KWrite (or Kate). 2. Input some text into one KWrite window. 3. Copy this text. 4. Close the window (without saving). 5. Try pasting the text into another KWrite window (it won't work). OBSERVED RESULT Cannot paste text copied a moment ago. Plasma's Klipper widget shows the copied text in the history, but it is not in the clipboard (use `xsel -o` to verify this). EXPECTED RESULT Clipboard should contain the copied text. It should not be emptied after closing application window. SOFTWARE/OS VERSIONS KDE Plasma Version: 5.16.2 KDE Frameworks Version: 5.59.0 Qt Version: 5.12.2 -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 ultr changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REPORTED|RESOLVED --- Comment #3 from ultr --- @Kai Uwe Broulik I had this option unchecked. But after: - checking it - pressing Apply - unchecking it - applying the settings again the issue does no longer occur. Weird. Closing the bug. -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 --- Comment #2 from ultr --- Update: It seems to be X11-wide problem. $ xsel -bc should clean the clipboard, but doesn't. A workaround could be to set the clipboard to an empty string: $ true | xclip -selection clipboard and only then clean the Klipper's history. SOFTWARE/OS VERSIONS OS: Ubuntu 19.04 X.Org: 1.20.4 -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 Kai Uwe Broulik changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Kai Uwe Broulik --- Uncheck "Prevent empty clipboard" in settings -- You are receiving this mail because: You are watching all bug changes.
[klipper] [Bug 409366] Clearing clipboard history does not clear the clipboard
https://bugs.kde.org/show_bug.cgi?id=409366 ultr changed: What|Removed |Added CC||u...@ultr.pl -- You are receiving this mail because: You are watching all bug changes.
