[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Koos Vriezen]

https://bugs.kde.org/show_bug.cgi?id=373509

Koos Vriezen  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Giovanni Mariani]

https://bugs.kde.org/show_bug.cgi?id=373509

--- Comment #6 from Giovanni Mariani  ---
(In reply to Koos Vriezen from comment #5)
> No, the first commit changed the `QString::utf8()` to `QString::toUtf8()`,
> the second changed `QTextString::read()` to `QTextStream::readAll()`.
> Could you attach your build output?
Aah... crap.
I made a mess while patching.
Yes: 271ccae67d6efcb574e1791827d61a285b771687 fixes the build for me.
Sorry for the noise...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Koos Vriezen]

https://bugs.kde.org/show_bug.cgi?id=373509

--- Comment #5 from Koos Vriezen  ---
No, the first commit changed the `QString::utf8()` to `QString::toUtf8()`, the
second changed `QTextString::read()` to `QTextStream::readAll()`.
Could you attach your build output?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Giovanni Mariani]

https://bugs.kde.org/show_bug.cgi?id=373509

--- Comment #4 from Giovanni Mariani  ---
(In reply to Koos Vriezen from comment #3)
> Ah yes, follow-up patch at
> https://cgit.kde.org/kmplayer.git/patch/
> ?id=271ccae67d6efcb574e1791827d61a285b771687
> 
> Compiles now?
With the above git commit surely no...
The change is the same as in the second part of
8b5d375c2d9a5c3984d6e6f21a6b8d3e5afa, so it was already applied when I got
the other failure.
AFAICT the issue number two is that the definition of qtextstream from qt5
headers does not match the one used by kmplayerplaylist.cpp at line 22 (in the
log the output is mixed because I'm building with -j4...).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Koos Vriezen]

https://bugs.kde.org/show_bug.cgi?id=373509

--- Comment #3 from Koos Vriezen  ---
Ah yes, follow-up patch at
https://cgit.kde.org/kmplayer.git/patch/?id=271ccae67d6efcb574e1791827d61a285b771687

Compiles now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Giovanni Mariani]

https://bugs.kde.org/show_bug.cgi?id=373509

--- Comment #2 from Giovanni Mariani  ---
(In reply to Koos Vriezen from comment #1)
> Does applying
> https://cgit.kde.org/kmplayer.git/patch/
> ?id=8b5d375c2d9a5c3984d6e6f21a6b8d3e5afa
> then compile?
> I have no idea why it compiled for me, its old qt3 code.
No, it solves only the first issue...
This one is still present:
/tmp/abf/rpmbuild/BUILD/kmplayer-0.12.0b/src/kmplayerplaylist.cpp:1609:34:
error: no matching function for call to 'QTextStream::read()'
...
/usr/include/qt5/QtCore/qtextstream.h:129:13: note:   candidate expects 1
argument, 0 provided

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmplayer] [Bug 373509] Error building kmplayer 0.12.0b: 'class QString' has no member named 'utf8'

[Koos Vriezen]

https://bugs.kde.org/show_bug.cgi?id=373509

Koos Vriezen  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #1 from Koos Vriezen  ---
Does applying
https://cgit.kde.org/kmplayer.git/patch/?id=8b5d375c2d9a5c3984d6e6f21a6b8d3e5afa
then compile?
I have no idea why it compiled for me, its old qt3 code.

-- 
You are receiving this mail because:
You are watching all bug changes.