[kmymoney] [Bug 420056] BUY/SELL information ignored when importing OFX investment transactions

2020-06-13 Thread Dawid Wróbel
https://bugs.kde.org/show_bug.cgi?id=420056

Dawid Wróbel  changed:

   What|Removed |Added

   Version Fixed In||5.1.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 420056] BUY/SELL information ignored when importing OFX investment transactions

2020-04-16 Thread Dawid Wróbel
https://bugs.kde.org/show_bug.cgi?id=420056

Dawid Wróbel  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kmy |https://commits.kde.org/kmy
   |money/8bd68cd8a2e0ebadedc04 |money/50da0c1ac7d911c024e8d
   |ff665d6704d6395d8a0 |4b1b9cd0a925aba858f

--- Comment #4 from Dawid Wróbel  ---
Git commit 50da0c1ac7d911c024e8d4b1b9cd0a925aba858f by Dawid Wróbel.
Committed on 17/04/2020 at 00:00.
Pushed by wrobelda into branch 'master'.

Add option to enable fixing of the buy/sell signs

Some providers do not follow the OFX spec and do not assign the correct
positive/negative signage to amount (TOTALs) and quantity (UNITs)
values assosciated with BUY/SELL investment transactions (see OFX2.2,
section 13.3.3). This change adds option to OFX import dialog and
account's online settings to force the signage to follow the the spec.
GUI:

M  +1-0kmymoney/plugins/ofx/import/dialogs/konlinebankingstatus.cpp
M  +19   -2kmymoney/plugins/ofx/import/dialogs/konlinebankingstatusdecl.ui
M  +18   -1kmymoney/plugins/ofx/import/importoption.ui
M  +96   -74   kmymoney/plugins/ofx/import/ofximporter.cpp

https://commits.kde.org/kmymoney/50da0c1ac7d911c024e8d4b1b9cd0a925aba858f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 420056] BUY/SELL information ignored when importing OFX investment transactions

2020-04-15 Thread Dawid Wróbel
https://bugs.kde.org/show_bug.cgi?id=420056

Dawid Wróbel  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/kmy
   ||money/8bd68cd8a2e0ebadedc04
   ||ff665d6704d6395d8a0
 Resolution|--- |FIXED

--- Comment #3 from Dawid Wróbel  ---
Git commit 8bd68cd8a2e0ebadedc04ff665d6704d6395d8a0 by Dawid Wróbel.
Committed on 15/04/2020 at 22:54.
Pushed by wrobelda into branch 'bug-420056'.

Add option to enable fixing of the buy/sell signs

Some providers do not follow the OFX spec and do not assign the correct
positive/negative signage to amount (TOTALs) and quantity (UNITs)
values assosciated with BUY/SELL investment transactions (see OFX2.2,
section 13.3.3). This change adds option to OFX import dialog and
account's online settings to force the signage to follow the the spec.
GUI:

M  +1-0kmymoney/plugins/ofx/import/dialogs/konlinebankingstatus.cpp
M  +19   -2kmymoney/plugins/ofx/import/dialogs/konlinebankingstatusdecl.ui
M  +18   -1kmymoney/plugins/ofx/import/importoption.ui
M  +96   -74   kmymoney/plugins/ofx/import/ofximporter.cpp

https://commits.kde.org/kmymoney/8bd68cd8a2e0ebadedc04ff665d6704d6395d8a0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 420056] BUY/SELL information ignored when importing OFX investment transactions

2020-04-14 Thread Dawid Wróbel
https://bugs.kde.org/show_bug.cgi?id=420056

--- Comment #2 from Dawid Wróbel  ---
Jack, look like you're right. Per OFX 2.2 spec
(https://www.ofx.net/downloads/OFX%202.2.pdf), section 13.3.3:

"In a transaction, the signage of UNITS and TOTALs is determined by the
transaction's effect on the underlying cash balance (an investment sell would
contain a positive TOTAL and negative UNITS whereas an investment buy would
contain a negative TOTAL and positive UNITS)."

All of the UNITs and TOTALs in the file provided by my Fidelity 401k brokerage
account are positive.

However, I did check with Moneydance and they import these transactions
properly.

I'll check with aqbanking and report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 420056] BUY/SELL information ignored when importing OFX investment transactions

2020-04-14 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=420056

--- Comment #1 from Jack  ---
I've been importing with OFX direct for years, from at least two institutions,
and I have not seen this.  (Merrill Lynch has big problems with divident
reinvestments, but that's a separate issue.)  My guess is it is some oddity in
how your brokerage prepares the OFX.  They probably have both buy and sell
transactions, but both using positive amounts for the funds.  I can't speak
easily to the internals, but as I remember QIF import is done entirely within
KMM, but the OFX is done using libOFX.  As one test, you might configure the
aqbanking ofx importer and see if it does the same thing as libOFX.  If it
does, then the problem is probably within the OFX you are importing.  You can
also just look in the OFX statement itself.  Unfortunately, if my guess is
correct, I'm not sure to deal with it, other than perhaps making the assumption
that all buy transactions should use a negative cash amount (assuming I've got
it right and it's not the other way around.)

-- 
You are receiving this mail because:
You are watching all bug changes.