[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-07-01 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=486876

Thomas Baumgart  changed:

   What|Removed |Added

   Version Fixed In||5.2
  Latest Commit||https://invent.kde.org/offi
   ||ce/kmymoney/-/commit/626568
   ||12e66c750e018f22a5c6fcbfa54
   ||021df18
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Thomas Baumgart  ---
Git commit 62656812e66c750e018f22a5c6fcbfa54021df18 by Thomas Baumgart.
Committed on 01/07/2024 at 19:35.
Pushed by tbaumgart into branch 'master'.

Show liabilities/equities as positive numbers

A liability is usually a negative amount in terms of networth. Showing
the liabilities with a negative sign is confusing for users, though.

This change takes care of this and displays liabilites that are still
due as positive numbers and overpaid liablities as negative on the
homepage's asset and liability section, the account balance chart and
the ledger balance.
FIXED-IN: 5.2

M  +20   -0kmymoney/mymoney/mymoneyaccount.cpp
M  +6-2kmymoney/mymoney/mymoneyaccount.h
M  +37   -0kmymoney/mymoney/tests/mymoneyaccount-test.cpp
M  +2-0kmymoney/mymoney/tests/mymoneyaccount-test.h
M  +24   -8kmymoney/plugins/views/reports/core/kreportchartview.cpp
M  +4-1kmymoney/plugins/views/reports/kbalancechartdlg.cpp
M  +9-5kmymoney/views/khomeview_p.h
M  +2-0kmymoney/views/ledgerviewpage.cpp
M  +5-3kmymoney/views/ledgerviewpage_p.h

https://invent.kde.org/office/kmymoney/-/commit/62656812e66c750e018f22a5c6fcbfa54021df18

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-06-15 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=486876

Jack  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #6 from Jack  ---
Converting to wishlist per Comment #5.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-05-12 Thread jesse
https://bugs.kde.org/show_bug.cgi?id=486876

--- Comment #5 from jesse  ---
(In reply to Thomas Baumgart from comment #4)
> KMyMoney normally works with the "Credit account" option (displays a
> positive balance for account types that would normally carry a credit
> balance (income, credit, liability, equity)). It just does not do it for the
> graph representation of the balance chart, though.

Would it be possible for the wish list item to be request the Balance chart to
also follow the same?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-05-11 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=486876

--- Comment #4 from Thomas Baumgart  ---
KMyMoney normally works with the "Credit account" option (displays a positive
balance for account types that would normally carry a credit balance (income,
credit, liability, equity)). It just does not do it for the graph
representation of the balance chart, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-05-11 Thread Mark Penner
https://bugs.kde.org/show_bug.cgi?id=486876

Mark Penner  changed:

   What|Removed |Added

 CC||mrpen...@mailbox.org

--- Comment #3 from Mark Penner  ---
Not sure if this is useful to compare, but Gnucash has three settings for which
accounts to reverse the balance on: Income & Expense, Credit accounts, None.
https://gnucash.org/docs/v5/C/gnucash-manual/set-prefs.html#prefs-accounts
I find I can get used to any of methods. (I suppose the traditional way would
be to use all positive numbers and mark them credit or debit, but that's not
very beginner friendly)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-05-11 Thread jesse
https://bugs.kde.org/show_bug.cgi?id=486876

--- Comment #2 from jesse  ---
(In reply to Jack from comment #1)
> As far as I can tell, this is all by design. I also think it has been
> discussed in the past, but I can't find any references at the moment.  
> First, it is not reasonable to use absolute values for these charts, since
> any account can be above or below zero.  An asset account can be over-drawn,
> and a liability account can be over-paid.  What would the chart look like
> for an over-paid liability of over-drawn asset?
> 
> I think what you could be asking for is that liability accounts show the
> amount owed as positive instead of negative,  but I think you will find as
> many people who want it the way it is.  You can think of your net worth as
> your assets less liabilities (thinking of both as positive amounts, as you
> request) or you can think of net worth as the sum of positive assets plus
> negative liabilities.  I can't make any definitive statement, but I don't
> think this change is likely to happen.  However, I think it could be
> reasonable to change this into a wishlist to add a toggle to the
> configuration that asks the balance charts of liability accounts to be shown
> "upside down."  (This could conceivably be done with or without actually
> flipping the sign of the values.)
> 
> In any case, I'll look through the handbook and see if I can improve the
> discussion to make this issue more obvious.  We can also think about adding
> a tool or note to balance charts for liability accounts pointing out that
> the liability, or amount you owe, is shown as a negative number.

Thanks Jack. 
Yes, you are correct about absolute values not being valid here. 

I figured there may be people, and as you said, maybe equal number of people
that like it the way it is. 

If that is the case, no worries. I agree with you on the two ways to look at
same situation. 

I also agree that updating the handbook or adding a tool tip would be nice. I
know that in the normal reports, there is a checkbox to ask whether we want to
see the expenses charted as negative numbers. Perhaps something similar to that
could be added.  Personally, I like all numbers to be charted as positive
values. That is just my preference. 

I can live with the current set up though. I know the new ledger is a huge
focus right now and this was more meant as a back burner item  for when there
is more time to reflect. 

You are correct, maybe it is more of a wish list item. I would be cool with
that. 

Thanks again!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney] [Bug 486876] Show balance button on Ledger view is negative

2024-05-11 Thread Jack
https://bugs.kde.org/show_bug.cgi?id=486876

Jack  changed:

   What|Removed |Added

 CC||ostroffjh@users.sourceforge
   ||.net

--- Comment #1 from Jack  ---
As far as I can tell, this is all by design. I also think it has been discussed
in the past, but I can't find any references at the moment.  
First, it is not reasonable to use absolute values for these charts, since any
account can be above or below zero.  An asset account can be over-drawn, and a
liability account can be over-paid.  What would the chart look like for an
over-paid liability of over-drawn asset?

I think what you could be asking for is that liability accounts show the amount
owed as positive instead of negative,  but I think you will find as many people
who want it the way it is.  You can think of your net worth as your assets less
liabilities (thinking of both as positive amounts, as you request) or you can
think of net worth as the sum of positive assets plus negative liabilities.  I
can't make any definitive statement, but I don't think this change is likely to
happen.  However, I think it could be reasonable to change this into a wishlist
to add a toggle to the configuration that asks the balance charts of liability
accounts to be shown "upside down."  (This could conceivably be done with or
without actually flipping the sign of the values.)

In any case, I'll look through the handbook and see if I can improve the
discussion to make this issue more obvious.  We can also think about adding a
tool or note to balance charts for liability accounts pointing out that the
liability, or amount you owe, is shown as a negative number.

-- 
You are receiving this mail because:
You are watching all bug changes.