[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=360500

Ralf Habacker  changed:

   What|Removed |Added

  Latest Commit|dc5109988fbf1f732525e6a6ec1 |https://commits.kde.org/kmy
   |93903b472b632   |money/93a2561fa072517874ae0
   ||1e986fcb79f8f94578a
 Status|CONFIRMED   |RESOLVED
   Version Fixed In|4.8 |4.8.1
 Resolution|--- |FIXED

--- Comment #9 from Ralf Habacker  ---
Git commit 93a2561fa072517874ae01e986fcb79f8f94578a by Ralf Habacker.
Committed on 06/09/2017 at 11:39.
Pushed by habacker into branch '4.8'.

Add system wide checkbox 'Do not show this again' for duplicated check number
request dialog

Includes QString -> QLatin1String refactoring as requested by Th. Baumgart.

FIXED-IN:4.8.1
REVIEW:130241

M  +6-2kmymoney/dialogs/transactioneditor.cpp

https://commits.kde.org/kmymoney/93a2561fa072517874ae01e986fcb79f8f94578a

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=360500

--- Comment #8 from Ralf Habacker  ---
(In reply to Jack from comment #7)
> Could there be a "do not show this again" at least system-wide
see here https://git.reviewboard.kde.org/r/130241/
> but perhaps per account?
not thought about how to implement yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[Jack]

https://bugs.kde.org/show_bug.cgi?id=360500

--- Comment #7 from Jack  ---
I've been thinking about this, and while I agree the use case for being able to
enter the same number more than once is valid, I don't want to lose the
original use case, which is to prevent duplicate entries.  I wonder if I should
post a separate wish list to make this configurable per account.  That way, I
can assure unique check numbers in a real checking account, but allow
duplicates in other accounts.  The dialog which requires confirmation is sort
of an interim step - at least the user knows the number is duplicate.  Could
there be a "do not show this again" at least system-wide, but perhaps per
account?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=360500

--- Comment #6 from Ralf Habacker  ---
Git commit 14d8784800c2da4d44232fa2f8de2211a45e996e by Ralf Habacker, on behalf
of Allan Anderson.
Committed on 01/09/2017 at 20:47.
Pushed by habacker into branch '4.8'.

M  +2-2kmymoney/dialogs/transactioneditor.cpp

https://commits.kde.org/kmymoney/14d8784800c2da4d44232fa2f8de2211a45e996e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=360500

Ralf Habacker  changed:

   What|Removed |Added

 CC||ralf.habac...@freenet.de

--- Comment #5 from Ralf Habacker  ---
Not been able to enter the same number more than one time is annoying because
it prevents to assign the number of a bank statement to the related transaction
for later identification. 

BTW: Tried this patch on git 4.8 branch: it works, but there is still a dialog
coming up each time which needs to be confirmed each time in case the same
number is entered again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[allan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360500

--- Comment #4 from allan  ---
On 14/03/16 18:45, Christian David via KDE Bugzilla wrote:
> https://bugs.kde.org/show_bug.cgi?id=360500
>
> Christian David  changed:
>
> What|Removed |Added
> 
>   CC||christian-da...@web.de
>
> --- Comment #3 from Christian David  ---
> In void TransactionEditor::slotNumberChanged(const QString& txt):
>
> Why do you use loadText() and not setText() in you patch?

There are two separate routines involved, and one was using loadText() 
and the other setText(). I couldn't see any reason for the difference, 
and just decided to use loadText().

> However, the loadText() seems unnecessary to me.

In the routine you refer to, then, yes, it does seem unnecessary, but 
not so in void TransactionEditor::assignNextNumber().  The first one 
there is necessary.

Allan

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[Christian David via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360500

Christian David  changed:

   What|Removed |Added

 CC||christian-da...@web.de

--- Comment #3 from Christian David  ---
In void TransactionEditor::slotNumberChanged(const QString& txt): 

Why do you use loadText() and not setText() in you patch?
However, the loadText() seems unnecessary to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[allan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360500

allan  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
   Version Fixed In||4.8
  Latest Commit||dc5109988fbf1f732525e6a6ec1
   ||93903b472b632

--- Comment #2 from allan  ---
I think the intention in clearing the cell contents may have been to assist the
user to enter the required value, perhaps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 360500] Unable to enter the same value in the No. field for more than 1 transaction.

[allan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=360500

--- Comment #1 from allan  ---
Created attachment 97898
  --> https://bugs.kde.org/attachment.cgi?id=97898=edit
Fix for bug 306500

This is a trivial patch, and with developer time being scarce, I see no point
in going via reviewboard.
Unless I hear to the contrary, I propose to push it in about a week, in order
to, hopefully, make it into rev 4.8.

-- 
You are receiving this mail because:
You are watching all bug changes.