[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-08-14 Thread Thomas Baumgart via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615

Thomas Baumgart  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/c0f003134059354e2bc2b1 |oney/20191b3d1b662cd8e0d577
   |9ffa1b3ca7a98cbb19  |5799ff51a39cd68e47
   Version Fixed In|5.0 |4.8.1

--- Comment #5 from Thomas Baumgart  ---
Git commit 20191b3d1b662cd8e0d5775799ff51a39cd68e47 by Thomas Baumgart.
Committed on 14/08/2016 at 10:16.
Pushed by tbaumgart into branch '4.8'.

Renamed SQL column "order" to "userOrder" in some tables

The name "order" is a reserved keyword. It can be used as identifier
but only if it is escaped. Unfortunately the escape sequence is database
dependent. Added upgrade feature to convert database on open.

Accomplished compatability with DB layout version 10 as used in master.

This has yet been tested against SQLite but not MySQL.
FIXED-IN: 4.8.1

M  +1-1kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp
M  +20   -6kmymoney/mymoney/storage/mymoneydbdef.cpp
M  +13   -4kmymoney/mymoney/storage/mymoneydbdef.h
M  +47   -7kmymoney/mymoney/storage/mymoneystoragesql.cpp
M  +2-0kmymoney/mymoney/storage/mymoneystoragesql.h

http://commits.kde.org/kmymoney/20191b3d1b662cd8e0d5775799ff51a39cd68e47

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-07-31 Thread Christian David via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615

Christian David  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kmym
   ||oney/c0f003134059354e2bc2b1
   ||9ffa1b3ca7a98cbb19
   Version Fixed In||5.0
 Status|CONFIRMED   |RESOLVED

--- Comment #4 from Christian David  ---
Git commit c0f003134059354e2bc2b19ffa1b3ca7a98cbb19 by Christian Dávid.
Committed on 31/07/2016 at 19:31.
Pushed by christiand into branch 'master'.

Renamed SQL column "order" to "userOrder" in some tables

The name "order" is a reserved keyword. It can be used as identifier but
only if it is escaped. Unfortunately the escape sequence is database
dependent.

This patch is untested as another bug prevents me from opening a
database. Scince this fix is kind of urgent, I publish it anyway. The
port to 4.8 should be straight forward.
FIXED-IN: 5.0

M  +3-3kmymoney/mymoney/storage/mymoneydbdef.cpp
M  +3-3kmymoney/mymoney/storage/mymoneystoragesql.cpp

http://commits.kde.org/kmymoney/c0f003134059354e2bc2b19ffa1b3ca7a98cbb19

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-07-31 Thread Christian David via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615

Christian David  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #3 from Christian David  ---
This bug is caused by mymoneydbdef.cpp, line 221. There I used “order” as
column name. This is okay if the identifier is quoted. Unfortunately the way of
quoting it is different between the databases (e.g.
https://www.postgresql.org/docs/7.3/static/sql-syntax.html#SQL-SYNTAX-IDENTIFIERS
vs https://dev.mysql.com/doc/refman/5.7/en/identifiers.html). I did not know
that :(

It should be safe to rename the identifier as we do not really use it, yet.
Alternatively we could adopt our query creator to this. However, I think this
is too much work for a minor benefit.

There is another case of this issue in line 162. If someone is working an this
bug, please assign it to yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-07-28 Thread James Zhixin Zhang via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615

James Zhixin Zhang  changed:

   What|Removed |Added

 CC||reachja...@reachjames.net

--- Comment #1 from James Zhixin Zhang  ---
This bug is also found in KMyMoney 4.8 for Windows (the same error message).
The SQL Server I am using is MySQL 5.7.11. Previously it worked perfectly well
in KMyMoney 4.7.2.

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-07-27 Thread Thomas Baumgart via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615

Thomas Baumgart  changed:

   What|Removed |Added

 CC||art2cr...@gmail.com

--- Comment #2 from Thomas Baumgart  ---
*** Bug 366132 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.


[kmymoney4] [Bug 365615] SQL syntax error reported opening MySQL database

2016-07-27 Thread Thomas Baumgart via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365615

Thomas Baumgart  changed:

   What|Removed |Added

 CC||christian-da...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.