[knetwalk] [Bug 292032] KNetWalk 3.0.1 potential integer overflow, score cheat and division by zero crash

2018-11-10 Thread Jaak Ristioja
https://bugs.kde.org/show_bug.cgi?id=292032

--- Comment #6 from Jaak Ristioja  ---
(In reply to Albert Astals Cid from comment #5)
> Because it's a waste of everyones time. Let's say you can click ten times
> per second, you need to be clicking at that rate during 7 years to make the
> counter wrap.

Alrighty. But how about the division-by-zero in the same place if one solves an
Easy (5x5) board in before the first second elapses (given one can also pause
the game)? It only seems to take 20 clicks or so. :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 292032] KNetWalk 3.0.1 potential integer overflow, score cheat and division by zero crash

2018-11-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=292032

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 Status|REPORTED|RESOLVED

--- Comment #5 from Albert Astals Cid  ---
Because it's a waste of everyones time. Let's say you can click ten times per
second, you need to be clicking at that rate during 7 years to make the counter
wrap.

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 292032] KNetWalk 3.0.1 potential integer overflow, score cheat and division by zero crash

2018-11-10 Thread Jaak Ristioja
https://bugs.kde.org/show_bug.cgi?id=292032

Jaak Ristioja  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
 Resolution|NOT A BUG   |---

--- Comment #4 from Jaak Ristioja  ---
I agree, but if you continue clicking, and then it eventually wraps from
negative to positive again, which might yield in positive scores.

So if the program survives the undefined behavior of the integer overflow, it
is followed by ever more undefined behavior in MainWindow::gameOver(), e.g.
-NaN not being in the range of representative values values for int, and a
division by zero. :)

Why not just add guard to keep the overflow from happening and call it "game
over: too many moves"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 292032] KNetWalk 3.0.1 potential integer overflow, score cheat and division by zero crash

2018-11-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=292032

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED
 CC||aa...@kde.org

--- Comment #3 from Albert Astals Cid  ---
If you did so many clicks that you got m_clickCount to wrap and then go back to
-2, your score will be -2147483648 (i just faked the to make m_clickCount be
-2, didn't click so many times).

-2147483648 seems an accurate very low score for clicking so many times.

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 292032] KNetWalk 3.0.1 potential integer overflow, score cheat and division by zero crash

2018-11-09 Thread Jaak Ristioja
https://bugs.kde.org/show_bug.cgi?id=292032

Jaak Ristioja  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #2 from Jaak Ristioja  ---
Yes, the bug still seems to be there:

https://cgit.kde.org/knetwalk.git/tree/src/mainwindow.cpp#n271

Although commit abe2f6ab1fb3c60d45cc8a2ce8d108ef2ae6cef5 changed the method
name to rotationStarted() instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 292032] KNetWalk 3.0.1 potential integer overflow, score cheat and division by zero crash

2018-11-06 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=292032

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Andrew Crouthamel  ---
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test
if the bug is valid in the latest version? I am setting the status to NEEDSINFO
pending your response, please change the Status back to REPORTED when you
respond.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.