[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Max]

https://bugs.kde.org/show_bug.cgi?id=348686

--- Comment #12 from Max  ---
(In reply to Richard Hebert from comment #11)
> bug reappeared in 3.3.0 Using:
> KDE Frameworks 5.18.0
> Qt 5.5.1 (built against 5.5.1)
> The xcb windowing system
> 
> exactly the same issue. used to work fine .. now when you connect or
> disconnect a terminal it dont show the color change in the terminal.
> reinstalled .. same issue. 
> 
> steps to reproduce : 1) start game 
>  2) flip in out , color stays black

Works fine here

KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.13.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Richard Hebert]

https://bugs.kde.org/show_bug.cgi?id=348686

Richard Hebert  changed:

   What|Removed |Added

 CC||fuzzytheb...@gmail.com

--- Comment #11 from Richard Hebert  ---
bug reappeared in 3.3.0 Using:
KDE Frameworks 5.18.0
Qt 5.5.1 (built against 5.5.1)
The xcb windowing system

exactly the same issue. used to work fine .. now when you connect or disconnect
a terminal it dont show the color change in the terminal. reinstalled .. same
issue. 

steps to reproduce : 1) start game 
 2) flip in out , color stays black

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=348686

Albert Astals Cid  changed:

   What|Removed |Added

 CC||giorgos...@gmail.com

--- Comment #10 from Albert Astals Cid  ---
*** Bug 399877 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=348686

Albert Astals Cid  changed:

   What|Removed |Added

 CC||karak...@gmail.com

--- Comment #9 from Albert Astals Cid  ---
*** Bug 389399 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=348686

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kne
   ||twalk/6c6d71ad0822bf6b48e1c
   ||84a790ac1106e0af88b
 Resolution|--- |FIXED

--- Comment #8 from Albert Astals Cid  ---
Git commit 6c6d71ad0822bf6b48e1c84a790ac1106e0af88b by Albert Astals Cid, on
behalf of Hatto von Hatzfeld.
Committed on 03/01/2017 at 22:52.
Pushed by aacid into branch 'Applications/16.12'.

Fix network nodes not getting updated

M  +3-0src/qml/logic.js

https://commits.kde.org/knetwalk/6c6d71ad0822bf6b48e1c84a790ac1106e0af88b

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=348686

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Max]

https://bugs.kde.org/show_bug.cgi?id=348686

--- Comment #7 from Max  ---
It works great! Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Hatto Von Hatzfeld]

https://bugs.kde.org/show_bug.cgi?id=348686

Hatto Von Hatzfeld  changed:

   What|Removed |Added

 Attachment #103145|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Hatto Von Hatzfeld]

https://bugs.kde.org/show_bug.cgi?id=348686

--- Comment #6 from Hatto Von Hatzfeld  ---
Created attachment 103149
  --> https://bugs.kde.org/attachment.cgi?id=103149=edit
improved version file qml/logic.js

Substituting the file logic.js (in my case located in /usr/share/knetwalk/qml/)
solves this bug. This is an improved version which avoids to create unnecessary
new nodes (and memory leaks).

No new compiling needed, so this can be done even by beginners.

Should work in versions at least from 15.04 to 16.12, probably more.

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Max]

https://bugs.kde.org/show_bug.cgi?id=348686

--- Comment #5 from Max  ---
This fix works, thank you. Not sure however, it may create a memory leak. May
be destroy previous object too? It requires to store object links somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Hatto Von Hatzfeld]

https://bugs.kde.org/show_bug.cgi?id=348686

--- Comment #4 from Hatto Von Hatzfeld  ---
Created attachment 103145
  --> https://bugs.kde.org/attachment.cgi?id=103145=edit
new version file qml/logic.js

Substituting the file logic.js (in my case located in /usr/share/knetwalk/qml/)
solves this bug. There's just one line which has been added.

No new compiling needed, so this can be done even by beginners.

Should work in versions at least from 15.04 to 16.12, probably more.

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Hatto Von Hatzfeld]

https://bugs.kde.org/show_bug.cgi?id=348686

Hatto Von Hatzfeld  changed:

   What|Removed |Added

 CC||ha...@salesianer.de

--- Comment #3 from Hatto Von Hatzfeld  ---
Created attachment 102728
  --> https://bugs.kde.org/attachment.cgi?id=102728=edit
Screenshot showing the bug

I can confirm this bug. Neither connecting nor disconnecting a node causes the
node icon to change. In former versions (KDE 4) this used to work.

KDE Frameworks 5.21.0
Qt 5.5.1 (kompiliert gegen 5.5.1)
Das xcb Fenstersystem

Repository: KDE 5 Applications
Name: knetwalk
Version: 16.11.90-2.6
Arch: x86_64
Vendor: obs://build.opensuse.org/KDE

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=348686

thesir...@gmail.com changed:

   What|Removed |Added

 CC||thesir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[dmatt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=348686

dmatt  changed:

   What|Removed |Added

 CC||xdarkmat...@gmail.com

--- Comment #2 from dmatt  ---
I confirm this bug is also present in knetwalk on Kubuntu 16.04. Sound of
turning on/off is present, icon does not update.

Version 3.3.0
Using:
KDE Frameworks 5.18.0
Qt 5.5.1 (built against 5.5.1)
The xcb windowing system

-- 
You are receiving this mail because:
You are watching all bug changes.

[knetwalk] [Bug 348686] knetwalk 3.3.0 does not update network node icons

[Stefan Hinz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=348686

Stefan Hinz  changed:

   What|Removed |Added

 CC||ste...@stefanhinz.org

--- Comment #1 from Stefan Hinz  ---
Note that this is new as of KDE 5 (at least for me it is). In KDE 4, those
KNetWalk monitors would turn on properly when connected to the server.

-- 
You are receiving this mail because:
You are watching all bug changes.