[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #6 from Antonio Russo --- Created attachment 99927 --> https://bugs.kde.org/attachment.cgi?id=99927&action=edit Revised complete patchset tar.gz of 6 patches -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #7 from Antonio Russo --- The revised patchset has support for all default color schemes. There should be no issues using these color schemes. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org --- Comment #8 from Martin Sandsmark --- Hi! https://git.reviewboard.kde.org/dashboard/ is the preferred method of submitting patches for Konsole. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #9 from Martin Sandsmark --- The patches works for me, I get the correct strikethrough/overline, and the last one is invisible. The first one is with the normal color, the three remaining are in the faint color defined in the color scheme. However it seems like neither urxvt nor uxterm here handles it correctly. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #10 from Antonio Russo --- I am glad that the patch works for others. Sorry if this is turning into spam. I made a review request https://git.reviewboard.kde.org/r/128390/ but since I have a series of patches that depend on the previous one, I was not sure how to upload the sequence without squashing all the commits. What should I now do? Wait for someone to review my draft proposal? Thanks, Antonio -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #11 from Martin Sandsmark --- Reviewboard isn't very good with series of patches, though you can mark patches as dependent on others I haven't really figured out the details. FWIW I don't seem to have access to that review request, but I guess hindenburg has? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #12 from Antonio Russo --- I really appreciate your getting back to me. Thank you. I cannot "publish" the patch without it having a "review"---and I don't think I am allowed to review it myself (?). The first step in the patch creation process required uploading a diff---which for subsequent patches is rejected because the parent revision is not yet known to reviewboard (or, it was not properly detected). I think. Hindenburg glanced at this bug a couple months ago. Could you possibly contact him, or should I maybe ping him directly? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #13 from Martin Sandsmark --- He is very active reviewing patches, he'll probably get to this very soon. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kons ||ole/84b43dfb2108eab47fa1dfc ||afbf1b94a410d6cbf --- Comment #14 from Kurt Hindenburg --- Git commit 84b43dfb2108eab47fa1dfcafbf1b94a410d6cbf by Kurt Hindenburg. Committed on 16/07/2016 at 16:34. Pushed by hindenburg into branch 'master'. Add rendition flags SGRs 2, 8, 9, 53 Adds faint intensity, strikeout, conceal and overline support. echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD' Thanks to Antonio Russo antonio e russo gmail com for patch REVIEW: 128405 M +30 -0data/color-schemes/BlackOnLightYellow.colorscheme M +30 -0data/color-schemes/BlackOnRandomLight.colorscheme M +30 -0data/color-schemes/BlackOnWhite.colorscheme M +30 -0data/color-schemes/BlueOnBlack.colorscheme M +30 -0data/color-schemes/Breeze.colorscheme M +30 -0data/color-schemes/DarkPastels.colorscheme M +30 -0data/color-schemes/GreenOnBlack.colorscheme M +30 -0data/color-schemes/Linux.colorscheme M +30 -0data/color-schemes/RedOnBlack.colorscheme M +30 -0data/color-schemes/Solarized.colorscheme M +30 -0data/color-schemes/SolarizedLight.colorscheme M +30 -0data/color-schemes/WhiteOnBlack.colorscheme M +16 -11 src/Character.h M +22 -4src/CharacterColor.h M +40 -3src/ColorScheme.cpp M +19 -5src/ColorSchemeEditor.cpp M +1-1src/History.h M +25 -33 src/Screen.cpp M +6-5src/Screen.h M +1-1src/TerminalCharacterDecoder.h M +13 -3src/TerminalDisplay.cpp M +10 -1src/Vt102Emulation.cpp M +13 -1src/autotests/CharacterColorTest.cpp http://commits.kde.org/konsole/84b43dfb2108eab47fa1dfcafbf1b94a410d6cbf -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Latest Commit|http://commits.kde.org/kons |http://commits.kde.org/kons |ole/84b43dfb2108eab47fa1dfc |ole/c8da8f3b4745c9bd7ef2489 |afbf1b94a410d6cbf |0a15457342d2ed860 --- Comment #15 from Kurt Hindenburg --- Git commit c8da8f3b4745c9bd7ef24890a15457342d2ed860 by Kurt Hindenburg. Committed on 16/07/2016 at 17:40. Pushed by hindenburg into branch 'Applications/16.08'. Add rendition flags SGRs 2, 8, 9, 53 Adds faint intensity, strikeout, conceal and overline support. echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD' Thanks to Antonio Russo antonio e russo gmail com for patch REVIEW: 128405 (cherry picked from commit 84b43dfb2108eab47fa1dfcafbf1b94a410d6cbf) M +30 -0data/color-schemes/BlackOnLightYellow.colorscheme M +30 -0data/color-schemes/BlackOnRandomLight.colorscheme M +30 -0data/color-schemes/BlackOnWhite.colorscheme M +30 -0data/color-schemes/BlueOnBlack.colorscheme M +30 -0data/color-schemes/Breeze.colorscheme M +30 -0data/color-schemes/DarkPastels.colorscheme M +30 -0data/color-schemes/GreenOnBlack.colorscheme M +30 -0data/color-schemes/Linux.colorscheme M +30 -0data/color-schemes/RedOnBlack.colorscheme M +30 -0data/color-schemes/Solarized.colorscheme M +30 -0data/color-schemes/SolarizedLight.colorscheme M +30 -0data/color-schemes/WhiteOnBlack.colorscheme M +16 -11 src/Character.h M +22 -4src/CharacterColor.h M +40 -3src/ColorScheme.cpp M +19 -5src/ColorSchemeEditor.cpp M +1-1src/History.h M +25 -33 src/Screen.cpp M +6-5src/Screen.h M +1-1src/TerminalCharacterDecoder.h M +13 -3src/TerminalDisplay.cpp M +10 -1src/Vt102Emulation.cpp M +13 -1src/autotests/CharacterColorTest.cpp http://commits.kde.org/konsole/c8da8f3b4745c9bd7ef24890a15457342d2ed860 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #2 from Kurt Hindenburg --- What is this attachment? gz or bz2? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #3 from Antonio Russo --- The attachment should be a tar.gz with 7 patches. On my debian machine it extracts with tar -xf . I've been using a version of konsole with these patches applied for about a month now, and haven't hit any bugs. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #4 from Kurt Hindenburg --- Even w/ all the patches, I only get 4 D - does it work for you w/ these patches? What color scheme to you use? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #5 from Antonio Russo --- The patch depends on a color style to implement the "faint" intensities for each color. I did this specifically for Linux.colorscheme (and it should is included in the patch) but did not get around to the other themes. My eye is not particularly suited for aesthetic choices, and the choice of faint colors for the themes is such a choice (in particular the solarized and light themes seemed to require some thought). Assuming this bug gets enough attention to be included, but not enough for other people with better aesthetics than me to work on the themes, I'll hack up some faint colors. I'll point out that the patch also includes in a fully functional (but completely untested) gui for setting the faint color theme---right next to setting the other colors and intense colors. Notwithstanding that, the overline and strikeout font effects should function correctly. Are you seeing those with the patch applied? If not, could you confirm that your terminal font supports overline and strikeout effects? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #1 from Antonio Russo --- Created attachment 98546 --> https://bugs.kde.org/attachment.cgi?id=98546&action=edit SGR Implementation -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #1 from Antonio Russo --- Created attachment 98546 --> https://bugs.kde.org/attachment.cgi?id=98546&action=edit SGR Implementation -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #2 from Kurt Hindenburg --- What is this attachment? gz or bz2? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #3 from Antonio Russo --- The attachment should be a tar.gz with 7 patches. On my debian machine it extracts with tar -xf . I've been using a version of konsole with these patches applied for about a month now, and haven't hit any bugs. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #4 from Kurt Hindenburg --- Even w/ all the patches, I only get 4 D - does it work for you w/ these patches? What color scheme to you use? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #5 from Antonio Russo --- The patch depends on a color style to implement the "faint" intensities for each color. I did this specifically for Linux.colorscheme (and it should is included in the patch) but did not get around to the other themes. My eye is not particularly suited for aesthetic choices, and the choice of faint colors for the themes is such a choice (in particular the solarized and light themes seemed to require some thought). Assuming this bug gets enough attention to be included, but not enough for other people with better aesthetics than me to work on the themes, I'll hack up some faint colors. I'll point out that the patch also includes in a fully functional (but completely untested) gui for setting the faint color theme---right next to setting the other colors and intense colors. Notwithstanding that, the overline and strikeout font effects should function correctly. Are you seeing those with the patch applied? If not, could you confirm that your terminal font supports overline and strikeout effects? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #6 from Antonio Russo --- Created attachment 99927 --> https://bugs.kde.org/attachment.cgi?id=99927&action=edit Revised complete patchset tar.gz of 6 patches -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #7 from Antonio Russo --- The revised patchset has support for all default color schemes. There should be no issues using these color schemes. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Martin Sandsmark changed: What|Removed |Added CC||martin.sandsm...@kde.org --- Comment #8 from Martin Sandsmark --- Hi! https://git.reviewboard.kde.org/dashboard/ is the preferred method of submitting patches for Konsole. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #9 from Martin Sandsmark --- The patches works for me, I get the correct strikethrough/overline, and the last one is invisible. The first one is with the normal color, the three remaining are in the faint color defined in the color scheme. However it seems like neither urxvt nor uxterm here handles it correctly. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #10 from Antonio Russo --- I am glad that the patch works for others. Sorry if this is turning into spam. I made a review request https://git.reviewboard.kde.org/r/128390/ but since I have a series of patches that depend on the previous one, I was not sure how to upload the sequence without squashing all the commits. What should I now do? Wait for someone to review my draft proposal? Thanks, Antonio -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #11 from Martin Sandsmark --- Reviewboard isn't very good with series of patches, though you can mark patches as dependent on others I haven't really figured out the details. FWIW I don't seem to have access to that review request, but I guess hindenburg has? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #12 from Antonio Russo --- I really appreciate your getting back to me. Thank you. I cannot "publish" the patch without it having a "review"---and I don't think I am allowed to review it myself (?). The first step in the patch creation process required uploading a diff---which for subsequent patches is rejected because the parent revision is not yet known to reviewboard (or, it was not properly detected). I think. Hindenburg glanced at this bug a couple months ago. Could you possibly contact him, or should I maybe ping him directly? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #13 from Martin Sandsmark --- He is very active reviewing patches, he'll probably get to this very soon. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kons ||ole/84b43dfb2108eab47fa1dfc ||afbf1b94a410d6cbf --- Comment #14 from Kurt Hindenburg --- Git commit 84b43dfb2108eab47fa1dfcafbf1b94a410d6cbf by Kurt Hindenburg. Committed on 16/07/2016 at 16:34. Pushed by hindenburg into branch 'master'. Add rendition flags SGRs 2, 8, 9, 53 Adds faint intensity, strikeout, conceal and overline support. echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD' Thanks to Antonio Russo antonio e russo gmail com for patch REVIEW: 128405 M +30 -0data/color-schemes/BlackOnLightYellow.colorscheme M +30 -0data/color-schemes/BlackOnRandomLight.colorscheme M +30 -0data/color-schemes/BlackOnWhite.colorscheme M +30 -0data/color-schemes/BlueOnBlack.colorscheme M +30 -0data/color-schemes/Breeze.colorscheme M +30 -0data/color-schemes/DarkPastels.colorscheme M +30 -0data/color-schemes/GreenOnBlack.colorscheme M +30 -0data/color-schemes/Linux.colorscheme M +30 -0data/color-schemes/RedOnBlack.colorscheme M +30 -0data/color-schemes/Solarized.colorscheme M +30 -0data/color-schemes/SolarizedLight.colorscheme M +30 -0data/color-schemes/WhiteOnBlack.colorscheme M +16 -11 src/Character.h M +22 -4src/CharacterColor.h M +40 -3src/ColorScheme.cpp M +19 -5src/ColorSchemeEditor.cpp M +1-1src/History.h M +25 -33 src/Screen.cpp M +6-5src/Screen.h M +1-1src/TerminalCharacterDecoder.h M +13 -3src/TerminalDisplay.cpp M +10 -1src/Vt102Emulation.cpp M +13 -1src/autotests/CharacterColorTest.cpp http://commits.kde.org/konsole/84b43dfb2108eab47fa1dfcafbf1b94a410d6cbf -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)
https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Latest Commit|http://commits.kde.org/kons |http://commits.kde.org/kons |ole/84b43dfb2108eab47fa1dfc |ole/c8da8f3b4745c9bd7ef2489 |afbf1b94a410d6cbf |0a15457342d2ed860 --- Comment #15 from Kurt Hindenburg --- Git commit c8da8f3b4745c9bd7ef24890a15457342d2ed860 by Kurt Hindenburg. Committed on 16/07/2016 at 17:40. Pushed by hindenburg into branch 'Applications/16.08'. Add rendition flags SGRs 2, 8, 9, 53 Adds faint intensity, strikeout, conceal and overline support. echo -e 'D\e[2mD\e[9mD\e[53mD\e[8mD' Thanks to Antonio Russo antonio e russo gmail com for patch REVIEW: 128405 (cherry picked from commit 84b43dfb2108eab47fa1dfcafbf1b94a410d6cbf) M +30 -0data/color-schemes/BlackOnLightYellow.colorscheme M +30 -0data/color-schemes/BlackOnRandomLight.colorscheme M +30 -0data/color-schemes/BlackOnWhite.colorscheme M +30 -0data/color-schemes/BlueOnBlack.colorscheme M +30 -0data/color-schemes/Breeze.colorscheme M +30 -0data/color-schemes/DarkPastels.colorscheme M +30 -0data/color-schemes/GreenOnBlack.colorscheme M +30 -0data/color-schemes/Linux.colorscheme M +30 -0data/color-schemes/RedOnBlack.colorscheme M +30 -0data/color-schemes/Solarized.colorscheme M +30 -0data/color-schemes/SolarizedLight.colorscheme M +30 -0data/color-schemes/WhiteOnBlack.colorscheme M +16 -11 src/Character.h M +22 -4src/CharacterColor.h M +40 -3src/ColorScheme.cpp M +19 -5src/ColorSchemeEditor.cpp M +1-1src/History.h M +25 -33 src/Screen.cpp M +6-5src/Screen.h M +1-1src/TerminalCharacterDecoder.h M +13 -3src/TerminalDisplay.cpp M +10 -1src/Vt102Emulation.cpp M +13 -1src/autotests/CharacterColorTest.cpp http://commits.kde.org/konsole/c8da8f3b4745c9bd7ef24890a15457342d2ed860 -- You are receiving this mail because: You are watching all bug changes.
