[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 --- Comment #9 from Nate Graham --- Ah, I see! -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 --- Comment #8 from Bo Simonsen --- Nate, I am opening a new bug report. The black lines are not related to the bug you mention. The black lines are occuring on scaled displays after the activation of antialiasing. The other HiDPI bug, the lines there are in fact "holes" in the canvas (the line is the same color as the window in the background), could imply some painter calculation are not accurate. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 Nate Graham changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Nate Graham --- I'm not able to see the problem with box characters in your screenshot. If you're referring to the black lines, that's a pre-existing and unrelated fractional scaling bug: https://bugs.kde.org/show_bug.cgi?id=373232 If there's some other issue besides that which I'm not seeing, we still prefer to track fractional scaling issues with separate bugs so please file one instead of re-opening this one. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 --- Comment #6 from Bo Simonsen --- By the way, scaling is 1.5 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 --- Comment #5 from Bo Simonsen --- Created attachment 119548 --> https://bugs.kde.org/attachment.cgi?id=119548=edit screenshot of mc after antialiasing change -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 Bo Simonsen changed: What|Removed |Added Resolution|FIXED |--- CC||b...@geekworld.dk Status|RESOLVED|REOPENED Ever confirmed|0 |1 --- Comment #4 from Bo Simonsen --- Using QPainter::Antialiasing made Konsole behave strange for scaled display, see attached screenshot for "mc". I am running openSUSE LEAP 15.1 where 18.12 has been patched with improvements in rendering of boxes. I tried commenting out paint.setRenderHint(QPainter::Antialiasing, _antialiasText); and that did make mc look normal. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985
Kurt Hindenburg changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED|RESOLVED
Latest Commit||https://commits.kde.org/kon
||sole/ed5fa1f855a05ba82fe4f2
||f6d3ead803aa5eefdb
--- Comment #3 from Kurt Hindenburg ---
Git commit ed5fa1f855a05ba82fe4f2f6d3ead803aa5eefdb by Kurt Hindenburg.
Committed on 06/10/2018 at 16:39.
Pushed by hindenburg into branch 'master'.
Antialias line drawing characters
Summary:
Use antialiasing when drawing unicode box characters to improve the
rendering of rounded corners.
Test Plan:
# Execute `echo -e '\u256d\u256e\n\u2570\u256f'`
# The box should have rounded corners
Before fix:
{F6301318}
After fix:
{F6301319}
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: ngraham, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D15915
M +4-1src/TerminalDisplay.cpp
https://commits.kde.org/konsole/ed5fa1f855a05ba82fe4f2f6d3ead803aa5eefdb
--
You are receiving this mail because:
You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs --- Comment #2 from Christoph Feck --- QPainter::Antialiasing would help. https://cgit.kde.org/konsole.git/tree/src/TerminalDisplay.cpp#n771 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 397985] Round box drawing chars aren't nice
https://bugs.kde.org/show_bug.cgi?id=397985 --- Comment #1 from Egmont Koblinger --- Note that it doesn't get _much_ better at giant font sizes either (and then bug 397986 also becomes relevant). -- You are receiving this mail because: You are watching all bug changes.
