[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 Nate Graham changed: What|Removed |Added Version Fixed In||18.12.1 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://commits.kde.org/kon |https://commits.kde.org/kon |sole/c9276130ac06f052f9251d |sole/b545a812e3bf74157387fd |8d67eaf45ff2f87708 |60b61f6e2146723834 --- Comment #5 from Kurt Hindenburg --- Git commit b545a812e3bf74157387fd60b61f6e2146723834 by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 25/12/2018 at 01:42. Pushed by hindenburg into branch 'Applications/18.12'. Don't change alternate scrolling state after calling reset() Summary: Alternate Scrolling shouldn't be reset when calling resetModes(), this is to maintain the profile alternate scrolling property after reset() is called, otherwise calling reset() (or clear scrollback and reset) will always make alternate scrolling get disabled regardless of the respective profile property. Also this matches XTerm behavior. Test Plan: 1 - Open a new tab and make sure the alternate scrolling profile property is enabled 2 - Run less or any other application that uses the alternate screen, scrolling with the mouse should work 3 - Quit the previous application and execute `reset` 4 - Repeat 2, notice that now scrolling doesn't work After applying the patch, alternate scrolling mode is not changed after calling reset. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: konsole-devel, hindenburg Tags: #konsole Differential Revision: https://phabricator.kde.org/D17781 (cherry picked from commit c9276130ac06f052f9251d8d67eaf45ff2f87708) M +4-1src/Vt102Emulation.cpp https://commits.kde.org/konsole/b545a812e3bf74157387fd60b61f6e2146723834 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 Kurt Hindenburg changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kon ||sole/c9276130ac06f052f9251d ||8d67eaf45ff2f87708 --- Comment #4 from Kurt Hindenburg --- Git commit c9276130ac06f052f9251d8d67eaf45ff2f87708 by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 25/12/2018 at 01:41. Pushed by hindenburg into branch 'master'. Don't change alternate scrolling state after calling reset() Summary: Alternate Scrolling shouldn't be reset when calling resetModes(), this is to maintain the profile alternate scrolling property after reset() is called, otherwise calling reset() (or clear scrollback and reset) will always make alternate scrolling get disabled regardless of the respective profile property. Also this matches XTerm behavior. Test Plan: 1 - Open a new tab and make sure the alternate scrolling profile property is enabled 2 - Run less or any other application that uses the alternate screen, scrolling with the mouse should work 3 - Quit the previous application and execute `reset` 4 - Repeat 2, notice that now scrolling doesn't work After applying the patch, alternate scrolling mode is not changed after calling reset. Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: konsole-devel, hindenburg Tags: #konsole Differential Revision: https://phabricator.kde.org/D17781 M +4-1src/Vt102Emulation.cpp https://commits.kde.org/konsole/c9276130ac06f052f9251d8d67eaf45ff2f87708 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 --- Comment #3 from Nikos Chantziaras --- The patch applies cleanly to Konsole 18.12.0 and fixes the issue. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 --- Comment #2 from Ahmad Samir --- I forgot to say, thank you for finding a way to reproduce this issue, (I've been hit by it several times, and it was driving me up the wall). -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 402461] Alternate screen buffer scrolling gets disabled after reset
https://bugs.kde.org/show_bug.cgi?id=402461 Ahmad Samir changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||a.samir...@gmail.com --- Comment #1 from Ahmad Samir --- Should be fixed by https://phabricator.kde.org/D17781 -- You are receiving this mail because: You are watching all bug changes.
