[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-09-26 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

Kurt Hindenburg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||konsole/commit/9e3a30fdca20
   ||78e04bee2315ebd2adf678a8126
   ||3

--- Comment #7 from Kurt Hindenburg  ---
Git commit 9e3a30fdca2078e04bee2315ebd2adf678a81263 by Kurt Hindenburg.
Committed on 27/09/2019 at 02:24.
Pushed by hindenburg into branch 'master'.

Remove env variable KONSOLE_PROFILE_NAME

env variables can not be changed after process creation so this
causes this variable to be wrong after profile switching.  Use the
dbus method profile to determine name.
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_SESSION profile

M  +0-1src/SessionManager.cpp

https://invent.kde.org/kde/konsole/commit/9e3a30fdca2078e04bee2315ebd2adf678a81263

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-09-26 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

Kurt Hindenburg  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon
   |konsole/commit/9e3a30fdca20 |sole/9e3a30fdca2078e04bee23
   |78e04bee2315ebd2adf678a8126 |15ebd2adf678a81263
   |3   |

--- Comment #8 from Kurt Hindenburg  ---
Git commit 9e3a30fdca2078e04bee2315ebd2adf678a81263 by Kurt Hindenburg.
Committed on 27/09/2019 at 02:24.
Pushed by scmsync into branch 'master'.

Remove env variable KONSOLE_PROFILE_NAME

env variables can not be changed after process creation so this
causes this variable to be wrong after profile switching.  Use the
dbus method profile to determine name.
qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_SESSION profile

M  +0-1src/SessionManager.cpp

https://commits.kde.org/konsole/9e3a30fdca2078e04bee2315ebd2adf678a81263

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-09-26 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

--- Comment #5 from Kurt Hindenburg  ---
Git commit 05f5663a90106ee8ddcff024c9b30b2b8f1e0f4f by Kurt Hindenburg.
Committed on 27/09/2019 at 02:12.
Pushed by hindenburg into branch 'master'.

Add dbus profile() to return profile name of current session

Instead of relying on env variable KONSOLE_PROFILE_NAME, which is
invalid upon switching profiles, use a dbus method profile().

qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_SESSION profile

M  +4-0src/Session.cpp
M  +5-0src/Session.h

https://invent.kde.org/kde/konsole/commit/05f5663a90106ee8ddcff024c9b30b2b8f1e0f4f

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-09-26 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

--- Comment #6 from Kurt Hindenburg  ---
Git commit 05f5663a90106ee8ddcff024c9b30b2b8f1e0f4f by Kurt Hindenburg.
Committed on 27/09/2019 at 02:12.
Pushed by scmsync into branch 'master'.

Add dbus profile() to return profile name of current session

Instead of relying on env variable KONSOLE_PROFILE_NAME, which is
invalid upon switching profiles, use a dbus method profile().

qdbus $KONSOLE_DBUS_SERVICE $KONSOLE_DBUS_SESSION profile

M  +4-0src/Session.cpp
M  +5-0src/Session.h

https://commits.kde.org/konsole/05f5663a90106ee8ddcff024c9b30b2b8f1e0f4f

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-08-18 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

--- Comment #4 from Kurt Hindenburg  ---
I agree w/ the dbus suggestions - I don't recall why we started using some of
the environment variables.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-08-18 Thread Mariusz Glebocki
https://bugs.kde.org/show_bug.cgi?id=406955

Mariusz Glebocki  changed:

   What|Removed |Added

 CC||m...@arccos-1.net

--- Comment #3 from Mariusz Glebocki  ---
Good solution would be to provide dbus function and konsole command line
argument for getting profile name.

(In reply to Kurt Hindenburg from comment #2)
> I wonder if switching profiles needs to be removed all together or perhaps
> switching profiles is just really a new session in the same tab (using new
> process).

The problem with profiles is that they represent both session/startup options
(mostly first configuration page) and look/feel options.
* Startup options are applicable only for new sessions.
* Look/feel options are mostly shared between session. Users might want to
change those for specific session without restarting it (e.g. swiching to light
color scheme when going outside on sunny day). It is currently possible for
e.g. scrollback size, tab title format, font size.

There are also window settings, which doesn't make sense when opening a new tab
(initial window size, "size hint after window resize", etc) or in a kpart.

Another problem is lack of option sharing. When an user finds their new
favourite font, or finds out some interaction-related option suits them better,
in most cases they want to use them in all their profiles.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-08-17 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

--- Comment #2 from Kurt Hindenburg  ---
I now remember a similar question was asked before.  In Linux, you can't change
the environment variables of an already running process.  You're better off
starting a new session.

I wonder if switching profiles needs to be removed all together or perhaps
switching profiles is just really a new session in the same tab (using new
process).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406955] Switching profile does not update KONSOLE_PROFILE_NAME environment variable

2019-08-17 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=406955

Kurt Hindenburg  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
Summary|KONSOLE_PROFILE_NAME|Switching profile does not
   |environment variable does   |update KONSOLE_PROFILE_NAME
   |not get updated |environment variable

--- Comment #1 from Kurt Hindenburg  ---
You are correct

-- 
You are receiving this mail because:
You are watching all bug changes.