[konsole] [Bug 408939] disallow duplicate bookmarks

2019-08-24 Thread Teemu Rytilahti
https://bugs.kde.org/show_bug.cgi?id=408939

--- Comment #7 from Teemu Rytilahti  ---
Thanks a lot for such a quick turnaround!

(In reply to Kurt Hindenburg from comment #5)
> Do you think Konsole should try to add a menu option to "Remove duplicate
> bookmarks"?

I don't think it's necessary to add more code that needs to be maintained. In
case such feature is wanted, I think a better way would be to extend the DBUS
interface of KBookmarkManager to allow removal of bookmarks. Then it would be
fairly simple to create a script to do that (as I suppose removal of existing
duplicates will be more or less a single shot procedure anyway).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-08-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408939

--- Comment #6 from Nate Graham  ---
Maybe it should just auto-remove them in the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-08-24 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=408939

--- Comment #5 from Kurt Hindenburg  ---
Do you think Konsole should try to add a menu option to "Remove duplicate
bookmarks"?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-08-24 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=408939

Kurt Hindenburg  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon
   |konsole/commit/befaaa0255b2 |sole/befaaa0255b2e620753a6a
   |e620753a6a119268515d4b0b841 |119268515d4b0b8413
   |3   |

--- Comment #4 from Kurt Hindenburg  ---
Git commit befaaa0255b2e620753a6a119268515d4b0b8413 by Kurt Hindenburg, on
behalf of Martin T. H. Sandsmark.
Committed on 24/08/2019 at 19:12.
Pushed by scmsync into branch 'master'.

Do not allow adding duplicates in bookmarks

This currently only catches bookmarks in top-level (ie not sub-folders)

Original code by Tomaz Canabrava 
FIXED-IN: 19.12

https://invent.kde.org/kde/konsole/merge_requests/8

M  +4-5src/BookmarkHandler.cpp
M  +0-2src/BookmarkHandler.h
A  +54   -0src/BookmarkMenu.cpp [License: LGPL]
A  +48   -0src/BookmarkMenu.h [License: LGPL]
M  +1-0src/CMakeLists.txt

https://commits.kde.org/konsole/befaaa0255b2e620753a6a119268515d4b0b8413

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-08-24 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=408939

Kurt Hindenburg  changed:

   What|Removed |Added

   Version Fixed In||19.12
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/kde/
   ||konsole/commit/befaaa0255b2
   ||e620753a6a119268515d4b0b841
   ||3

--- Comment #3 from Kurt Hindenburg  ---
Git commit befaaa0255b2e620753a6a119268515d4b0b8413 by Kurt Hindenburg, on
behalf of Martin T. H. Sandsmark.
Committed on 24/08/2019 at 19:12.
Pushed by hindenburg into branch 'master'.

Do not allow adding duplicates in bookmarks

This currently only catches bookmarks in top-level (ie not sub-folders)

Original code by Tomaz Canabrava 
FIXED-IN: 19.12

https://invent.kde.org/kde/konsole/merge_requests/8

M  +4-5src/BookmarkHandler.cpp
M  +0-2src/BookmarkHandler.h
A  +54   -0src/BookmarkMenu.cpp [License: LGPL]
A  +48   -0src/BookmarkMenu.h [License: LGPL]
M  +1-0src/CMakeLists.txt

https://invent.kde.org/kde/konsole/commit/befaaa0255b2e620753a6a119268515d4b0b8413

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-06-24 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=408939

tcanabr...@kde.org changed:

   What|Removed |Added

 CC||tcanabr...@kde.org

--- Comment #2 from tcanabr...@kde.org ---
https://invent.kde.org/kde/konsole/merge_requests/8

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-06-23 Thread gshah
https://bugs.kde.org/show_bug.cgi?id=408939

gshah  changed:

   What|Removed |Added

 CC||hacker.yod...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-06-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408939

Nate Graham  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 408939] disallow duplicate bookmarks

2019-06-21 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=408939

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
Heh, I also have a ton of duplicate bookmarks.

-- 
You are receiving this mail because:
You are watching all bug changes.