[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #16 from Ahmad Samir  ---
Indeed, bug 393423 pre-dates this one; this bug got blamed for all scrollbar
colours stuff wrongly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=437223

ninj...@gmail.com changed:

   What|Removed |Added

 CC||ninj...@gmail.com

--- Comment #15 from ninj...@gmail.com ---
Bug 393423 is unrelated to this bug. It's about the scrollbar using a specific
Konsole colorscheme, no longer using the same colorscheme that others apps use,
and there being no option for it. 

bug 393423#c17 really belongs to this bug, but anything before Dec 8 09:50:54
2020, which is when this bug was introduced, belongs to 393423.

As to Fusion, when I took a look for
https://invent.kde.org/utilities/konsole/-/merge_requests/394 , I saw no visual
differences caused by this bug for Breeze or Fusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Karl-Johan Karlsson
https://bugs.kde.org/show_bug.cgi?id=437223

Karl-Johan Karlsson  changed:

   What|Removed |Added

 CC||creideiki+kdebugs@ferretpor
   ||n.se

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437223

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=393423

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #14 from Nate Graham  ---
This seems to fix Bug 393423 for me too with Oxygen and MS Windows widget
styles. FUsion still seems to be affected. Can anyone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=437223

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||21.04.2
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #13 from Ahmad Samir  ---
Posted to distributi...@kde.org ML
https://mail.kde.org/pipermail/distributions/2021-May/001011.html so that
packagers pick it up.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437223

Ahmad Samir  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
   |ities/konsole/commit/1cda38 |ities/konsole/commit/585f9a
   |4ec34e70ce052f8d177a8afcb66 |561a07ec1cf5c20af37229667a3
   |5964663 |009362a

--- Comment #12 from Ahmad Samir  ---
Git commit 585f9a561a07ec1cf5c20af37229667a3009362a by Ahmad Samir, on behalf
of Luis Javier Merino Morán.
Committed on 25/05/2021 at 12:07.
Pushed by ahmadsamir into branch 'release/21.04'.

Fix alpha channel of scrollbar colors

Commit 72d604c6cc96e0c2439244382ac07c6601970835 refactored some code
from TerminalDisplay into a new TerminalColor class, and in the process
lost an F on setAlphaF().
(cherry picked from commit 1cda384ec34e70ce052f8d177a8afcb665964663)

M  +1-1src/terminalDisplay/TerminalColor.cpp

https://invent.kde.org/utilities/konsole/commit/585f9a561a07ec1cf5c20af37229667a3009362a

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=437223

ninj...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/1cda38
   ||4ec34e70ce052f8d177a8afcb66
   ||5964663
 Resolution|--- |FIXED

--- Comment #11 from ninj...@gmail.com ---
Git commit 1cda384ec34e70ce052f8d177a8afcb665964663 by Luis Javier Merino
Morán.
Committed on 25/05/2021 at 11:14.
Pushed by ahmadsamir into branch 'master'.

Fix alpha channel of scrollbar colors

Commit 72d604c6cc96e0c2439244382ac07c6601970835 refactored some code
from TerminalDisplay into a new TerminalColor class, and in the process
lost an F on setAlphaF().

M  +1-1src/terminalDisplay/TerminalColor.cpp

https://invent.kde.org/utilities/konsole/commit/1cda384ec34e70ce052f8d177a8afcb665964663

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-25 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #10 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/398

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-22 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=437223

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #9 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/394

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #8 from Konstantin Kharlamov  ---
So, FWIW, even though it is an "occasional feature" that wasn't meant to be
made, but I kinda like the idea. I was thinking more about it, and I think it
could be made to work in less intrusive way that it is now. I think it might be
good to copy behavior of Telegram: it also has invisible scroll slider, but it
makes it appear whenever scroll moves. And, I think on "Find" feature it also
may be useful to make it appear.

But anyway, we need to decide what to with this at the present moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=437223

Konstantin Kharlamov  changed:

   What|Removed |Added

 CC||gcarnei...@hotmail.com

--- Comment #7 from Konstantin Kharlamov  ---
Oops, apparently I was wrong thinking it's a new feature, it seems the
invisible slider is an actual bug.

I did a bisection, and the offending commit didn't mean to make any functional
changes, its description says it simply moves the code around. The commit is:

commit 72d604c6cc96e0c2439244382ac07c6601970835
Author: Gustavo Carneiro 
Date:   Tue Dec 8 09:50:54 2020 -0300

Move terminal color methods to a new class TerminalColor.

CCing the author

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #6 from Konstantin Kharlamov  ---
(In reply to Ahmad Samir from comment #5)
> I see, I thought you were using the Oxygen style.
> 
> So this report is actually about Breeze... sorry for the noise :)

No worries!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #5 from Ahmad Samir  ---
I see, I thought you were using the Oxygen style.

So this report is actually about Breeze... sorry for the noise :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #4 from Konstantin Kharlamov  ---
(In reply to Ahmad Samir from comment #2)
> This is bug 393423.

Thank you for your comment. I have seen this bug, and it would seem odd to me
if it was related, because it was first reported in 2017 year, whereas my
report is a recent regression, which I can make go away by downgrading Konsole
to `20.12.3`.

And in fact, I just installed latest Konsole and tested out with Breeze theme,
and I confirm that the problem is present.

For reference, here's the screenshot with Breeze theme:
https://i.imgur.com/kA5RfKG.png you can see on the right there's no scrollbar
slider.

Do you see a different behavior?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #3 from Ahmad Samir  ---
https://invent.kde.org/utilities/konsole/-/merge_requests/341

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-17 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=437223

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #2 from Ahmad Samir  ---
This is bug 393423.

(You want to leave this report about for the issue in comment#1?).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 437223] Can't OPT-OUT of invisible scrollbar slider

2021-05-16 Thread Konstantin Kharlamov
https://bugs.kde.org/show_bug.cgi?id=437223

--- Comment #1 from Konstantin Kharlamov  ---
I should add, whether OPT-IN or not, the "invisible slider" behavior also might
need modification. The slider should appear when you hover over the scrollbar,
disregarding what is the current slider position. This way it is done on apps
such as Telegram, various gnome settings, and it is this way because the user
doesn't have any way to know where currently the slider is.

But either way, it would be unrelated to the current report. I mentioned it
just to the point why it might not currently be a good default.

-- 
You are receiving this mail because:
You are watching all bug changes.