[konsole] [Bug 448144] regression: copying using ctrl_shift_c no longer works

2022-01-11 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=448144

Kurt Hindenburg  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/830f41
   ||6850911ec4f0104635fee9fb8f8
   ||32c1dcc
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Kurt Hindenburg  ---
Git commit 830f416850911ec4f0104635fee9fb8f832c1dcc by Kurt Hindenburg, on
behalf of Luis Javier Merino MorĂ¡n.
Committed on 11/01/2022 at 15:44.
Pushed by hindenburg into branch 'master'.

Fix copying one single char

Regression introduced by 5919c1fd.  The selection range is inclusive in
both ends.

Thanks to Chiitoo for reporting and to Yerrey Dev for proposing a
solution.

M  +1-1src/Emulation.cpp
M  +0-9src/Screen.cpp
M  +0-1src/Screen.h

https://invent.kde.org/utilities/konsole/commit/830f416850911ec4f0104635fee9fb8f832c1dcc

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 448144] regression: copying using ctrl_shift_c no longer works

2022-01-09 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=448144

Bug Janitor Service  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/574

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 448144] regression: copying using ctrl_shift_c no longer works

2022-01-09 Thread Yerrey Dev
https://bugs.kde.org/show_bug.cgi?id=448144

Yerrey Dev  changed:

   What|Removed |Added

 CC||yer...@protonmail.com

--- Comment #1 from Yerrey Dev  ---
src/Screen.cpp:1428 isSelectionEmpty() returns true with a selection of 1
character as _selTopLeft equals _selBottomRight. This causes the program to
think there is no selection. I don't know the Konsole code well enough, but I
don't see why isSelectionEmpty() can't be just replaced with hasSelection() as
with my compile that seems to fix this problem (I don't know if there can be a
valid selection that is empty).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 448144] regression: copying using ctrl_shift_c no longer works

2022-01-09 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=448144

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com,
   ||ninj...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.