[korganizer] [Bug 379036] attendees icons not dhown

2017-07-13 Thread Martin Koller 
https://bugs.kde.org/show_bug.cgi?id=379036

--- Comment #9 from Martin Koller  ---
(In reply to Laurent Montel from comment #7)
> Wierd that they don't use copy constructor for creating QStyleOptionButton

not possible since given option is a QStyleOptionViewItem

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-07-13 Thread Martin Koller 
https://bugs.kde.org/show_bug.cgi?id=379036

Martin Koller  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/inc
   ||idenceeditor/35440057afcd45
   ||6f9e3640d3e9625b14df0fcd5a
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Martin Koller  ---
Git commit 35440057afcd456f9e3640d3e9625b14df0fcd5a by Martin Koller.
Committed on 13/07/2017 at 07:44.
Pushed by mkoller into branch 'master'.

set iconSize fixing not shown icon

M  +1-0src/attendeecomboboxdelegate.cpp

https://commits.kde.org/incidenceeditor/35440057afcd456f9e3640d3e9625b14df0fcd5a

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-07-13 Thread Laurent Montel 
https://bugs.kde.org/show_bug.cgi?id=379036

--- Comment #7 from Laurent Montel  ---
Wierd that they don't use copy constructor for creating QStyleOptionButton

but it seems logical.
Please commit it.

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-07-13 Thread Martin Koller 
https://bugs.kde.org/show_bug.cgi?id=379036

--- Comment #6 from Martin Koller  ---
Found the bug. When painting, the iconSize member of the style option struct
was not set and defaults to an invalid size. I'm using Qt 5.9.1 if that
matters.

This fixes it:

diff --git a/src/attendeecomboboxdelegate.cpp
b/src/attendeecomboboxdelegate.cpp
index fe8c10f..f13be6d 100644
--- a/src/attendeecomboboxdelegate.cpp
+++ b/src/attendeecomboboxdelegate.cpp
@@ -126,6 +126,7 @@ void AttendeeComboBoxDelegate::paint(QPainter *painter,
const QStyleOptionViewIt
 myOption.rect = option.rect;
 myOption.state = option.state;
 myOption.icon = mEntries[value].first;
+myOption.iconSize = myOption.icon.actualSize(option.rect.size());

 QApplication::style()->drawControl(QStyle::CE_PushButton, ,
painter);
 }

Would this be ok to commit ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-05-31 Thread Allen Winter 
https://bugs.kde.org/show_bug.cgi?id=379036

--- Comment #5 from Allen Winter  ---
no, Breeze.

I don't see how this could be a problem with KOrganizer itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-05-31 Thread Martin Koller 
https://bugs.kde.org/show_bug.cgi?id=379036

--- Comment #4 from Martin Koller  ---
And you're using Oxygen icons ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-05-31 Thread Allen Winter 
https://bugs.kde.org/show_bug.cgi?id=379036

Allen Winter  changed:

   What|Removed |Added

 CC||win...@kde.org

--- Comment #3 from Allen Winter  ---
works fine for me.  no idea why this would be happening.
I'm using self-compiled from master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-05-10 Thread Martin Koller 
https://bugs.kde.org/show_bug.cgi?id=379036

--- Comment #2 from Martin Koller  ---
current from git (Version 5.5.40 alpha1) last compiled on 6.May

-- 
You are receiving this mail because:
You are watching all bug changes.

[korganizer] [Bug 379036] attendees icons not dhown

2017-05-10 Thread Laurent Montel 
https://bugs.kde.org/show_bug.cgi?id=379036

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org

--- Comment #1 from Laurent Montel  ---
Which korganizer version ?ยง

-- 
You are receiving this mail because:
You are watching all bug changes.