[kphotoalbum] [Bug 423979] Using the annotation dialog, one can add arbitrary tags to special categories

2020-07-16 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=423979

--- Comment #3 from Johannes Zarl-Zierl  ---
Git commit 810bf443e397c9c86183f853a4256d819d7a6c65 by Johannes Zarl-Zierl.
Committed on 17/07/2020 at 00:16.
Pushed by johanneszarl into branch 'master'.

ListSelect: really prevent read-only items from being changed

Up until now, one could still check items of a read-only category.

M  +7-1AnnotationDialog/ListSelect.cpp

https://invent.kde.org/graphics/kphotoalbum/commit/810bf443e397c9c86183f853a4256d819d7a6c65

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 423979] Using the annotation dialog, one can add arbitrary tags to special categories

2020-07-08 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=423979

Johannes Zarl-Zierl  changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 423979] Using the annotation dialog, one can add arbitrary tags to special categories

2020-07-08 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=423979

Johannes Zarl-Zierl  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/kphotoalbum/commit/68e
   ||facfc38c9d27442bcfd4f3ac533
   ||40d6f32d1f
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #2 from Johannes Zarl-Zierl  ---
Git commit 68efacfc38c9d27442bcfd4f3ac53340d6f32d1f by Johannes Zarl-Zierl.
Committed on 08/07/2020 at 22:09.
Pushed by johanneszarl into branch 'master'.

ListSelects now can be read-only or selectable-only.

This fixes a long-standing oddity that allowed one to add arbitrary
values to the computed categories "media type" and "folder", as well as
add arbitrary (i.e. non-single-letter) tags to the "tokens" category.

M  +5-1AnnotationDialog/CompletableLineEdit.h
M  +40   -10   AnnotationDialog/ListSelect.cpp
M  +23   -2AnnotationDialog/ListSelect.h
M  +11   -5AnnotationDialog/enums.h
M  +2-0ChangeLog

https://invent.kde.org/graphics/kphotoalbum/commit/68efacfc38c9d27442bcfd4f3ac53340d6f32d1f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 423979] Using the annotation dialog, one can add arbitrary tags to special categories

2020-07-07 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=423979

Johannes Zarl-Zierl  changed:

   What|Removed |Added

Summary|Using the annotation|Using the annotation
   |dialog, one can add |dialog, one can add
   |arbitrary tags to the   |arbitrary tags to special
   |"Tokens" category   |categories

--- Comment #1 from Johannes Zarl-Zierl  ---
As it turns out, the same is also true for the media type and folder
categories, which should be read-only entirely...

-- 
You are receiving this mail because:
You are watching all bug changes.